New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875619 link

Starred by 1 user
Status: Fixed
Owner:
█ joedow@google.com
Last visit > 30 days ago
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 836007



Sign in to add a comment

remoting_unittests fail to start on Win7 bots

Project Member Reported by thakis@chromium.org, Aug 18 
Started e.g. here: https://ci.chromium.org/buildbot/chromium.clang/ToTWin%28dbg%29/1135

What's special about these bots is that they run win7, while most bots run win10.

Ah, looks like it's broken on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20(dbg)(1) too.

My guess is that something in https://chromium-review.googlesource.com/c/chromium/src/+/1164403 requires win10. Speculatively reverting.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80099d5523e8846a22658d5ef436af7a5691ba94

commit 80099d5523e8846a22658d5ef436af7a5691ba94
Author: Joe Downing <joedow@chromium.org>
Date: Tue Aug 21 15:14:49 2018

Reland [Windows Host] Prevent connection hang for hosts with 3D Display Mode enabled

This CL was reverted due to Win7 failures (missing function on DXGI.dll),
apparently remoting_unittests are not run on Win7 as part of the standard set of
CQ trybots which is why this wasn't seen earlier.

The fix is to do a LoadLibrary/GetProcAddress dance to remove the DXGI dependency.

I was able to reproduce this failure on a test Win7 machine and by using the
win_chromium_dbg_ng try-bot.  I then verified the tests were passing using those
two methods and verified the original fix is still valid on my Win10 machine.

BUG= 875619 

Change-Id: Ie56bb9463117b2785c3340ccf4e4785e2e65235d
Reviewed-on: https://chromium-review.googlesource.com/1181528
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584748}
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/basic_desktop_environment.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/desktop_environment_options.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/evaluate_capability.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/host_attributes.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/switches.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/switches.h
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/win/BUILD.gn
[add] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/win/evaluate_3d_display_mode.cc
[add] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/win/evaluate_3d_display_mode.h
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/win/evaluate_d3d.cc
[modify] https://crrev.com/80099d5523e8846a22658d5ef436af7a5691ba94/remoting/host/win/evaluate_d3d.h

Comment 2 by joedow@chromium.org, Aug 21

Status: Fixed (was: Untriaged)
►

Sign in to add a comment