Bookmark bar unclickable when location bar drop down is showing
Reported by
human.p...@gmail.com,
Aug 18
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3526.0 Safari/537.36 Steps to reproduce the problem: 1. Open location bar drop down by typing something or press "↓" when it's on focus 2. Try to click any bookmark on bookmark bar What is the expected behavior? It should work What went wrong? It doesn't. See screenshot for better illustration Did this work before? Yes Chrome version: 70.0.3526.0 Channel: n/a OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Aug 20
human.peng@ Thanks for the issue. Able to reproduce the issue on Windows 10 on the reported version 70.0.3526.0 and the latest Canary 70.0.3528.0 by following the given steps above. Note: Unable to reproduce the issue on Ubuntu 14.04 and Mac OS 10.13.3. Attached is the screen cast for reference. This issue is observed from M-67(67.0.3381.0) build from where the #top-chrome-md flag was introduced and this issue can be observed on older builds by setting #top-chrome-md to 'Refresh' in chrome://flags. Hence this is a Non-Regression issue and marking this as Untriaged for further updates from Dev. Thanks
,
Aug 21
,
Aug 21
I was able to reproduce this, but note it doesn't reproduce if you have the bookmarks bar turned off. In other words, the mode where the bookmarks bar only shows up on the NTP *is* clickable if you focus the omnibox while on the NTP.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f2d827b809b6ba2d5d30f7fa7760792b611e2fc commit 7f2d827b809b6ba2d5d30f7fa7760792b611e2fc Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 22 17:26:30 2018 Omnibox UI Refresh: Don't disable bookmark bar for Refresh popup The bookmark bar has historically been disabled when the Omnibox popup was open. This was because the Omnibox popup was a full-width dropdown that would cover any attached bookmark bar. In that case, we don't want the top couple of pixels of the bookmark bar to spuriously trigger any navigations if the user clicked on it. For MD Refresh, where the dropdown covers the bookmark bar entirely within the popup width, the above logic doesn't make sense. We now let the bookmark bar be clickable even when the popup is open if Material Refresh is on. Bug: 875610 Change-Id: I3b79461ea4a4fcc21e79e22dbcf22c779abc3f99 Reviewed-on: https://chromium-review.googlesource.com/1184262 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585131} [modify] https://crrev.com/7f2d827b809b6ba2d5d30f7fa7760792b611e2fc/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
,
Aug 22
,
Aug 24
Able to reproduce this issue on Windows 10 on the reported version 70.0.3526.0 and the issue is fixed on the latest Canary 70.0.3532.0 as per comment #2. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by susan.boorgula@chromium.org
, Aug 19