New issue
Advanced search Search tips

Issue 875559 link

Starred by 3 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Right Command key triggers right-click menu in menus

Reported by kwpol...@gmail.com, Aug 18 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3521.2 Safari/537.36

Steps to reproduce the problem:
1. Create a non-empty folder on the bookmarks bar
2. Click on the folder and hover any item in the folder
3. Press the Right ⌘ key.

What is the expected behavior?

What went wrong?
The menu should not appear. The Left ⌘ key does not do this. Holding Right ⌘ and then clicking the item will open it in a new tab, as expected.

Did this work before? Yes 

Chrome version: 70.0.3521.2  Channel: dev
OS Version: OS X 10.13.6
Flash Version:

Comment 1 by susan.boorgula@chromium.org, Aug 19

Labels: Needs-Triage-M70 Needs-Bisect

Comment 2 by krajshree@chromium.org, Aug 20

Components: -UI UI>Browser>Bookmarks
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision RegressedIn-70 Triaged-ET ReleaseBlock-Stable Target-70 M-70 FoundIn-70 Pri-1
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on mac 10.13.3 using chrome reported version #70.0.3521.2 and latest canary #70.0.3527.0. Issue is specific to OS-mac.

Bisect Information:
=====================
Good build: 70.0.3503.0
Bad Build : 70.0.3504.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b

From the above change log suspecting below change
Change-Id: Ife1da1c63b1c2cd2b373c2aa6e349e82e1c6ee7b
Reviewed-on: https://chromium-review.googlesource.com/977949

ellyjones@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-70 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!

Comment 3 by ellyjo...@chromium.org, Aug 20

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
That is frankly bizarre. I'll take a look. Not RBS though.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39e4f783f506f3d8f3538814b0082a60af5aa05

commit c39e4f783f506f3d8f3538814b0082a60af5aa05
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Aug 23 16:56:33 2018

views: don't open context menus for VKEY_APPS on Mac

On Mac, VKEY_APPS is actually the right command key, which is not supposed to
behave this way in menus.

Bug:  875559 
Change-Id: I78329273f4ddd5c5cd9aed89669d46f722de118b
Reviewed-on: https://chromium-review.googlesource.com/1186705
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585522}
[modify] https://crrev.com/c39e4f783f506f3d8f3538814b0082a60af5aa05/ui/views/controls/menu/menu_controller.cc

Comment 5 by ellyjo...@chromium.org, Aug 23

Status: Fixed (was: Assigned)

Comment 6 by krajshree@chromium.org, Aug 24

Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #70.0.3521.2

Verified the fix on Mac 10.13.3 using latest chrome version #70.0.3532.0 as per the comment #0.
Attaching screen cast for reference.
Observed that on pressing the the right ⌘ key, the menu did not appear.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
875559.mp4
220 KB View Download
►

Sign in to add a comment