CastFeaturesBrowserTest is flaky on cast_shell_linux |
|||
Issue descriptionI've had some tryjobs fail on this. Here's the flake dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cast_shell_browsertests&builder=tryserver.chromium.linux%3Acast_shell_linux A variety of the tests are crashing: CastFeaturesBrowserTest.PRE_PRE_TestParamsActivateOnBoot CastFeaturesBrowserTest.PRE_PRE_TestOnlyWellFormedFeaturesPersisted CastFeaturesBrowserTest.PRE_PRE_TestFeaturesActivateOnBoot CastFeaturesBrowserTest.PRE_TestOnlyWellFormedFeaturesPersisted CastFeaturesBrowserTest.PRE_TestParamsActivateOnBoot CastFeaturesBrowserTest.PRE_TestFeaturesActivateOnBoot CastFeaturesBrowserTest.TestFeaturesActivateOnBoot It looks like they crash about 1 run in 5. Typical crash: [ RUN ] CastFeaturesBrowserTest.PRE_PRE_TestFeaturesActivateOnBoot [27386:27386:0817/194306.313575:ERROR:headless_native_display_delegate.cc(69)] Not implemented reached in virtual void ui::HeadlessNativeDisplayDelegate::Configure(const display::DisplaySnapshot &, const display::DisplayMode *, const gfx::Point &, display::ConfigureCallback) [27386:27386:0817/194306.313662:ERROR:headless_native_display_delegate.cc(69)] Not implemented reached in virtual void ui::HeadlessNativeDisplayDelegate::Configure(const display::DisplaySnapshot &, const display::DisplayMode *, const gfx::Point &, display::ConfigureCallback) [27386:27389:0817/194306.332247:INFO:url_request_context_factory.cc(318)] Set HttpNetworkSessionParams.enable_quic = 0 [27386:27389:0817/194306.332279:INFO:url_request_context_factory.cc(329)] Set HttpNetworkSessionParams.disable_idle_sockets_close_on_memory_pressure = 0 [27386:27386:0817/194306.332894:INFO:cast_window_manager_aura.cc(223)] Starting window manager, bounds: 0,0 800x600 [27386:27389:0817/194306.333174:INFO:url_request_context_factory.cc(318)] Set HttpNetworkSessionParams.enable_quic = 0 [27386:27389:0817/194306.333193:INFO:url_request_context_factory.cc(329)] Set HttpNetworkSessionParams.disable_idle_sockets_close_on_memory_pressure = 0 [27386:27389:0817/194306.333703:INFO:cast_http_user_agent_settings.cc(63)] Locale changed: accept_language=en-US,en;q=0.9 [27386:27386:0817/194306.334371:INFO:cast_metrics_service_client.cc(108)] Metrics client ID set: 3e773ba2-a10e-47d5-bd75-a4e4cd47f3ec [27386:27386:0817/194306.334581:INFO:cast_metrics_service_client.cc(108)] Metrics client ID set: 3e773ba2-a10e-47d5-bd75-a4e4cd47f3ec [27386:27386:0817/194306.334681:INFO:url_request_context_factory.cc(445)] Initialized app network delegate. [27386:27386:0817/194306.334687:INFO:url_request_context_factory.cc(447)] Initialized system network delegate. [27386:27386:0817/194306.335714:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x000003f33e5c base::debug::StackTrace::StackTrace() #1 0x000007a70ee5 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f66367c2cb0 <unknown> #3 0x00000246e857 chromecast::shell::CastContentBrowserClient::AppendExtraCommandLineSwitches() #4 0x0000025ed853 content::BrowserChildProcessHostImpl::Launch() #5 0x0000027da5cd content::GpuProcessHost::LaunchGpuProcess() #6 0x0000027d7aa5 content::GpuProcessHost::Init() #7 0x0000027d784d content::GpuProcessHost::Get() #8 0x0000027c3bb1 content::BrowserGpuChannelHostFactory::EstablishRequest::EstablishOnIO() #9 0x0000019585eb _ZN4base8internal7InvokerINS0_9BindStateIMN3net12SerialWorkerEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #10 0x000003e98a0d base::debug::TaskAnnotator::RunTask() #11 0x000003e97986 base::MessageLoop::RunTask() #12 0x000003e97e92 base::MessageLoop::DoWork() #13 0x000003f53409 base::MessagePumpLibevent::Run() #14 0x000003e97351 base::MessageLoop::Run() #15 0x000003ebb8f6 base::RunLoop::Run() #16 0x000003f04d0a base::Thread::Run() #17 0x000002601534 content::BrowserProcessSubThread::IOThreadRun() #18 0x00000260147f content::BrowserProcessSubThread::Run() #19 0x000003f05097 base::Thread::ThreadMain() #20 0x000003f467ef base::(anonymous namespace)::ThreadFunc() #21 0x7f6638c94184 start_thread #22 0x7f663688a03d clone halliwell, can you find an owner for this, or disable the tests? (I picked you at random from //chromecast/OWNERS.) Thanks!
,
Aug 22
Eli, can you take a look? If you don't have bandwidth to fix quickly, it would be good to disable the test so we don't interfere with upstream CQ.
,
Aug 22
Yeah, I can look at it. If disabling it is the right thing to do how should I go about disabling the tests?
,
Aug 22
There are a couple options. 1) gtest has a syntax to prefix test name with DISABLED_. This means gtest will never execute this test. 2) If you want to filter more selectively (e.g. run it on specific platforms/build configs), there are some test exclude filters in the gn file.
,
Aug 24
Couldn't reproduce locally, disabled the effected tests for now.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfaeb9a148d65571991917969aae0e156eb8f9a7 commit bfaeb9a148d65571991917969aae0e156eb8f9a7 Author: Eli Ribble <eliribble@chromium.org> Date: Fri Aug 24 13:28:38 2018 Disabled flaky cast feature browser tests These are currently failing ~20% of the time. Needs more investigation, but disabling for now to avoid flakiness in build system. Bug: 875548 Change-Id: I17ac3ee3cb18c21177c58a1a3a66d6591c0ef1cb Reviewed-on: https://chromium-review.googlesource.com/1187836 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eli Ribble <eliribble@chromium.org> Cr-Commit-Position: refs/heads/master@{#585818} [modify] https://crrev.com/bfaeb9a148d65571991917969aae0e156eb8f9a7/chromecast/browser/test/cast_features_browsertest.cc
,
Oct 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mfo...@chromium.org
, Aug 20