New issue
Advanced search Search tips

Issue 875544 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerViewTest#testClickSuggestion__EnableExpandableHeader" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 18

Issue description

"org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerViewTest#testClickSuggestion__EnableExpandableHeader" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydwsSBUZsYWtlImxvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLmNhcmRzLk5ld1RhYlBhZ2VSZWN5Y2xlclZpZXdUZXN0I3Rlc3RDbGlja1N1Z2dlc3Rpb25fX0VuYWJsZUV4cGFuZGFibGVIZWFkZXIM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Detected 3 new flakes for test/step "org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerViewTest#testClickSuggestion__EnableExpandableHeader". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydwsSBUZsYWtlImxvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLmNhcmRzLk5ld1RhYlBhZ2VSZWN5Y2xlclZpZXdUZXN0I3Rlc3RDbGlja1N1Z2dlc3Rpb25fX0VuYWJsZUV4cGFuZGFibGVIZWFkZXIM. This message was posted automatically by the chromium-try-flakes app.
Owner: huayinz@chromium.org
Status: Assigned (was: Untriaged)
huayinz: It looks like this test started flaking after https://chromium-review.googlesource.com/c/chromium/src/+/984377

Please take a look, thanks!
Labels: -Sheriff-Chromium
huayinz@, if it is not caused by your patch and you don't know appropriate person to take look. Please add "Sheriff-Chromium" to ask sheriff to triage. 
Labels: Sheriff-Chromium
Detected 8 new flakes for test/step "org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerViewTest#testClickSuggestion__EnableExpandableHeader". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydwsSBUZsYWtlImxvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLmNhcmRzLk5ld1RhYlBhZ2VSZWN5Y2xlclZpZXdUZXN0I3Rlc3RDbGlja1N1Z2dlc3Rpb25fX0VuYWJsZUV4cGFuZGFibGVIZWFkZXIM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Pri-1 -Sheriff-Chromium Pri-2
Marking the test as flaky and lowering priority.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/020ec57534adec75d29b3a09546ce53014633629

commit 020ec57534adec75d29b3a09546ce53014633629
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Aug 22 14:28:50 2018

Mark NewTabPageRecyclerViewTest#testClickSuggestion as flaky.

Bug:  875544 
Change-Id: I8d2b81e6131df537fbea872753e08cf8f638783f
TBR: huayinz@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1184910
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585011}
[modify] https://crrev.com/020ec57534adec75d29b3a09546ce53014633629/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8575e26c227ba23a68dbc0c62f3769e12ae422a8

commit 8575e26c227ba23a68dbc0c62f3769e12ae422a8
Author: Becky Zhou <huayinz@chromium.org>
Date: Wed Oct 10 01:19:31 2018

Speculative fix for NewTabPageRecyclerViewTest#testClickSuggestion

This test is sometimes run under landscape mode on tester bots and
TouchCommon#singleClickView doesn't work well when more than half the
card view is overlapped by the toolbar.

Bug:  875544 
Change-Id: Ia07ebdb04adf27ffe2f2e72a7cfc4a28c1c4ac40
Reviewed-on: https://chromium-review.googlesource.com/c/1272122
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598164}
[modify] https://crrev.com/8575e26c227ba23a68dbc0c62f3769e12ae422a8/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

Status: Fixed (was: Assigned)
Not seeing flakes on the flakiness dashboard for this test.

Sign in to add a comment