New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875542 link

Starred by 2 users
Status: Fixed
Owner:
twelling...@chromium.org
Closed: Sep 5
Cc:
twelling...@chromium.org
tedc...@chromium.org
mdjones@chromium.org
█ hannahs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 817619
issue 871802
issue 875543
issue 876051



Sign in to add a comment

Update tablet omnibox

Project Member Reported by hannahs@chromium.org, Aug 18 
Let's update the tablet omnibox shape and color to match mobile.

v1 tasklist
  a.) Use light gray when unfocused
  b.) Switch to white when focused

Assigning to me to provide specs for incognito colors to match new 9 patch assets here:
https://bugs.chromium.org/p/chromium/issues/detail?id=875541

Comment 1 by hannahs@chromium.org, Aug 18

Blocking: 875543

Comment 2 by twelling...@chromium.org, Aug 20

Cc: tedchoc@google.com
Components: UI>Browser>Omnibox
Labels: Hotlist-Chrome-Modern

Comment 3 by tedc...@chromium.org, Aug 20

Cc: -tedchoc@google.com tedc...@chromium.org

Comment 4 by twelling...@chromium.org, Aug 22

Labels: -Pri-3 M-71 Pri-1
This is required to delete some Chrome Classic code, which a blocker for our larger toolbar/omnibox refactoring.

Comment 5 by twelling...@chromium.org, Aug 22

Blocking: 876051

Comment 6 by twelling...@chromium.org, Aug 22

Blocking: 817619

Comment 7 by twelling...@chromium.org, Aug 22

Blocking: 871802

Comment 8 by twelling...@chromium.org, Sep 5

Cc: hannahs@chromium.org
Owner: twelling...@chromium.org
Status: Fixed (was: Assigned)
The patch has landed... bugdroid isn't working so posting details:


Modernize the tablet toolbar

BUG=  875541  ,875542

Change-Id: Ifbf0803605b049a1639a4a609c5fc668c8257658
Reviewed-on: https://chromium-review.googlesource.com/1205791
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589006}
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb

commit e5f63c364b9af7b07c96ee91acc572e8ca8df9bb
Author: Theresa <twellington@chromium.org>
Date: Wed Sep 05 21:34:35 2018

Modernize the tablet toolbar

BUG= 875541 , 875542 

Change-Id: Ifbf0803605b049a1639a4a609c5fc668c8257658
Reviewed-on: https://chromium-review.googlesource.com/1205791
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589006}
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-hdpi/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-sw600dp-tvdpi-v17/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-ldrtl-sw600dp-xhdpi-v17/toolbar_background.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-mdpi/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-sw600dp-tvdpi/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-sw600dp-xhdpi/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxxhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabStripSceneLayer.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/layer/tab_handle_layer.cc
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/layer/tab_handle_layer.h
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.h
►

Sign in to add a comment