New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875541 link

Starred by 2 users
Status: Fixed
Owner:
twelling...@chromium.org
Closed: Sep 5
Cc:
twelling...@chromium.org
tedc...@chromium.org
mdjones@chromium.org
█ hannahs@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 817619
issue 871802
issue 875543



Sign in to add a comment

Update tablet 9 patch & image assets

Project Member Reported by hannahs@chromium.org, Aug 18 
Let's update tablets 9 patch assets to be in more alignment with mobile while reducing the apk size by removing assets, removing duplicates, or creating non RTL specific assets.

Changelist:

Tab shape
bg_tabstrip_background_tab.9
bg_tabstrip_incognito_background_tab.9
bg_tabstrip_incognito_tab.9
bg_tabstrip_tab.9

New tab button
btn_tabstrip_new_incognito_tab_normal
btn_tabstrip_new_incognito_tab_pressed
btn_tabstrip_new_tab_normal
btn_tabstrip_new_tab_pressed
(and ldrtl assets)

ic_omnibox_incognito_badge

Tab title fade truncation asset: (not sure if these are the right asset)
tab_strip_fade_for_model_selector
tab_strip_fade 

Possibly remove 9patch for:

- Changing toolbar to white
- Changing omnibox to rounded
- Updating toolbar drop shadow to modern_toolbar_shadow.png

Assigning to me to provide new assets.

Comment 1 by hannahs@chromium.org, Aug 18

Blocking: 875543

Comment 2 Deleted

Comment 3 by twelling...@chromium.org, Aug 20

Cc: tedc...@chromium.org
Components: UI>Browser>TabStrip
Labels: Hotlist-Chrome-Modern

Comment 4 by twelling...@chromium.org, Aug 22

Labels: -Pri-3 M-71 Pri-1
This is required to delete some Chrome Classic code, which a blocker for our larger toolbar/omnibox refactoring.

Comment 5 by twelling...@chromium.org, Aug 22

Blocking: 876051

Comment 6 by twelling...@chromium.org, Aug 22

Blocking: 817619

Comment 7 by twelling...@chromium.org, Aug 22

Blocking: -876051

Comment 8 by twelling...@chromium.org, Aug 22

Blocking: 871802

Comment 9 by hannahs@chromium.org, Aug 22 

Hi! I've just added new assets and specs here:

Asset Drive folder:
https://drive.google.com/open?id=12Mochq_syGB6Eby0iFkzfXwITgcZ7wt1
Interactive redlines:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQueDVZRpBtz/files/MCHtA7U1iMGr62KcVsql7bUsvSbqsx1efxA

Changelist:

1:1 update for 9 patches:
https://drive.google.com/open?id=1c7OR2AlJUxRQbFukD3nkoWHQrvK3eAyH

The new tab button is now the same for RTL & LTR, normal and incognito states so we only need 1 asset (instead of 8):

Remove:
 - btn_tabstrip_new_incognito_tab_normal.png
 - /drawable-ldrtl/btn_tabstrip_new_tab_normal.png
 - /drawable-ldrtl/btn_tabstrip_new_incognito_tab_normal.png

And replace with:
btn_tabstrip_new_tab_normal.png https://drive.google.com/open?id=1w3vyZadq9trQLC03bK4ImiSMqMVmFGhM

If we can shade btn_tabstrip_new_tab_normal.png to G Blue 600 (or use a ripple) for the pressed state:
We can also remove:
 - btn_tabstrip_new_tab_pressed.png
 - btn_tabstrip_new_incognito_tab_pressed.png
 - /drawable-ldrtl/btn_tabstrip_new_tab_pressed.png
 - /drawable-ldrtl/btn_tabstrip_new_incognito_tab_pressed.png

If we can't shade it, replace the above with: https://drive.google.com/open?id=1_9_zezPXckhQX-3AtXGgiAXVTlV7IMUe)

Remove:
 - /drawable-ldrtl/btn_toolbar_reload.png
And replace with:
 - btn_toolbar_reload.png

Remove:
 - /drawable-ldrtl/ic_suggestion_magnifier.png
And replace with:
 - ic_suggestion_magnifier.png

Update btn_tabstrip_switch_incognito.png with: 
https://drive.google.com/open?id=1OBntRrDK8eTAJO3qkqmIZCQ9T2ZkJlVs
 - If we can shade it #80FFFFFF for normal mode, remove and replace btn_tabstrip_switch_normal.png
 - If we can't, use: https://drive.google.com/open?id=1fNmrRI6KskbsLHPsED8Msz8MsOkLhQRO)

If we can shade and resize btn_close.png, we can remove and replace:
 - btn_close_white.png (#FFFFFFFF)
 - btn_tab_close_normal.png (G Grey 800 & resized to 18dp)
 - btn_tab_close_pressed.png (G Blue 600 & resized to 18dp)
 - btn_tab_close_white_normal.png (#FFFFFFFF & resized to 18dp)
 - btn_tab_close_white_pressed.png (#61FFFFFF  & resized to 18dp)

If we update the Incogntio omnibox we can also remove the incognito chip assets:
 - ic_omnibox_incognito_badge.png (G Grey 800)
 - /drawable-ldrtl/ic_omnibox_incognito_badge.png

Double check if all icons are G Grey 800 or if we are reusing mobile assets for:
btn_mic.png
ic_more_vert_black_24dp.png
btn_left.png
btn_right.png

Let me know if you'd like me to split any of these out into separate bugs!

Comment 10 by tedc...@chromium.org, Aug 22

Cc: mdjones@chromium.org
+mdjones - The tabstrip area is drawn in the compositor and I don't believe we have ripple support there.  I don't know if it is easy to tint the asserts in native either.

For the drawable-ldrtl/btn_toolbar_reload.png, that is the RTL asset that would reverse the reload direction.  Is the intent to not do that anymore?  Same with the magnifier?

Comment 11 by mdjones@chromium.org, Aug 22 

We don't have the ripple effect but we should be able to easily tint static assets.

Comment 12 by hannahs@chromium.org, Aug 22 

The ldrt asset changes are mainly just opportunities I saw to remove assets as most icons are fairly universal/non RTL specific.

Looking at the repo, it looks like we don't need RTL versions for any of the toolbar/tabstrip icons except for the btn_suggestion_refine.png one in the omnibox dropdown because it specifically points to the omnibox cursor (though debatable as the opposite hasn't been tested on users).

Total list we can remove:
btn_toolbar_reload.png
ic_omnibox_magnifier.png
ic_share_white_24dp.png
ic_suggestion_magnifier.png

If this would require a lot of work to change, however then feel free to leave as is!

Comment 13 by twelling...@chromium.org, Aug 28

Cc: hannahs@chromium.org
Owner: twelling...@chromium.org
Status: Started (was: Assigned)
I started making the core swap, so I can take this over :)

Comment 14 by hannahs@chromium.org, Aug 30 

Just wanted to add 1 more quick fallback, since we're just doing asset swaps this rev, we can replace the 4 different tab strip close "X"s pngs with just this one? (the delete icon from history (btn_delete_24dp.png) tinted G grey 500 or here's a png that's already colored:
https://drive.google.com/open?id=1GT2uEpJz4Gnp-miHxswHfg7KFuBfUG5J

Comment 15 by twelling...@chromium.org, Aug 31 

Hannah, will you please review the attached screenshots?

I'm still working out a bug with a layer not getting cleared out properly... then I'll send out for review.


I didn't do a swap for:
btn_toolbar_reload.png
ic_omnibox_magnifier.png
ic_share_white_24dp.png
ic_suggestion_magnifier.png

And I'm also not shading any assets yet. Let's do that in a follow-up so this first change can stay focused.

For the icons in the toolbar, we're using dark_mode_tint.xml so they are all the default icon color.
screenshot-emulator-5554-20180831T122816.png
450 KB View Download
screenshot-emulator-5554-20180831T122826.png
285 KB View Download
screenshot-emulator-5554-20180831T122831.png
245 KB View Download
screenshot-emulator-5554-20180831T122353.png
259 KB View Download
screenshot-emulator-5554-20180831T122358.png
420 KB View Download
screenshot-emulator-5554-20180831T122426.png
98.6 KB View Download
screenshot-emulator-5554-20180831T122436.png
91.0 KB View Download
Screenshot_20180831-123908.png
1006 KB View Download
Screenshot_20180831-123915.png
108 KB View Download
Screenshot_20180831-123920.png
139 KB View Download
Screenshot_20180831-123932.png
153 KB View Download
Screenshot_20180831-123940.png
1.1 MB View Download
Screenshot_20180831-123944.png
188 KB View Download

Comment 16 by hannahs@chromium.org, Sep 2 


Everything lgtm! (#14 as a nice to have) And just to sanity check, can you take a screenshot with a max number of tabs, and one in landscape?

Out of curiosity, what resolution is the screenshot emulator at?

Comment 17 by twelling...@chromium.org, Sep 4 

There's isn't a maximum number of tabs... we allow users to open as many as they want. Screenshots attached with lots of tabs opened attached.

The emulator is emulating a Nexus 7; the density is 1.331 (odd) so hdpi.

Some of the screenshots in #15 were taken on a real Nexus 7 (all of the ones with the marshmallow instead of the sdcard icon in the status bar).
screenshot-emulator-5554-20180904T113721.png
226 KB View Download
screenshot-emulator-5554-20180904T113729.png
225 KB View Download
screenshot-emulator-5554-20180904T113738.png
87.7 KB View Download
screenshot-emulator-5554-20180904T113757.png
74.5 KB View Download
screenshot-emulator-5554-20180904T113935.png
225 KB View Download

Comment 18 by twelling...@chromium.org, Sep 4 

1.3 must be tvdpi (per https://material.io/tools/devices/) so the emulator is emulating a 2012 Nexus 7.

The real Nexus 7 that I'm using to test is a 2013 model, with 2.0 density (xhdpi).

Comment 19 by hannahs@chromium.org, Sep 5 

Great! Everything lgtm! Thanks so much!!! <3

Comment 20 by twelling...@chromium.org, Sep 5

Status: Fixed (was: Started)
Screenshot attached of rtl starting window background. Tested on 2012 nexus 7 emulator and nexus 9 and the starting background looked good to me.


The patch has landed... bugdroid isn't working so posting details:


Modernize the tablet toolbar

BUG= 875541 , 875542 

Change-Id: Ifbf0803605b049a1639a4a609c5fc668c8257658
Reviewed-on: https://chromium-review.googlesource.com/1205791
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589006}





We saved 15kb APK size by dropping btn_tabstrip_new_*tab_pressed.png, the rtl versions of btn_tabstrip_new_*tab_normal.png, ic_omnibox_magnifier, and the tvdpi toolbar_background.9.png.

For an explanation of these metrics, see:
https://chromium.googlesource.com/chromium/src/+/master/docs/speed/binary_size/metrics.md#Metrics-for-Android
Specifics:
       -15,162 bytes normalized apk size
           -22 zip entries file count
           -80 bytes secondary dex size
InstallSize:
       -15,096 bytes APK size
     -15,419.2 bytes Estimated installed size
InstallBreakdown (-11,109.2 bytes):
           -14 bytes unwind_cfi (dev and canary only) size
           +17 bytes Non-compiled Android resources size
        -1,025 bytes PNG drawables size
        -1,264 bytes Package metadata size
-223.200000003 bytes Java code size
        -8,600 bytes Compiled Android resources size
Dex:
            -2 entries fields
            -1 entries methods
MonochromePublic.apk_Specifics normalized apk size=-15162


I filed a separate issue 881068 for removing some of the duplicate assets we currently have in favor of tinting.

Hannah, removing the RTL versions of ic_suggestion_magnifier and btn_toolbar_reload will only shave off a couple of kb from the apk size at most... do we think it's a better UX to not flip the icons? If not, I think the very tiny apk hit is worth it.
Screenshot_20180905-132844.png
26.3 KB View Download
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb

commit e5f63c364b9af7b07c96ee91acc572e8ca8df9bb
Author: Theresa <twellington@chromium.org>
Date: Wed Sep 05 21:34:35 2018

Modernize the tablet toolbar

BUG= 875541 , 875542 

Change-Id: Ifbf0803605b049a1639a4a609c5fc668c8257658
Reviewed-on: https://chromium-review.googlesource.com/1205791
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589006}
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-hdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-hdpi/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-hdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-mdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-sw600dp-tvdpi-v17/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-ldrtl-sw600dp-xhdpi-v17/toolbar_background.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_tab_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-mdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-mdpi/ic_omnibox_magnifier.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-sw600dp-tvdpi/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-sw600dp-xhdpi/toolbar_background.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/bg_tabstrip_tab.9.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_switch_incognito.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/drawable-xxxhdpi/btn_tabstrip_switch_normal.png
[delete] https://crrev.com/b1a9183dd954533f233fe3fa51f88bc96b72b257/chrome/android/java/res/drawable-xxxhdpi/ic_omnibox_magnifier.png
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/layout/toolbar_tablet.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabStripSceneLayer.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/layer/tab_handle_layer.cc
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/layer/tab_handle_layer.h
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc
[modify] https://crrev.com/e5f63c364b9af7b07c96ee91acc572e8ca8df9bb/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.h
►

Sign in to add a comment