New issue
Advanced search Search tips

Issue 875526 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

chromeos-machine-id-regen: rewrite in real language

Project Member Reported by vapier@chromium.org, Aug 18

Issue description

this code isn't super complicated, but it's the current #4 crasher for service-failures (and we fixed #1 & #2), and the current logs aren't sufficient to figure out why it's failing.  we could add `logger` calls to try and help track it down, but really this needs a better language so we can have sane error checking & logging.

example http://crash/58038c35eb612bcc:
2018-08-17T09:38:00.531386-04:00 INFO periodic_scheduler[13802]: cros-machine-id-regen: running /usr/sbin/cros-machine-id-regen -r periodic -t 21600
2018-08-17T09:38:00.672358-04:00 WARNING kernel: [14913.133490] init: cros-machine-id-regen-network main process (13775) terminated with status 1

all other possible errors were thrown away :/
 
Hey I'm trying to do my first change so kind of new to this. You say the code isn't super complicated but I'm not sure where to actually find the code? I did a grep chromeos-machine-id-regen and got nothing in my repository. 
the code is entirely in chromiumos-overlay/.  we should move it to platform2.
I'd like to tackle this.

@vapier: Since you're the owner of this script I wanted to ask you: Are you alright with me writing this utility in Rust? The tool needs to not be Python and needs robust error handling, so I think Rust is a good fit.
Cc: cjmcdonald@chromium.org
Rust or C++ sound fine
Owner: cjmcdonald@chromium.org
Status: Started (was: Available)

Sign in to add a comment