FilesAppBrowserTests failing with Polymer 2 |
||||||||||||
Issue descriptionThe following tests are failing when run with --enable-features=WebUIPolymer2: OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads_GuestMode OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive_DriveFs OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeMultipleFileDrive OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeSingleFileDrive OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeMultipleFileDrive OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads_GuestMode TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDrive TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDrive_DriveFs The failures should be fixed and these tests should be removed from the exclusion list in webui_polymer2_browser_tests.filter.
,
Aug 18
,
Aug 22
,
Sep 10
,
Sep 10
@lucmult: Could you take a look at this bug, and help re-assign this accordingly?
,
Sep 11
,
Sep 11
Putting to our triage for prioritization.
,
Sep 13
Here is the error I get when running one of these tests locally: [18:03:49] $ mkcros && time ./out/cOS/browser_tests --gtest_filter="OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads" $(debug_browser_tests) --enable-features=WebUIPolymer2 ninja -C out/cOS chrome browser_tests nacl_helper -j 1120 -l 56 ninja: Entering directory `out/cOS' ninja: no work to do. IMPORTANT DEBUGGING NOTE: each test is run inside its own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with either --single_process (to run the test in one launcher/browser process) or --single-process (to do the above, and also run Chrome in single-process mode). Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from OpenAudioFiles/FilesAppBrowserTest [ RUN ] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads DevTools listening on ws://127.0.0.1:9222/devtools/browser/32aed48a-884a-43a7-aa5d-15ce7f41c6d5 [21803:21803:0913/180400.942598:ERROR:gpu_interface_provider.cc(85)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [21803:21803:0913/180400.972604:INFO:file_manager_browsertest_base.cc(1118)] FileManagerBrowserTest::StartTest audioOpenDownloads [21803:21803:0913/180401.380462:INFO:CONSOLE(1159)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1159) [21803:21803:0913/180401.389118:INFO:CONSOLE(5675)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5675) [21803:21803:0913/180401.390407:INFO:CONSOLE(4960)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4960) [21803:21803:0913/180401.391673:INFO:CONSOLE(5677)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5677) [21803:21803:0913/180401.391729:INFO:CONSOLE(5687)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180401.392028:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180401.393772:INFO:CONSOLE(5687)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180401.393805:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180401.393897:INFO:CONSOLE(5687)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180401.393999:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180401.395834:INFO:CONSOLE(6129)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180401.397227:INFO:CONSOLE(5691)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180401.397381:INFO:CONSOLE(6129)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180401.397893:INFO:CONSOLE(5691)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180401.398025:INFO:CONSOLE(6129)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180401.398659:INFO:CONSOLE(5691)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180401.398698:INFO:CONSOLE(5695)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5695) [21803:21803:0913/180401.960917:INFO:CONSOLE(4957)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4957) [21803:21803:0913/180401.961018:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [21803:21803:0913/180402.083322:INFO:CONSOLE(1283)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome- extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (1283) [21803:21803:0913/180402.740443:INFO:CONSOLE(5675)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5675) [21803:21803:0913/180402.741431:INFO:CONSOLE(5677)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5677) [21803:21803:0913/180402.741806:INFO:CONSOLE(5687)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180402.742367:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180402.744880:INFO:CONSOLE(5687)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180402.744920:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180402.745219:INFO:CONSOLE(5687)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687) [21803:21803:0913/180402.745256:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081) [21803:21803:0913/180402.747418:INFO:CONSOLE(6129)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180402.749600:INFO:CONSOLE(5691)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180402.749649:INFO:CONSOLE(6129)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180402.750454:INFO:CONSOLE(5691)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180402.753434:INFO:CONSOLE(6129)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129) [21803:21803:0913/180402.754012:INFO:CONSOLE(5691)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691) [21803:21803:0913/180402.754062:INFO:CONSOLE(5695)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5695) [21803:21803:0913/180402.811441:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [21803:21803:0913/180403.030096:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.032637:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.033121:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.033638:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.034284:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.042333:INFO:CONSOLE(35)] "Uncaught ReferenceError: assert is not defined", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_ripple.js (35) [21803:21803:0913/180403.133342:INFO:CONSOLE(0)] "[FAIL] [audioOpenDownloads]: API Test Error in [audioOpenDownloads] Actual: null Expected: Beautiful Song Error at extensions::test:243:18 at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/open_audio_files.js:150:19) at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/background.js:106:24) at new Promise (<anonymous>) at StepsRunner.<anonymous> (chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/file_manager/background.js:104:14)", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) [21803:21803:0913/180403.133765:INFO:CONSOLE(0)] "Uncaught (in promise) chrome.test.failure", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0) ../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1145: Failure Failed Failed 1 of 1 tests Stack trace: #0 0x000002155a4c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000002155429 testing::internal::AssertHelper::operator=() #2 0x00000181cd11 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop() #3 0x00000181c6e8 file_manager::FileManagerBrowserTestBase::StartTest() #4 0x000002c325bb content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x0000028144b8 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x000002813401 ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x000001e39a43 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #8 0x7f5fa4c30401 content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x7f5fa4fd1f27 content::StartupTaskRunner::RunAllTasksNow() #10 0x7f5fa4c2ed84 content::BrowserMainLoop::CreateStartupTasks() #11 0x7f5fa4c32913 content::BrowserMainRunnerImpl::Initialize() #12 0x7f5fa4c2cd74 content::BrowserMain() #13 0x7f5fa543cb5b content::ContentMainRunnerImpl::Run() #14 0x7f5fa33c0920 service_manager::Main() #15 0x7f5fa543b0f4 content::ContentMain() #16 0x000002c321f1 content::BrowserTestBase::SetUp() #17 0x0000027c8508 InProcessBrowserTest::SetUp() [21803:21803:0913/180403.515171:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [21803:21803:0913/180403.515218:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads, where GetParam() = 24-byte object <27-B8 68-04 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 F0-70> (4262 ms) [----------] 1 test from OpenAudioFiles/FilesAppBrowserTest (4262 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (4262 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads, where GetParam() = 24-byte object <27-B8 68-04 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 F0-70> 1 FAILED TEST [1/1] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads (5247 ms) 1 test failed: OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads (../../chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:167) real 0m6.090s user 0m4.088s sys 0m1.580s This files_ripple.js is a Polymer element defined here [1]: [1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/files_ripple.js?rcl=6ea5665d0e00b190d168e5c9e05f601915ded9bc
,
Sep 13
I removed the offending "assert()" in my local env and run again and it's still failing because of elements selector incompatibility between Polymer 1_0 and 2_0. In Polymer 1 it doesn't have the shadowRoot, whereas in 2.0 we have to traverse the shadowRoot to find the intended element. The selector that is failing is this one: https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/open_audio_files.js?l=146&rcl=e86f0201184fcd9c399307e3c96ed4a15f9f8a15
,
Sep 13
For the test "TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads".
It fails to find the cr-input element which is WebUI Polymer element.
[18:50:29] $ ./out/cOS/browser_tests --gtest_filter="TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads" --enable-features=WebUIPolymer2
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from TabIndex/FilesAppBrowserTest
[ RUN ] TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads
DevTools listening on ws://127.0.0.1:9222/devtools/browser/98718bde-10f3-416c-a5ed-6ab2b315171f
[38831:38831:0913/185312.236547:ERROR:gpu_interface_provider.cc(85)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[38831:38831:0913/185312.903813:INFO:file_manager_browsertest_base.cc(1118)] FileManagerBrowserTest::StartTest tabindexSaveFileDialogDownloads
[38831:38831:0913/185313.283840:INFO:CONSOLE(5675)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5675)
[38831:38831:0913/185313.283973:INFO:CONSOLE(1159)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1159)
[38831:38831:0913/185313.285042:INFO:CONSOLE(5677)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5677)
[38831:38831:0913/185313.285064:INFO:CONSOLE(5687)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687)
[38831:38831:0913/185313.285432:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081)
[38831:38831:0913/185313.286820:INFO:CONSOLE(5687)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687)
[38831:38831:0913/185313.286914:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081)
[38831:38831:0913/185313.287014:INFO:CONSOLE(5687)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5687)
[38831:38831:0913/185313.287088:INFO:CONSOLE(6081)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6081)
[38831:38831:0913/185313.288758:INFO:CONSOLE(6129)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129)
[38831:38831:0913/185313.290100:INFO:CONSOLE(5691)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691)
[38831:38831:0913/185313.290286:INFO:CONSOLE(6129)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129)
[38831:38831:0913/185313.290765:INFO:CONSOLE(5691)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691)
[38831:38831:0913/185313.290920:INFO:CONSOLE(6129)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6129)
[38831:38831:0913/185313.291591:INFO:CONSOLE(5691)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5691)
[38831:38831:0913/185313.291612:INFO:CONSOLE(5695)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5695)
[38831:38831:0913/185313.384032:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0)
[38831:38831:0913/185313.585114:INFO:CONSOLE(1283)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (1283)
[38831:38831:0913/185313.930602:INFO:CONSOLE(12433)] "Unknown error.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (12433)
[38831:38831:0913/185313.951992:INFO:CONSOLE(18700)] "Uncaught (in promise) Error retrieving Web Store access token.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js (18700)
[38831:38831:0913/185314.175325:INFO:CONSOLE(4960)] "Waiting for the result of selectVolume", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4960)
[38831:38831:0913/185314.189159:INFO:CONSOLE(4957)] "Received the result of selectVolume", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4957)
[38831:38831:0913/185317.255385:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #filename-input-textbox:focus-within is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[38831:38831:0913/185320.296397:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #filename-input-textbox:focus-within is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
[38831:38831:0913/185323.338445:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #filename-input-textbox:focus-within is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
Still waiting for the following processes to finish:
./out/cOS/browser_tests --disable-gpu-process-for-dx12-vulkan-info-collection --enable-features=WebUIPolymer2 --enable-pixel-output-in-tests --gtest_also_run_disabled_tests --gtest_filter=TabIndex/FilesAppBrowserTest.Test/tabindexSaveFileDialogDownloads --remote-debugging-port=9222 --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.n8NPVQ/resultstNbvND/test_results.xml --ui-test-action-timeout=1000000 --use-gpu-in-tests --user-data-dir=/tmp/.org.chromium.Chromium.n8NPVQ/dpxIEmK
[38831:38831:0913/185326.382701:INFO:CONSOLE(156)] "at RemoteCallFilesApp.RemoteCall.waitForElement (/remote_call.js:182:15): Element #filename-input-textbox:focus-within is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (156)
...
,
Sep 14
,
Sep 14
I created crbug.com/884030 to track the cr-input issue and assigned to scottchen@ who created this component.
,
Sep 14
CC tapted@ who's maintaining Audio app as well. tapted@, see comment #8 and #9 about the issue with Audio app and Polymer2.
,
Sep 14
> In Polymer 1 it doesn't have the shadowRoot, whereas in 2.0 we have to traverse the shadowRoot to find the intended element. Are you not seeing any shadowRoot existence when running with Polymer 1? If that's the case that would mean that (accidentally?) FilesApp is running with ShadyDOM (polyfil of Shadow DOM) instead of using native Shadow DOM, and the failures could be related to that, rather than Polymer 1 vs Polymer 2 differences. Can you verify if that's the case? FWIW in order to properly configure Polymer 1 the code should be importing the configuration file at [1] somewhere. Usually this is done by having an HTML import like at [2] before any other Polymer code has loaded. [1] https://cs.chromium.org/chromium/src/ui/webui/resources/js/polymer_config.js [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/welcome/welcome.html?l=7
,
Sep 14
Oh good news. 1. audio_player.html was using: "chrome://resources/polymer/v1_0/polymer/polymer.html" 2. I replaced with: "chrome://resources/html/polymer.html" It indeed now shows shadowRoot and fails in the same way it fails in Polymer2. So we can fix the selector to account for the shadowRoot. The bad news is that the v1_0/ version of polymer.html is used in many more places: https://cs.chromium.org/search/?q=chrome://resources/polymer/v1_0/polymer/polymer.html&type=cs I'm trying to just replace all Files app entries from the v1_0/polymer to the other one, let see how broken our tests get. crrev.com/c/1226478 Sed cmd to change: $ ack-grep --html 'chrome://resources/polymer/v1_0/polymer/polymer.html' ./ui/file_manager/ -l |xargs sed -i 's/chrome:\/\/resources\/polymer\/v1_0\/polymer\/polymer.html/chrome:\/\/resources\/html\/polymer.html/g'
,
Sep 14
It only breaks in Audio tests: OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive_DriveFs OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeSingleFileDrive AudioPlayerBrowserTest.TogglePlayState OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive AudioPlayerBrowserTest.ChangeTracks OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads AudioPlayerBrowserTest.ChangeVolumeLevel OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatOneModeMultipleFileDrive OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeSingleFileDrive AudioPlayerBrowserTest.ChangeTracksPlayListIcon AudioPlayerBrowserTest.ChangeTracksPlayList OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads_GuestMode OpenAudioFiles/FilesAppBrowserTest.Test/audioRepeatAllModeMultipleFileDrive
,
Sep 14
Thanks for following up on this. > The bad news is that the v1_0/ version of polymer.html is used in many more places: Good find. These need to be audited as well. Some of them could be harmless if some other element on the same page has already imported the correct polymer.html file. As part of migrating to Polymer 2 (which forces native Shadow DOM) similar problems will be surfaced one way or the other.
,
Sep 14
> Sed cmd to change: Thank you for providing the command. I am attempting to update all remaining ChromeOS usages to use the correct polymer.html file at https://chromium-review.googlesource.com/c/chromium/src/+/1227174
,
Sep 19
Any updates here?
,
Sep 19
I'm investigating the Audio Player compatibility with Polymer 2 in this CL crrev.com/c/1226478. Current status is, I converted the polymer config to have the shadow root in Polymer 1 and fixed our tests to work with Polymer 1, however they're still failing with Polymer 2 which needs further investigation.
,
Sep 19
My suggestion is to first land a CL that converts Audio Player to use the proper Polymer 1 configuration. Then examine the required fixes that are Polymer 2 specific on a separate CL. That will make it easier for reviewing/helping with the Polymer 2 specific issues (usually the failures are well known, as they have been encountered in previous such fixes).
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff082c9239dab7f23f08dc40bb02909ec5f2e754 commit ff082c9239dab7f23f08dc40bb02909ec5f2e754 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Sep 20 07:16:58 2018 Fix Audio Player Polymer 1 configuration Audio Player was using Shadow DOM's polyfil, aka Shady DOM which is included in Polymer1. Chrome has had a fully working native Shadow DOM for quite a while. The remaining Polymer WebUI has already been using native Shadow DOM. This fix is to make Audio Player elements and tests compatible with Polymer2, tests still require further work to pass in Polymer2. Replace all occurrences of: "chrome://resources/polymer/v1_0/polymer/polymer.html" with: "chrome://resources/html/polymer.html" The new polymer.html configures Polymer 1.0 to run with ShadowRoot making these polymer elements be compatible with Polymer 2.0. Fix Audio Player tests: 1. Audio Player is compound of 3 main Polymer elements: * "audio-player": main component which use the other 2 below. * "control-panel": buttons to control, like play, pause, next, etc. * "track-list": List of all tracks to be played. 2. Files app and Audio player test utils, has the ability to query elements deep in the ShadowRoot, however it requires an Array of selectors instead of a simple string selector. For every element that has a ShadowRoot, we need to provide an element on the selector array. E.g.: ['audio-player', 'control-panel', '.some-class']: Gets "audio-player" then selects in its shadowRoot for "control-panel", then selects ".some-class" in "control-panel" shadowRoot. 3. Define "trackListQuery" and "controlPanelQuery" to make simpler to traverse these 2 Polymer sub-components. 4. Fix all selectors to make explicit the component traversal. Test: browser_tests --gtest_filter="AudioPlayer*:OpenAudioFiles*" Bug: 875525 Change-Id: I64e94452ff4cc8eb51137620013ad0cf00101f67 Reviewed-on: https://chromium-review.googlesource.com/1226478 Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592709} [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/audio_player/elements/audio_player.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/audio_player/elements/control_panel.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/audio_player/elements/repeat_button.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/audio_player/elements/track_info_panel.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/audio_player/elements/track_list.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_icon_button.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_ripple.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_toast.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/files_tooltip.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/file_manager/foreground/elements/icons.html [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/integration_tests/audio_player/click_control_buttons.js [modify] https://crrev.com/ff082c9239dab7f23f08dc40bb02909ec5f2e754/ui/file_manager/integration_tests/file_manager/open_audio_files.js
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf30bb4f3ce8301881a14a394383da5e5dc3c60d commit bf30bb4f3ce8301881a14a394383da5e5dc3c60d Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Sep 20 09:12:05 2018 Include utils for Polymer2 and remove /deep/ Bug: 875525 , 884963 Change-Id: I3b3d290e2f7cc9781b7af3d3caea4508330e21ff Reviewed-on: https://chromium-review.googlesource.com/1234118 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592729} [modify] https://crrev.com/bf30bb4f3ce8301881a14a394383da5e5dc3c60d/ui/file_manager/audio_player/audio_player.html [modify] https://crrev.com/bf30bb4f3ce8301881a14a394383da5e5dc3c60d/ui/file_manager/integration_tests/audio_player/open_audio_files.js
,
Sep 20
@lucmult: Are the tests passing as of r592729? If so could you also send a CL to enable those tests in Polymer 2 (see the currently disabled tests list at [1]). [1] https://cs.chromium.org/chromium/src/testing/buildbot/filters/webui_polymer2_browser_tests.filter?l=39-80
,
Sep 21
Hi dpapad@, No it's still failing with Polymer 2, the current issue is that our test is issuing a click [1] on <repeat-button> and the event handler [2] isn't being triggered. The click is issued in a child element of <repeat-button>, but it seems that the issue is the event listener binding has changed from v1 to v2. Do you have any guidance on how to make (event listener) [2] compatible with both Polymer v1 and v2? [1] - https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/open_audio_files.js?l=448-460&rcl=35c12ead7ded45e0b4a60731e57f9835aa2d80ef [2] - https://cs.chromium.org/chromium/src/ui/file_manager/audio_player/elements/repeat_button.js?l=31-33&rcl=22a72b84ba6c065cb4da38c4f8167fc901004659
,
Sep 21
Can you try adding the "composed: true" flag in all events fired from https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/background/js/test_util_base.js? In Shadow DOM v1 there are changes on which events bubble and which do not (which suprisingly does not depend only on the "bubbles" property). Also it is a bit odd that you are faking click events, instead of manually triggering the native click() method. Perhaps you can have a look at [1], which already provides a bunch of helper methods for triggering various events. Finally, the use of the synthetic 'tap' event is unnecessary. Not sure if it causes any problems here, but you should try changing to native 'click' events instead, and see if the errors still happen (more context at [2]). [1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js [2] https://bugs.chromium.org/p/chromium/issues/detail?id=812035
,
Sep 21
Awesome, thanks for sharing this! I managed to make it pass with Polymer 2 with 2 changes:
1. Add {composed: true} to the click event.
2. Convert event listener from tap to click.
I'm preparing a CL to fix this.
Also, I checked the click event from mock-interactions.js and it's crating a MouseEvent in the same way we're creating in test_util_base.js: new MouseEvent() + dispatchEvent() [1]. So I won't change anything there.
[1] - https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js?l=145-162&rcl=c551571fa598ce656b209364cc4e407f354067c8
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/145d1ebac5a0ff716bb81bf893b16b013eb83b02 commit 145d1ebac5a0ff716bb81bf893b16b013eb83b02 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Sep 24 01:25:26 2018 Fix AudioPlayer tests for Polymer2 Change <repeat-button> element to use click event instead of tap, because when binding to tap event Polymer2 wasn't triggering the click event. Change test util functions that issues events to have "composed: true" [1] when they have "bubbles: true", this allows events to propagate across shadow DOM boundary. Add trailing comma to repeat_button.js so auto-formatter leave those lines expanded. Update all functions that were updated in test_util_base.js to use const/let instead of var. [1] - https://developer.mozilla.org/en-US/docs/Web/API/Event/composed Bug: 875525 Change-Id: I5890f159ee54a5d6254b90621776cd82ef9bd7b5 Reviewed-on: https://chromium-review.googlesource.com/1237754 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#593466} [modify] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/ui/file_manager/audio_player/elements/repeat_button.js [modify] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/ui/file_manager/file_manager/background/js/test_util_base.js [modify] https://crrev.com/145d1ebac5a0ff716bb81bf893b16b013eb83b02/ui/file_manager/file_manager/main.html
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b6c091d625955bedb42bb841e18c32bbc0e8dea commit 3b6c091d625955bedb42bb841e18c32bbc0e8dea Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Sep 25 01:17:18 2018 Re-enable Audio tests for Polymer2 Bug: 875525 Change-Id: I81fd85c9636537f15735801ead680ef5d67c3bea Reviewed-on: https://chromium-review.googlesource.com/1237755 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593795} [modify] https://crrev.com/3b6c091d625955bedb42bb841e18c32bbc0e8dea/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44e8732981d49adca32c87209864ee0be2aa48aa commit 44e8732981d49adca32c87209864ee0be2aa48aa Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Sep 25 01:18:09 2018 Fix touch latency for AudioPlayer Issue is explained here [1], in crrev.com/c/1237754 I changed this in the Files app, however the Polymer component is used in Audio Player, so moving the CSS fix to Audio Player. [1] - https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away Bug: 875525 Change-Id: Ideab2aa12fe6dcdfb5665be201e867687e046c50 Reviewed-on: https://chromium-review.googlesource.com/1239801 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593796} [modify] https://crrev.com/44e8732981d49adca32c87209864ee0be2aa48aa/ui/file_manager/audio_player/css/audio_player.css [modify] https://crrev.com/44e8732981d49adca32c87209864ee0be2aa48aa/ui/file_manager/file_manager/main.html
,
Sep 25
Issue 875482 has been merged into this issue.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4306f705e7a0e75af6365ee378f0969e1b08b6af commit 4306f705e7a0e75af6365ee378f0969e1b08b6af Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Sep 26 07:31:43 2018 Properly enable OpenAudioFiles tests with Polymer 2. Files app browser tests have prefix in their name which is separated by "/", so change the "." to "/" to match OpenAudioFile prefix. Bug: 875525 Change-Id: I5eff0c51bb57fbe37bc33bc9aa00853ac7a6415e Reviewed-on: https://chromium-review.googlesource.com/1242723 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594240} [modify] https://crrev.com/4306f705e7a0e75af6365ee378f0969e1b08b6af/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecb6e0bbd19c8e6cf357cc730f1a4b711144d7c7 commit ecb6e0bbd19c8e6cf357cc730f1a4b711144d7c7 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Sep 27 07:27:12 2018 Fix Polymer config for Video Player In Video Player polymer_config.js was writing to console.error: polymer_config.js:15 Polymer is already defined. This was caused by <paper-slider.html> being included before any of WebUI or Files app Polymer element had a chance to initialize with the right config (polymer.html), which in turn was causing Polymer elements to render without shadowRoot. Change <files_icon_button> to include before <paper-slider> so it loads the right config/polymer.html. Test: --gtest_filter='VideoPlayerBrowserTest.CheckInitialElements' also manually checked for no error message and play button has shadowRoot. Bug: 875525 Change-Id: I9888992cce762cd6eae8c31a8042119506fd5590 Reviewed-on: https://chromium-review.googlesource.com/1248342 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#594620} [modify] https://crrev.com/ecb6e0bbd19c8e6cf357cc730f1a4b711144d7c7/ui/file_manager/file_manager/background/js/test_util_base.js [modify] https://crrev.com/ecb6e0bbd19c8e6cf357cc730f1a4b711144d7c7/ui/file_manager/integration_tests/video_player/check_elements.js [modify] https://crrev.com/ecb6e0bbd19c8e6cf357cc730f1a4b711144d7c7/ui/file_manager/video_player/video_player.html
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d4bc971b10234d6d11cc8fefc49b8982096d122 commit 2d4bc971b10234d6d11cc8fefc49b8982096d122 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 27 21:25:13 2018 File Manager: Use :not(:defined) instead of :unresolved for Polymer 2. Bug: 739532, 875525 Change-Id: I4bf43b572eb7a9417f373b414ef101d1d580ef4b Reviewed-on: https://chromium-review.googlesource.com/1249840 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594870} [modify] https://crrev.com/2d4bc971b10234d6d11cc8fefc49b8982096d122/ui/file_manager/file_manager/foreground/css/file_manager.css
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9131e23fce5e06ca617ba7a47952e592889d4d3e commit 9131e23fce5e06ca617ba7a47952e592889d4d3e Author: dpapad <dpapad@chromium.org> Date: Thu Sep 27 22:23:55 2018 File Manager: Enable TabIndex/FilesAppBrowserTest tests with Polymer 2. Bug: 875525 Change-Id: I2bc1181d19b7bc3841da6d7306c85983f6656927 Reviewed-on: https://chromium-review.googlesource.com/1249903 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594895} [modify] https://crrev.com/9131e23fce5e06ca617ba7a47952e592889d4d3e/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 28
I don't think there are any File Manager tests remaining to be enabled. Thanks all! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rbpotter@chromium.org
, Aug 18