New issue
Advanced search Search tips

Issue 875523 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete depot_tool's cipd recipe_module in favor of the one in recipes-py

Project Member Reported by bpastene@chromium.org, Aug 18

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/aac04034f188f96e39d77509ac5b1d967874c918

commit aac04034f188f96e39d77509ac5b1d967874c918
Author: Ben Pastene <bpastene@chromium.org>
Date: Mon Aug 20 18:10:19 2018

Add service-account support to recipe-py's cipd recipe_module.

Copied from the one in depot_tools, but tweaked it a little.

Bug: 869533, 875523
Change-Id: If1fb67cf87f73f30c033fc1f6158a7aa6b23ba28
Reviewed-on: https://chromium-review.googlesource.com/1180508
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/win64.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/basic_with_no_refs_or_tags.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/search-empty-result.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/__init__.py
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/pkg_bad_file.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/mac64.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/basic.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/describe-many-instances.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/basic_pkg.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/README.recipes.md
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/pkg_bad_mode.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/pkg_bad_verfile.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.expected/basic_with_pkg_vars.json
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/service_account/api.py
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/examples/full.py
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/service_account/examples/full.py
[modify] https://crrev.com/aac04034f188f96e39d77509ac5b1d967874c918/recipe_modules/cipd/api.py

Cc: iannu...@google.com

Sign in to add a comment