Clear Backgrounds attribution on existing NTPs when a theme is applied |
||||||
Issue descriptionChrome Version: 70.0.3523.0 OS: MacOS 10.13.6 What steps will reproduce the problem? (1) Configure a Chrome Background with an attribution (2) Open lots of NTPs (3) Set a theme What is the expected result? Custom Background data is cleared. What happens instead? Attribution still remains on the open NTPs Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 17
The second half of this screencast shows what's happening: https://drive.google.com/file/d/1SBk9Fys1t7u1RuDKWH2E2i7K_aI8w13P/view?usp=sharing
,
Aug 20
,
Aug 21
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9ed1fd3176664505d1b41a524cc91e3064647e4 commit a9ed1fd3176664505d1b41a524cc91e3064647e4 Author: Weilun Shi <sweilun@chromium.org> Date: Wed Aug 22 05:50:51 2018 [NTP] Clear attribution on the existing tab when apply a theme Now we will clear the attribution also on the existing tab when a theme is applied. Bug: 875519 Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 Reviewed-on: https://chromium-review.googlesource.com/1181684 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584964} [modify] https://crrev.com/a9ed1fd3176664505d1b41a524cc91e3064647e4/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/a9ed1fd3176664505d1b41a524cc91e3064647e4/chrome/test/data/local_ntp/local_ntp_browsertest.html
,
Aug 22
,
Aug 22
,
Aug 22
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e239788986a0d75072f257e8d9bc72cf84abe6 commit 68e239788986a0d75072f257e8d9bc72cf84abe6 Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Aug 23 15:56:41 2018 Revert "[NTP] Clear attribution on the existing tab when apply a theme" This reverts commit a9ed1fd3176664505d1b41a524cc91e3064647e4. Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. If the revert does not fix the bots (which I think is likely), we will reland it. Original change's description: > [NTP] Clear attribution on the existing tab when apply a theme > > Now we will clear the attribution also on the existing tab when a theme > is applied. > > Bug: 875519 > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > Reviewed-on: https://chromium-review.googlesource.com/1181684 > Commit-Queue: Weilun Shi <sweilun@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584964} TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875519 Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 Reviewed-on: https://chromium-review.googlesource.com/1186762 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585499} [modify] https://crrev.com/68e239788986a0d75072f257e8d9bc72cf84abe6/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/68e239788986a0d75072f257e8d9bc72cf84abe6/chrome/test/data/local_ntp/local_ntp_browsertest.html
,
Aug 23
Is there a bug for the WebRTC bot issue that we can follow?
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ba6157da5deaf27070304f37a193bd6f813df2f commit 9ba6157da5deaf27070304f37a193bd6f813df2f Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Aug 23 16:34:36 2018 Reland "[NTP] Clear attribution on the existing tab when apply a theme" This reverts commit 68e239788986a0d75072f257e8d9bc72cf84abe6. Reason for revert: As expected, this revert had nothing to do with the WebRTC bot failures. Original change's description: > Revert "[NTP] Clear attribution on the existing tab when apply a theme" > > This reverts commit a9ed1fd3176664505d1b41a524cc91e3064647e4. > > Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. > If the revert does not fix the bots (which I think is likely), we will reland it. > > Original change's description: > > [NTP] Clear attribution on the existing tab when apply a theme > > > > Now we will clear the attribution also on the existing tab when a theme > > is applied. > > > > Bug: 875519 > > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > > Reviewed-on: https://chromium-review.googlesource.com/1181684 > > Commit-Queue: Weilun Shi <sweilun@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584964} > > TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875519 > Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 > Reviewed-on: https://chromium-review.googlesource.com/1186762 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585499} TBR=guidou@chromium.org,kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org Change-Id: Ie612910fe42f3ce69fb87186ab3a4b5bc1331afc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875519 Reviewed-on: https://chromium-review.googlesource.com/1186802 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585510} [modify] https://crrev.com/9ba6157da5deaf27070304f37a193bd6f813df2f/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/9ba6157da5deaf27070304f37a193bd6f813df2f/chrome/test/data/local_ntp/local_ntp_browsertest.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ramyan@chromium.org
, Aug 17