ActiveDirectoryJoinTests failing with Polymer 2 |
||||||||||
Issue descriptionThe following tests are failing when run with --enable-features=WebUIPolymer2: ActiveDirectoryJoinTest.TestActiveDirectoryEnrollment_DistinguishedName ActiveDirectoryJoinTest.TestActiveDirectoryEnrollment_ErrorCard ActiveDirectoryJoinTest.TestActiveDirectoryEnrollment_Success ActiveDirectoryJoinTest.TestActiveDirectoryEnrollment_UIErrors These tests should be fixed to work correctly with Polymer 2 and they should be removed from the exclusions list in webui_polymer2_browser_tests.filter.
,
Aug 20
,
Aug 31
,
Sep 19
Any updates on this?
,
Sep 19
Note that the tests are almost certainly failing because of the usage of /deep/ at https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc?l=40-52. There might be more things to be fixed, but this is definitely one of them, also see issue 860069.
,
Sep 19
Hey, sorry for the delay. I wanted to fix it together with new tests, but the CL got delayed. I've uploaded fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1233839 . Did I enable test correctly?
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb8a5c1c9693f580f0ac5fee919559b43958e587 commit fb8a5c1c9693f580f0ac5fee919559b43958e587 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Sep 19 18:31:09 2018 cros: Fix browsertests for polymer2 Now uses '$.' instead of '/deep/' to find elements BUG= chromium:875480 Change-Id: I1c7282cce123047987f436fd90018409545069f7 Reviewed-on: https://chromium-review.googlesource.com/1233839 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592486} [modify] https://crrev.com/fb8a5c1c9693f580f0ac5fee919559b43958e587/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/fb8a5c1c9693f580f0ac5fee919559b43958e587/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 19
,
Sep 24
Hi Roman, does this bug require any manual verification by Enterprise Test Team? If yes, could you please provide some steps for that?
,
Sep 25
The tests enabled by fb8a5c1c9693f580f0ac5fee919559b43958e587 are failing in ChromiumOS MSan bots. See issue 887577 .
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9d86c3a93db21da7f138ed62161abbdf0e7fcba commit a9d86c3a93db21da7f138ed62161abbdf0e7fcba Author: Colin Blundell <blundell@chromium.org> Date: Tue Sep 25 08:46:11 2018 Revert "cros: Fix browsertests for polymer2" This reverts commit fb8a5c1c9693f580f0ac5fee919559b43958e587. Reason for revert: These tests have been failing since they were re-enabled. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/8598 for an example failing run, and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/8598 for an example failure. Original change's description: > cros: Fix browsertests for polymer2 > > Now uses '$.' instead of '/deep/' to find elements > > BUG= chromium:875480 > > Change-Id: I1c7282cce123047987f436fd90018409545069f7 > Reviewed-on: https://chromium-review.googlesource.com/1233839 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Roman Sorokin <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592486} TBR=alemate@chromium.org,rsorokin@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:875480 Change-Id: Id849341926fdc966454fbc6dc3c4ff9b180dc43c Reviewed-on: https://chromium-review.googlesource.com/1242356 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#593864} [modify] https://crrev.com/a9d86c3a93db21da7f138ed62161abbdf0e7fcba/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/a9d86c3a93db21da7f138ed62161abbdf0e7fcba/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 25
Re-opening since the CL was reverted.
,
Oct 3
rsorokin: Any updates here?
,
Oct 4
Investigating here: https://bugs.chromium.org/p/chromium/issues/detail?id=887577#c8
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/425cab216f5202b395bffe79dcabd40e31bea0d6 commit 425cab216f5202b395bffe79dcabd40e31bea0d6 Author: Roman Sorokin <rsorokin@chromium.org> Date: Mon Oct 15 07:57:22 2018 Disable Active Directory enrollment tests on MSAN BUG= chromium:887577 , chromium:875480 Change-Id: I0579e0694e1e4f7c9ed3f1988f623b2558a36e40 Reviewed-on: https://chromium-review.googlesource.com/c/1278167 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599585} [modify] https://crrev.com/425cab216f5202b395bffe79dcabd40e31bea0d6/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/425cab216f5202b395bffe79dcabd40e31bea0d6/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Oct 15
,
Oct 15
,
Nov 20
Marking as Verified since Blockedon bug was removed. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rbpotter@chromium.org
, Aug 17