New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Batch toggle “Available offline” is inconsistent

Project Member Reported by mcirimele@chromium.org, Aug 17

Issue description

Chrome OS version: 67.0.3396.99 (OFFICIAL)

Steps to reproduce:
1. Mark one file as "Available offline" in Google Drive (through files app
2. Select that file and one or more others which are not "Available offline". 
3. Open the overflow or context menu

Expected result:
"Available offline" is not checked. 

Observed result:
"Available offline" is checked, implying that all selected files are available offline. 

I have we either: 
1. Fix this to a more conservative model where the toggle is only checked if all selected files are indeed "Available offline".
or
2. Remove the option to toggle "Available offline" when there is more than one file selected. 

 
Labels: OS-Chrome
Labels: CrOSFilesCategory-Offline
Labels: -M-70
Labels: Files-Fixit-2018
Owner: dats@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/018f70d487f23cab5eb11a71b565255a8d7779a4

commit 018f70d487f23cab5eb11a71b565255a8d7779a4
Author: Sergei Datsenko <dats@chromium.org>
Date: Tue Nov 20 05:56:18 2018

Prefer 'unpinned' as a default view of mixed states

If we select several files some of which are pinned and some not, show
overall state as unpinned as it's less confusing.

BUG= chromium:875473 

Change-Id: I2d1cfe6b901b39bf2f20a8d1c766c405df22c565
Reviewed-on: https://chromium-review.googlesource.com/c/1343467
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609606}
[modify] https://crrev.com/018f70d487f23cab5eb11a71b565255a8d7779a4/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Status: Fixed (was: Started)

Sign in to add a comment