Show “Available offline” in overflow menu for Drive files |
|||||||
Issue descriptionChrome OS version: 70.0.3524.2 (STABLE) Right now Files app shows the "Available offline" action in the overflow menu in an unexpected way. I'd like to make it more consistent by always showing this action in the overflow menu for Drive files. Steps to reproduce: 1. Open a Google Drive folder 2. Select a Drive file which is not "available offline". 3. Open the overflow menu (available offline is not shown) 4. Open the context menu 5. Select "Available offline" 6. Open the overflow menu Expected result: When a Drive file is selected, the overflow menu displays the "Available offline" action. Observed result: The first time the Drive file is selected "Available offline" is only shown in the context menu. Once it's been toggled on or off for a file it is shown in the overflow menu as well. Video: https://photos.app.goo.gl/GUQR68yZBiMAa3Ag8
,
Aug 17
Related to issue 875474
,
Aug 22
,
Sep 10
,
Oct 4
,
Oct 12
This looks fixed in version 71.0.3572.0
,
Oct 16
I am still able to reproduce on M71. Available offline does not appear in the 3-dot menu when I initially select a Drive file.
,
Nov 20
,
Nov 20
I don't think this repros with DriveFS, investigating.
,
Nov 20
So the problem is that there is some state that remains un-initialized until the first time the context menu is shown, including toggle-offline which needs to be set to show this particular option. We need to see if we can enable this option while the user is clicking on the files, not just when they right click. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/actions_controller.js?rcl=e56b996c63979983935a9fa2cb48aef1c36d4f1d&l=138
,
Nov 20
I have a lead on a fix.
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb4a8628a4c89b9958910ee9ba89cb6dd333f95 commit cfb4a8628a4c89b9958910ee9ba89cb6dd333f95 Author: Stuart Langley <slangley@google.com> Date: Wed Nov 21 05:22:29 2018 Fix "Available Offline" not showing in the file context menu. If the right click context menu has not been displayed at least once then some commands are not available in the file select menu. If the use is clicking through files, we will assume that the menu context should be FILE_LIST temporarily so that the correct options appear in the file selection menu. Added integration test to validate. Bug: 875466 Change-Id: Idc79f1c25690b6c8bb7f585e0c9261ea4bec3996 Reviewed-on: https://chromium-review.googlesource.com/c/1343812 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609919} [modify] https://crrev.com/cfb4a8628a4c89b9958910ee9ba89cb6dd333f95/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/cfb4a8628a4c89b9958910ee9ba89cb6dd333f95/ui/file_manager/file_manager/foreground/js/actions_controller.js [modify] https://crrev.com/cfb4a8628a4c89b9958910ee9ba89cb6dd333f95/ui/file_manager/integration_tests/file_manager/drive_specific.js
,
Nov 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mcirimele@chromium.org
, Aug 17