New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875465 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mosys' dash is crashing with SIGSYS for sigreturn

Project Member Reported by lhchavez@chromium.org, Aug 17

Issue description

Chrome OS: Kevin R70-10974.0.0 (ARM)

https://storage.cloud.google.com/chromeos-autotest-results/228225856-ssola/chromeos6-row4-rack16-host11/sysinfo/var/spool/crash/dash.20180817.062942.12622.dmp.txt

Operating system: Linux
                  0.0.0 Linux 4.4.147-14727-gdd19f2ab4fc1 #1 SMP PREEMPT Thu Aug 16 04:37:21 PDT 2018 aarch64
CPU: arm
     ARMv1 ARM part(0x4100d0b0) features: half,thumb,fastmult,vfpv2,edsp,neon,vfpv3,tls,vfpv4,idiva,idivt
     6 CPUs

GPU: UNKNOWN

Crash reason:  SIGSYS
Crash address: 0x0
Process uptime: not available

Thread 0 (crashed)
 0  libc-2.23.so!__default_sa_restorer + 0x5
     r0 = 0x00000011    r1 = 0x00000000    r2 = 0x09c517c0    r3 = 0x00000001
     r4 = 0xff9b9bd8    r5 = 0x09c51818    r6 = 0x00000001    r7 = 0x00000077
     r8 = 0x09c517c0    r9 = 0x09c51800   r10 = 0xff9b9c58   r12 = 0x09c4ef6c
     fp = 0x00000000    sp = 0xff9b98d0    lr = 0xe831a291    pc = 0xe831a296
    Found by: given as instruction pointer in context
 1  dash!dowait [jobs.c : 1141 + 0x7]
     sp = 0xff9b992c    pc = 0x09c4327b
    Found by: stack scanning
 2  libc-2.23.so!wait4 + 0x5
     sp = 0xff9b9930    pc = 0xe8367508
    Found by: stack scanning

Loaded modules:
0x09c3c000 - 0x09c4dfff  dash  ???  (main)
0xe82f4000 - 0xe83cafff  libc-2.23.so  ???  (WARNING: Corrupt symbols, libc-2.23.so, E1F4EA2C889188FB8E9FDA4BFA334F240)
0xe83e1000 - 0xe83f8fff  ld-2.23.so  ???

ARM syscall calling convention says that r7 is the syscall number, which corresponds to 119 (__NR_sigreturn), which checks out with being called from __default_sa_restorer.
 
There's not much for me to go on here, especially because there aren't any mosys logs here. I'll take your word that this is mosys related and that sigreturn is the issue. It's added to the arm seccomp filter in https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/1178966 . This CL has been trying to pass through the CQ.
Status: Fixed (was: Untriaged)
Thanks! Marking this as fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/201ba0c36e647d1eb8dda1f45f8609403b4fb8c6

commit 201ba0c36e647d1eb8dda1f45f8609403b4fb8c6
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Sep 05 12:11:48 2018

mosys: Remove non-existent syscall for amd64

This change removes the `sigreturn` syscall from the amd64 policy, which
does not exist on that architecture (only on ARM).

BUG= chromium:875465 
TEST=pre-CQ, minijail0 -H | grep sigreturn

Change-Id: I887628c3d5e9b09a73d95c4170440d4b0f9cfb10
Reviewed-on: https://chromium-review.googlesource.com/1204630
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/201ba0c36e647d1eb8dda1f45f8609403b4fb8c6/seccomp/mosys-seccomp-amd64.policy

Labels: Merge-Request-70
Owner: lhchavez@chromium.org
Status: Assigned (was: Fixed)
#3 needs to be merged back to R70 or else mosys will crash on startup in all scenarios.
Labels: -Pri-3 Pri-1
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 19

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: lhchavez@chromium.org
Owner: rajatja@google.com
assigning to the same owner as the internal bug.
Cc: jclinton@chromium.org
I'm really confused here. I'm not the code owner, but I just sent the cherry-pick and hopefully that will fix the problem.
Cc: geo...@google.com
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/ba87f835e3aa63e07314dbfe182bc13a47c778bf

commit ba87f835e3aa63e07314dbfe182bc13a47c778bf
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Thu Sep 20 16:20:17 2018

mosys: Remove non-existent syscall for amd64

This change removes the `sigreturn` syscall from the amd64 policy, which
does not exist on that architecture (only on ARM).

BUG= chromium:875465 
TEST=pre-CQ, minijail0 -H | grep sigreturn

Change-Id: I887628c3d5e9b09a73d95c4170440d4b0f9cfb10
Reviewed-on: https://chromium-review.googlesource.com/1204630
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 201ba0c36e647d1eb8dda1f45f8609403b4fb8c6)
Reviewed-on: https://chromium-review.googlesource.com/1235150
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/ba87f835e3aa63e07314dbfe182bc13a47c778bf/seccomp/mosys-seccomp-amd64.policy

Status: Fixed (was: Assigned)
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 24

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70

Sign in to add a comment