New issue
Advanced search Search tips

Issue 875461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 875443



Sign in to add a comment

History page: fix Polymer 2 test failures

Project Member Reported by rbpotter@chromium.org, Aug 17

Issue description

The following history tests are failing when run with --enable-features=WebUIPolymer2:

MaterialHistoryListTest.All
MaterialHistoryFocusTest.All

On Mac 10.12 bot only:
MaterialHistoryItemTest.All

Tests may need to be run multiple times to observe failures.
 
Blocking: 875443
Owner: aee@chromium.org
Status: Started (was: Untriaged)
Found an issue with the overlay opacity when testing the history page with polymer 2.
toolbar_overlay_opacity_0.png
250 KB View Download
toolbar_overlay_opacity_1.png
292 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4184918e72d3095810e9bfdd73666f6580fe10d6

commit 4184918e72d3095810e9bfdd73666f6580fe10d6
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Aug 28 21:40:40 2018

History WebUI: fixing flaky tests for history-list

Bug:  875461 
Change-Id: I25a40040ae12d78b15a97bbbbfb64358a0ac0990
Reviewed-on: https://chromium-review.googlesource.com/1187268
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586859}
[modify] https://crrev.com/4184918e72d3095810e9bfdd73666f6580fe10d6/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/4184918e72d3095810e9bfdd73666f6580fe10d6/chrome/test/data/webui/md_history/history_list_test.js

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0552e8e78665c4ea6b9a09df821416cad86dcba

commit d0552e8e78665c4ea6b9a09df821416cad86dcba
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Aug 28 22:08:41 2018

History WebUI: fix toolbar overlay opacity for polymer 2

Bug:  875461 
Change-Id: I96099f4318647d21fd7c7921d1e35f986a8378d2
Reviewed-on: https://chromium-review.googlesource.com/1188772
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586880}
[modify] https://crrev.com/d0552e8e78665c4ea6b9a09df821416cad86dcba/chrome/browser/resources/md_history/history_toolbar.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc91cffea7d4218bd8d9da7d79c723a166370203

commit fc91cffea7d4218bd8d9da7d79c723a166370203
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Aug 30 20:28:54 2018

History WebUI: fixing history focus test for polymer 2

Bug:  875461 
Change-Id: I4198baa1461241de0f869cb63fb688a74ba5e337
Reviewed-on: https://chromium-review.googlesource.com/1194338
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587739}
[modify] https://crrev.com/fc91cffea7d4218bd8d9da7d79c723a166370203/chrome/test/data/webui/md_history/md_history_focus_test.js

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73aac0c979622e51b170f5005be8b01157e48a2a

commit 73aac0c979622e51b170f5005be8b01157e48a2a
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Sep 04 19:37:02 2018

History WebUI: reducing flakiness of history-item test for Polymer 2

Bug:  875461 
Change-Id: I134b2475aef0653dd453b1b6fa5df7c566ef6f70
Reviewed-on: https://chromium-review.googlesource.com/1195100
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588615}
[modify] https://crrev.com/73aac0c979622e51b170f5005be8b01157e48a2a/chrome/test/data/webui/md_history/history_item_test.js

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/470fe36dc87833b9bae4177e74e6a3ec0c3d383b

commit 470fe36dc87833b9bae4177e74e6a3ec0c3d383b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Sep 06 20:07:22 2018

History WebUI: enabling polymer 2 tests for previously flaky tests

Bug:  875461 
Change-Id: I9acdff2f8b1afd4075057add7b1799f7e6a11141
Reviewed-on: https://chromium-review.googlesource.com/1211102
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589258}
[modify] https://crrev.com/470fe36dc87833b9bae4177e74e6a3ec0c3d383b/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/470fe36dc87833b9bae4177e74e6a3ec0c3d383b/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/687ae85531a6f6cedfcc637e3bb8382e0bc7b81c

commit 687ae85531a6f6cedfcc637e3bb8382e0bc7b81c
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Mon Sep 10 18:06:53 2018

WebUI: adding back test that was removed from filter by mistake

Bug:  875461 
Change-Id: If447041f60540c338a368a94900632693d1a18d3
Reviewed-on: https://chromium-review.googlesource.com/1217162
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589979}
[modify] https://crrev.com/687ae85531a6f6cedfcc637e3bb8382e0bc7b81c/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42b0bc474b3d7ce33ccdff41f4b502f9f9e71397

commit 42b0bc474b3d7ce33ccdff41f4b502f9f9e71397
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Sep 17 23:29:15 2018

MD History: Enable test on non-Polymer2

MaterialHistoryListTest.All was disabled on Windows due to being flaky
in webui_polymer2_browser_tests. Enable it in general but add it to
the Polymer 2 test filter blacklist so that it does not run with
Polymer 2 and is tracked with the other Polymer 2 failures.

Bug:  875461 
Change-Id: Iedf4db2f698261fc63dcbfecfa1ee3c33a96d8df
Reviewed-on: https://chromium-review.googlesource.com/1227363
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591872}
[modify] https://crrev.com/42b0bc474b3d7ce33ccdff41f4b502f9f9e71397/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/42b0bc474b3d7ce33ccdff41f4b502f9f9e71397/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Sign in to add a comment