New in Chrome 69, file inputs not hidden by `width: 0`
Reported by
etlov...@gmail.com,
Aug 17
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) Gecko/20100101 Firefox/62.0 Example URL: See attached bug.html Steps to reproduce the problem: 1. Open attached bug.html, which has a file input with `width: 0` applied to it. What is the expected behavior? The default browser UI (a button with the text "Choose File") for the input does not appear. What went wrong? In Chrome 69 and 70, the default browser UI for the file input does appear. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes This works in Version 68.0.3440.106 (Official Build) (64-bit) Does this work in other browsers? Yes Chrome version: Version 69.0.3497.42 (Official Build) beta (64-bit) Channel: beta OS Version: OS X 10.13 Flash Version: There are other ways we could get the file input to hide using CSS, if this was a deliberate change to bring Chrome's behavior in line with a spec. But it's definitely a change between version 68 and 69. Results across a few browsers: * Chrome version 69.0.3497.42 (Official Build) beta (64-bit): input appears * Chrome version 70.0.3524.0 (Official Build) canary (64-bit): input appears * Chrome version 68.0.3440.106 (Official Build) (64-bit): input does not appear * Firefox 62.0b17 (64-bit): input does not appear * Safari version 11.1.2 (13605.3.8): input does not appear
,
Aug 20
,
Aug 21
Thanks for filing the issue! Able to reproduce the issue on reported chrome version 69.0.3497.42 and on the latest canary 70.0.3528.0 using Mac 10.13.1, Windows 10 and Ubuntu 14.04 Bisect Information: ------------------- Good Build: 69.0.3469.0 Bad Build: 69.0.3472.0 You are probably looking for a change made after 569455 (known good), but no later than 569456 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/86dc2b012bbf240af7b7e01d5884b40fb0f1703d..e5bce71132d5e5f143fb68c22f0eecb60cff249a Suspecting: https://chromium.googlesource.com/chromium/src/+/e5bce71132d5e5f143fb68c22f0eecb60cff249a Review URL: https://chromium-review.googlesource.com/c/chromium/src/+/1110496 @Xianzhu Wang: Please help in assigning it to the right owner if this is not related to your change. Adding RB-Stable as this seems to be a recent regression, please remove if this isn't required.
,
Aug 21
,
Aug 21
I'm changing the target to 70 because the issue can be easily worked around. Also with width other than 0, we have been not issuing the clip since SPv175 was enabled, which will be fixed altogether.
,
Aug 21
Adding milestone, otherwise the bug won't appear in triaging query.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f commit 66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Aug 22 16:23:15 2018 [PE] Enable ControlClip for LayoutFileUploadControl We had output the clip before SPv175 with ClipRecorder but not for SPv175. We also lost the early return on empty clip_rect in crrev.com/569459. See https://chromium-review.googlesource.com/c/chromium/src/+/1110496/6/third_party/blink/renderer/core/paint/file_upload_control_painter.cc for the old code. Now enable ControlClip for LayoutFileUploadControl to emit the clip. Bug: 875460 Change-Id: I0f4141eeb0e8d62ccdf9aa4df368f65e207df7d3 Reviewed-on: https://chromium-review.googlesource.com/1183783 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585038} [add] https://crrev.com/66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f/third_party/WebKit/LayoutTests/paint/input/file-input-clip-expected.html [add] https://crrev.com/66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f/third_party/WebKit/LayoutTests/paint/input/file-input-clip.html [modify] https://crrev.com/66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f/third_party/blink/renderer/core/layout/layout_file_upload_control.cc [modify] https://crrev.com/66cfe1a9a7ad5b5a64d2e7cd864551ae13dcd61f/third_party/blink/renderer/core/layout/layout_file_upload_control.h
,
Aug 22
Fixed in M70. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by robliao@chromium.org
, Aug 17Status: Untriaged (was: Unconfirmed)