Settings page: Fix Polymer 2 test failures |
||||
Issue descriptionThe following settings tests are failing when run with --enable-features=WebUIPolymer2: General failures (may pass on a single invocation, use --gtest_repeat=5 to observe failures): CrSettingsAllSitesTest.All CrSettingsLanguagesPageTest.InputMethods CrSettingsMainPageTest.MainPage CrSettingsMenuTest.SettingsMenu CrSettingsPeoplePageSyncAccountControlTest.All CrSettingsPeoplePageSyncPageTest.All CrSettingsPeoplePageTest.All CrSettingsRouteDynamicParametersTest.All CrSettingsSiteDataTest.All CrSettingsSiteListTest.SiteList CrSettingsSubpageTest.All CrSettingsZoomLevelsTest.All PasswordsAndFormsBrowserTest.uiTests SettingsAdvancedPageBrowserTest.Load Tests that fail only on official builds: CrSettingsChromeCleanupPageTest.All CrSettingsIncompatibleApplicationsPageTest.All CrSettingsMetricsReportingTest.All A11y tests likely failing due to usage of /deep/: SettingsA11yManagePasswords.* SettingsA11ySignOut.* SettingsAccessibilityTest.* Interactive UI tests that are flaky on debug builds: CrSettingsAnimatedPagesTest.All CrSettingsFocusRowBehavior.FocusTest CrSettingsSyncPageTest.All
,
Aug 17
,
Aug 17
,
Aug 31
Started working on AllSitesTest failure.
,
Sep 6
,
Sep 6
Currently fixing CrSettingsLanguagesPageTest.InputMethods and CrSettingsSiteDataTest.All.
,
Sep 7
Actually, it looks like the languages and site data tests may have been fixed by the fix for crbug.com/881104 . Still working on AllSites.
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f38486f94919f03b334b8bd16916b22c558a9c89 commit f38486f94919f03b334b8bd16916b22c558a9c89 Author: rbpotter <rbpotter@chromium.org> Date: Tue Sep 11 21:13:36 2018 WebUI Polymer2: Make CrSettingsAllSitesTest work in Polymer 2. This CL addresses 3 bugs that were causing CrSettingsAllSitesTest to fail with Polymer 2: (1) async() call in basic_page.js did not pause for all of layout on the first call in Polymer 2 (likely due to layout not being finished by the end of attached()). This was also causing a runtime error on content, languages, and other subpages. (2) The test itself also called async(), which did not wait long enough for rendering to complete before checking various elements. (3) The computed subpageScrollTarget was set earlier in Polymer 2, as its computation function was called with some parameters undefined. This resulted in overriding the non-null, defined default scroll target for iron-list with an undefined scroll target, which caused toggleScrollListener(), called from the resize handler in iron-list, to fail. Bug: 875452 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2a09020a798fdf806a98c7c9d9d32547b3fa310f Reviewed-on: https://chromium-review.googlesource.com/1208448 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590475} [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/chrome/browser/resources/settings/basic_page/BUILD.gn [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/chrome/browser/resources/settings/global_scroll_target_behavior.js [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/chrome/test/data/webui/settings/all_sites_tests.js [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/testing/buildbot/filters/webui_polymer2_browser_tests.filter [modify] https://crrev.com/f38486f94919f03b334b8bd16916b22c558a9c89/third_party/closure_compiler/externs/pending.js
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21d67c546e421d6570f9f865d5299ebd4844570 commit a21d67c546e421d6570f9f865d5299ebd4844570 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 13 02:21:57 2018 Settings WebUI: Fix a few more tests to pass with Polymer 2. Fixing and enabling: - CrSettingsMetricsReportingTest.All - CrSettingsSiteListTest.SiteList - CrSettingsZoomLevelsTest.All - SettingsAdvancedPageBrowserTest.Load Bug: 875452 ,860069 Change-Id: I4f4cce412cff2f250076dc4a19e090f2ffe0feae Reviewed-on: https://chromium-review.googlesource.com/1220039 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#590897} [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/browser/resources/settings/site_settings/site_list_entry.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/test/data/webui/settings/metrics_reporting_tests.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/test/data/webui/settings/settings_page_browsertest.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/test/data/webui/settings/test_util.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/chrome/test/data/webui/settings/zoom_levels_tests.js [modify] https://crrev.com/a21d67c546e421d6570f9f865d5299ebd4844570/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a67666adf1d4f52f814c59f22bef20096fb565ee commit a67666adf1d4f52f814c59f22bef20096fb565ee Author: rbpotter <rbpotter@chromium.org> Date: Thu Sep 13 19:23:33 2018 Web UI Polymer 2: Fix some settings tests failing in Polymer 2 Bug: 875452 Change-Id: Ia64b2bebd1a56a7a6b3a4753d2b3f967b5316c52 Reviewed-on: https://chromium-review.googlesource.com/1222696 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#591110} [modify] https://crrev.com/a67666adf1d4f52f814c59f22bef20096fb565ee/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/a67666adf1d4f52f814c59f22bef20096fb565ee/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/a67666adf1d4f52f814c59f22bef20096fb565ee/chrome/test/data/webui/settings/people_page_sync_page_test.js [modify] https://crrev.com/a67666adf1d4f52f814c59f22bef20096fb565ee/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/364ea97b74f90ecd43ce258d5947c15126732107 commit 364ea97b74f90ecd43ce258d5947c15126732107 Author: dpapad <dpapad@chromium.org> Date: Wed Sep 19 18:00:17 2018 Settings WebUI: Enable a few more tests with Polymer 2. Enabling the following tests: CrSettingsChromeCleanupPageTest.All (Removed usage of /deep/) CrSettingsMultidevicePageContainerTest.All (already passing) Also fixing some overlapping inclusion and exclusion patterns (they should not exist). Bug: 875452 ,860069 Change-Id: Iba0546d24f032af0bfa4c3fb15b383e2ef938269 Reviewed-on: https://chromium-review.googlesource.com/1227479 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592466} [modify] https://crrev.com/364ea97b74f90ecd43ce258d5947c15126732107/chrome/test/data/webui/settings/chrome_cleanup_page_test.js [modify] https://crrev.com/364ea97b74f90ecd43ce258d5947c15126732107/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js [modify] https://crrev.com/364ea97b74f90ecd43ce258d5947c15126732107/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e7f295a685c5f9433feb3c5ff92a287d57494f2 commit 6e7f295a685c5f9433feb3c5ff92a287d57494f2 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 20 00:43:03 2018 Settings WebUI: Enable some a11y tests with Polymer 2. Specifically: - SettingsA11yManagePasswords - SettingsAccessibilityTest - TtsAccessibilityTest Bug: 875452 Change-Id: Ia9d5d6d12be9802ab4dece199c46d60c2d2b8867 Reviewed-on: https://chromium-review.googlesource.com/1235198 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592634} [modify] https://crrev.com/6e7f295a685c5f9433feb3c5ff92a287d57494f2/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56c8f8260cb6218b2db446165b0674485138a7c6 commit 56c8f8260cb6218b2db446165b0674485138a7c6 Author: dpapad <dpapad@chromium.org> Date: Thu Sep 20 17:35:01 2018 Settings WebUI: Re-enable People page tests for Polymer 2. These seem to have been fixed at r591110, but they were not properly re-enabled. Bug: 875452 Change-Id: Icdab27f5afd81a8e8c2c7a30b1ab76ec05ee8d8e Reviewed-on: https://chromium-review.googlesource.com/1235285 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592855} [modify] https://crrev.com/56c8f8260cb6218b2db446165b0674485138a7c6/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/148ba5bf4b95c502e6198f64117882420085cb7b commit 148ba5bf4b95c502e6198f64117882420085cb7b Author: rbpotter <rbpotter@chromium.org> Date: Tue Sep 25 18:21:37 2018 WebUI Polymer2: Fix CrSettingsPeoplePageSyncAccountControlTest Fix this test to pass with Polymer 2. Bug: 875452 Change-Id: Ic2f9c38409f3659b0b4cfee7abe51e2ea562903f Reviewed-on: https://chromium-review.googlesource.com/1239717 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594015} [modify] https://crrev.com/148ba5bf4b95c502e6198f64117882420085cb7b/chrome/test/data/webui/settings/sync_account_control_test.js [modify] https://crrev.com/148ba5bf4b95c502e6198f64117882420085cb7b/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06197f92d96eb98ff7aca94255c18f649a1f5e36 commit 06197f92d96eb98ff7aca94255c18f649a1f5e36 Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 03 21:32:40 2018 Settings WebUI: Enable various already passing tests in Polymer2. Enabling: CrSettingsIncompatibleApplicationsPageTest CrSettingsLanguagesPageTest.AddLanguagesDialog CrSettingsLanguagesPageTest.LanguageMenu CrSettingsLanguagesPageTest.Spellcheck Bug: 875452 , 875454 Change-Id: I5b5fa399bb76ec133e2cfee1ae3b949eedb7c7db Reviewed-on: https://chromium-review.googlesource.com/c/1259465 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596376} [modify] https://crrev.com/06197f92d96eb98ff7aca94255c18f649a1f5e36/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Oct 9
Since all the tests listed in the original comment have now been fixed and removed from the filter file, marking this bug fixed.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771b9c3b9efa94feac2003d34e63839338fef472 commit 771b9c3b9efa94feac2003d34e63839338fef472 Author: dpapad <dpapad@chromium.org> Date: Thu Oct 11 23:48:08 2018 Settings WebUI: Fix and re-enable CrSettingsPrivacyPageTest with Polymer 2. Bug: 875452 Change-Id: I5832a08ed1f13745e46fe64af8d4a61aa6ddb9db Reviewed-on: https://chromium-review.googlesource.com/c/1278126 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599016} [modify] https://crrev.com/771b9c3b9efa94feac2003d34e63839338fef472/chrome/browser/resources/settings/people_page/sync_account_control.js [modify] https://crrev.com/771b9c3b9efa94feac2003d34e63839338fef472/testing/buildbot/filters/webui_polymer2_browser_tests.filter |
||||
►
Sign in to add a comment |
||||
Comment 1 by rbpotter@chromium.org
, Aug 17