Extensions Page: Fix Polymer 2 test failures |
||||
Issue descriptionThe following Extensions tests are failing when run with --enable-features=WebUIPolymer2: General failures (some may require repeated runs to fail): CrExtensionsRuntimeHostPermissionsTest.All CrExtensionsRuntimeHostsDialogTest.All A11y tests likely failing due to using /deep/ (see crbug.com/860069): CrExtensionsA11yTest.* CrExtensionsA11yTestWithMultipleExensions.* CrExtensionsErrorConsoleA11yTest.* CrExtensionsShortcutA11yTestWithExtensions.* CrExtensionsShortcutA11yTestWithNoExtensions.* Tests may need to be run multiple times to observe failures
,
Aug 17
,
Aug 30
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/431c82825a47865cb1d66cb8b6f4eae59b32cbc9 commit 431c82825a47865cb1d66cb8b6f4eae59b32cbc9 Author: rbpotter <rbpotter@chromium.org> Date: Fri Aug 31 01:16:59 2018 Extensions page: Fix RuntimeHost tests to work with Polymer 2 Bug: 875449 Change-Id: Ic4c32e2d8c2385dafb778a517d5622d58e090bd7 Reviewed-on: https://chromium-review.googlesource.com/1197264 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#587896} [modify] https://crrev.com/431c82825a47865cb1d66cb8b6f4eae59b32cbc9/chrome/browser/resources/md_extensions/runtime_hosts_dialog.js [modify] https://crrev.com/431c82825a47865cb1d66cb8b6f4eae59b32cbc9/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 19
FYI, I started on a CL to fix the a11y Extension tests, before seeing that they were already part of this bug. https://chromium-review.googlesource.com/c/chromium/src/+/1233113
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e93f2c581b0a5b96c3015b928f4c620e713c45c9 commit e93f2c581b0a5b96c3015b928f4c620e713c45c9 Author: dpapad <dpapad@chromium.org> Date: Wed Sep 19 18:09:53 2018 Extensions WebUI: Fix a11y tests to work with Polymer 2. Basically eliminating usage of /deep/ selectors. Bug: 875449 ,860069 Change-Id: I7e53055b712ee6701f240ba6f50c9eb1918d88b1 Reviewed-on: https://chromium-review.googlesource.com/1233113 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592474} [modify] https://crrev.com/e93f2c581b0a5b96c3015b928f4c620e713c45c9/chrome/test/data/webui/extensions/a11y/extensions_a11y_test.js [modify] https://crrev.com/e93f2c581b0a5b96c3015b928f4c620e713c45c9/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbpotter@chromium.org
, Aug 17