Print Preview: Fix Polymer 2 automated test failures |
|||
Issue descriptionThe following Print Preview tests are failing or flaky when run with --enable-features=WebUIPolymer2: Failing in general on all platforms: PrintPreviewDestinationListTest.FilterDestinations PrintPreviewDestinationListTest.FireDestinationSelected Flaky on debug builds only: PrintPreviewDestinationDialogInteractiveTest.FocusSearchBox PrintPreviewPrintHeaderInteractiveTest.FocusPrintOnReady
,
Aug 17
,
Aug 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e882388db428f59a12784e0d3dd77a698fab296f commit e882388db428f59a12784e0d3dd77a698fab296f Author: rbpotter <rbpotter@chromium.org> Date: Sat Aug 18 01:15:46 2018 WebUI Polymer2: Fix print preview tests Destinations list tests broke in Polymer2 after being fixed originally. Add handling for undefined destinations array so that they work again. Bug: 875448 Change-Id: Id41219554d3a7f808b9097a268044540d6d6cf40 Reviewed-on: https://chromium-review.googlesource.com/1162266 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584274} [modify] https://crrev.com/e882388db428f59a12784e0d3dd77a698fab296f/chrome/browser/resources/print_preview/new/destination_list.js [modify] https://crrev.com/e882388db428f59a12784e0d3dd77a698fab296f/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Aug 30
Interactive UI tests were fixed by https://crrev.com/c/1187729, and browser tests were fixed by the revision in comment 3. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Aug 17