Quick source panel doesn't save changes to disk
Reported by
hakuro.l...@gmail.com,
Aug 17
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce the problem: 1. Open DevTools 2. Open any file available at your local workspace on the "Quick source" tab 3. Make any changes on it 4. Hit Ctrl + S What is the expected behavior? What went wrong? The changes are not saved. Did this work before? Yes Chrome version: 68.0.3440.106 Channel: stable OS Version: 10.0 Flash Version: It's been a while since this shortcut broke. Hitting Ctrl + S on the Sources panel works as expected, this only applies to the Quick source.
,
Aug 20
Tested the issue on Win-10 using chrome reported version #68.0.3440.106 and latest canary #70.0.3527.0. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Opened DevTools 2. Opened any file available at local workspace on the "Quick source" tab by pressing ctrl+p. 3. Made some changes. 4. Saved the file by hitting Ctrl + S. 5. Observed that on refreshing the page the file did not save. Note: The same behaviour is seen from M-60. reporter@ - Could you please check the attached screen cast and please let us know if it is the issue. Thanks...!!
,
Aug 22
Not quite. I attached a video showing exactly how to reproduce it. These are the steps I made: 1) Opened a locally hosted site and opened a SCSS file which is currently linked to a dev tools workspace 2) Edited the file on the Sources tab 3) Saved using Ctrl + S (which worked, the SASS preprocessor updated the CSS and chrome updated the site view) 4) Deleted the change, saved the file again 5) Made the same change, this time using the Quick source tab 6) Hit Ctrl + S (which didn't save the change, notice the asterisk on the file name) 7) Went to the Sources tab and hit Ctrl + S (which works and the changes I made at Quick source are saved) The same happens with any file type, not only .scss files.
,
Aug 22
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 17.10 using chrome reported version #68.0.3440.106 and latest canary #70.0.3530.0. Bisect Information: ===================== Good build: 66.0.3344.0 Bad Build : 66.0.3345.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/8ac10d7a7858c9816aef786b235c283c853852bf..ec38ac216979d1c996970cc45263a2aab12dde27 From the above change log suspecting below change Change-Id: I2e8810de25b146c0566ea5bf813117d0b2220c54 Reviewed-on: https://chromium-review.googlesource.com/676091 einbinder@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ba3abbde5c981ca60c0f773b279521df38496d commit 99ba3abbde5c981ca60c0f773b279521df38496d Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Oct 12 19:23:42 2018 DevTools: Restore shortcuts in Quick source The shortcuts were looking for the SourcesPanel, when only the SourcesView was present. Bug: 875434 Change-Id: I6095ccaab4d7ab0c35f98153031e7204f023a30e Reviewed-on: https://chromium-review.googlesource.com/c/1277988 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#599322} [modify] https://crrev.com/99ba3abbde5c981ca60c0f773b279521df38496d/third_party/blink/renderer/devtools/front_end/sources/module.json |
||||
►
Sign in to add a comment |
||||
Comment 1 by susan.boorgula@chromium.org
, Aug 19