New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875432 link

Starred by 1 user
Status: Duplicate
Owner:
khorimoto@chromium.org
Closed: Aug 17
Cc:
omrilio@chromium.org
█ jlklein@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
jdufault@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Lock screen settings auth dialog is Smart-Lock-specific

Project Member Reported by derat@chromium.org, Aug 17 
The authentication dialog at chrome://settings/lockScreen refers to Smart Lock now: "To set up Smart Lock, enter your password".

This screen is used to control all screen-lock-related settings, though. This confused me when I saw it, since I wasn't trying to enable Smart Lock.

I think the string should probably be changed to something like "To set up screen lock, enter your password".

The new string looks like it was added by https://chromium-review.googlesource.com/1112742 -- the string resource is called IDS_SETTINGS_PEOPLE_PASSWORD_PROMPT_ENTER_PASSWORD_LOCK, so it shouldn't be Smart-Lock-specific.

IDS_SETTINGS_PEOPLE_PASSWORD_PROMPT_ENTER_PASSWORD_LOGIN_LOCK may have the same problem.

(Should the string have a trailing period or colon as well?)
Screenshot 2018-08-17 at 13.36.27.png
856 KB View Download

Comment 1 by jdufault@chromium.org, Aug 17 

I think the string change for settings://lockScreen should be reverted. From https://chromium-review.googlesource.com/c/chromium/src/+/1179377, the password prompt dialog will be usable in multiple places, and I believe smart lock is moving to a separate settings section, so this new string can be used there.

Comment 2 by jdufault@chromium.org, Aug 17

Cc: hansberry@chromium.org

Comment 3 by hansberry@chromium.org, Aug 17

Cc: jhawkins@chromium.org jlklein@chromium.org
Which version of chrome was this on? I previously filed this bug and it should have been fixed: crbug.com/872982.

Comment 4 by hansberry@chromium.org, Aug 17

Mergedinto: 872982
Status: Duplicate (was: Assigned)
It looks like the fix for crbug.com/872982 only addressed IDS_SETTINGS_PEOPLE_PASSWORD_PROMPT_ENTER_PASSWORD_LOCK, not IDS_SETTINGS_PEOPLE_PASSWORD_PROMPT_ENTER_PASSWORD_LOGIN_LOCK. I've reopened the bug.
►

Sign in to add a comment