[Widget] Excess NOTREACHED logs when window is being dragged. |
||||
Issue descriptionThere is currently a NOTREACHED() when getting the HitTest while the window is resizing. This adds a lot of noise in the logs when the window is being dragged. This only happens when aspect ratio is set for a window. This behavior is expected to be unhandled here, hence the current default handling.
,
Oct 1
,
Oct 4
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2d916562540ef4c0ca3ee33b2ffecf70e1e29b commit 2a2d916562540ef4c0ca3ee33b2ffecf70e1e29b Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Oct 09 20:35:43 2018 Widget: only enforce aspect ratio when resizing. THis is fixing a NOTREACHED() error when running GetWindowResizeHitTest() as it expects the window to be resized, not dragged. Bug: 875382 Change-Id: I0cc3a8323427818a885d10c70852b0682fc5f865 Reviewed-on: https://chromium-review.googlesource.com/c/1262408 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#598067} [modify] https://crrev.com/2a2d916562540ef4c0ca3ee33b2ffecf70e1e29b/ash/wm/default_window_resizer_unittest.cc [modify] https://crrev.com/2a2d916562540ef4c0ca3ee33b2ffecf70e1e29b/ash/wm/window_resizer.cc
,
Oct 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by apaci...@chromium.org
, Oct 1