New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875381 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@chromium.org
Last visit > 30 days ago
Closed: Aug 22
Cc:
samans@chromium.org
█ fsam...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GetLatestInFlightSurface should not return null if fallback doesn't exist

Project Member Reported by akaba@chromium.org, Aug 17 
GetLatestInFlightSurface should return something older than primary in case fallback was not specified.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ebe5509cd8f1440c45772e827e26bb0a8117f7

commit b4ebe5509cd8f1440c45772e827e26bb0a8117f7
Author: akaba <akaba@google.com>
Date: Wed Aug 22 17:30:58 2018

GetLatestInFlightSurface should output something for non-existent fallbacks

GetLatestInFlightSurface should not return nullptr if fallback doesn't exist.
Instead it should try to search for active surfaces in primary's FrameSinkId.

Bug:  875381 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8940c374b7f52f728e4d88c88358aeb177dc8520
Reviewed-on: https://chromium-review.googlesource.com/1179989
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#585139}
[modify] https://crrev.com/b4ebe5509cd8f1440c45772e827e26bb0a8117f7/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/b4ebe5509cd8f1440c45772e827e26bb0a8117f7/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/b4ebe5509cd8f1440c45772e827e26bb0a8117f7/components/viz/service/surfaces/surface_manager.cc

Comment 2 by akaba@chromium.org, Aug 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment