New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875380 link

Starred by 2 users
Status: Fixed
Owner:
█ alexlau@chromium.org
Last visit > 30 days ago
Closed: Aug 28
Cc:
weifangsun@chromium.org
slangley@chromium.org
█ mcirimele@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Only display "Show all Play folders" for My files and subdirectories

Project Member Reported by mcirimele@chromium.org, Aug 17 
Chrome OS version: 70.0.3524.2

Currently we show "Show all Play folders" in the overflow menu for all roots. We should only show this action when the user is browsing a local root (My files or subdirectories).

Audit deck: https://docs.google.com/presentation/d/1Y26wN0H7_usgVjKUJZ1ZP72KiTtI1rlvpy-8XTMfdFE/edit#slide=id.g3286ee9e9b_0_71

Comment 1 by fukino@chromium.org, Aug 21

Owner: alexlau@chromium.org
Status: Assigned (was: Available)

Comment 2 by weifangsun@chromium.org, Aug 21

Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb751085f849b73779c07356d06226673d18a98

commit 9eb751085f849b73779c07356d06226673d18a98
Author: Alex Lau <alexlau@chromium.org>
Date: Fri Aug 24 06:32:01 2018

Only display "Show all Play folders" for My files and subdirectories.

Currently this is shown for all roots.

Bug:  875380 
Test: Tested on kevin.
Change-Id: Ied92804c5a3936d458b38e84daf973c5928b3534
Reviewed-on: https://chromium-review.googlesource.com/1186206
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Alex Lau <alexlau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585724}
[modify] https://crrev.com/9eb751085f849b73779c07356d06226673d18a98/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Comment 4 by sa...@chromium.org, Aug 24 

Issue 863208 has been merged into this issue.

Comment 5 by alexlau@chromium.org, Aug 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment