I can't review my teammates CL |
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce the problem: When I click on reply to a CL that I'm a reviewer this shows at the bottom: Code-Review You don't have permission to edit this label. Commit-Queue You don't have permission to edit this label. What is the expected behavior? What went wrong? I have merged my own changes, but can't review/+1 others Did this work before? N/A Chrome version: 68.0.3440.106 Channel: stable OS Version: Flash Version:
,
Sep 7
,
Oct 22
friendly ping. Both nooglers on my team have the same problem: davidqu, aaronhk. Is this expected? Are we missing something?
,
Oct 23
,
Oct 25
This is expected, though adding Andrii to triple confirm. I in fact have the same issue. I believe you need to be a committer to apply the CR+1 label. There is nothing stopping a non-committer from reviewing code and have substantive useful feedback, but they can't approve the code to be submitted. If a committer has +1'd your CL, you should be able to apply the CQ+2 label.
,
Oct 25
Which repo is this for? For chromium/src, V8, infra repos ajp@ is exactly right.
,
Oct 25
Ok. That makes more sense. Thank you so much. Sorry for the trouble. :) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fs...@chromium.org
, Aug 17Labels: -Pri-2 Pri-1
Status: Available (was: Unconfirmed)