New folder is only available when a file or folder is in focus |
||||||
Issue descriptionChrome OS version: 70.0.3524.2 Steps to reproduce: 1. Make sure Downloads is in focus (blue background) 2. Click the overflow menu (three dot) 3. Click a file so it is in focus (blue background), not selected (checkmark) 4. Click the overflow menu (three dot) Expected result: "New folder" is available for both cases. Observed result: "New folder" is only shown when a file or folder is in focus. Video: https://photos.app.goo.gl/dRcw5XRVUBcDgrFo8
,
Aug 20
,
Sep 24
,
Oct 4
,
Nov 19
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2eae8d526c73319b8451bc06d7a48db3fa98ba1 commit d2eae8d526c73319b8451bc06d7a48db3fa98ba1 Author: Sam McNally <sammc@chromium.org> Date: Tue Nov 20 02:15:58 2018 Make new folder visible in menus for all roots that aren't fake entries. Fix cr-menu to hide superfluous separators as claimed in its comment. Bug: 875356 Change-Id: Ib4178efe087649558fd49b32cf43d6eba9e0fff7 Reviewed-on: https://chromium-review.googlesource.com/c/1341446 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609562} [modify] https://crrev.com/d2eae8d526c73319b8451bc06d7a48db3fa98ba1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/d2eae8d526c73319b8451bc06d7a48db3fa98ba1/chrome/test/data/webui/menu_test.html [modify] https://crrev.com/d2eae8d526c73319b8451bc06d7a48db3fa98ba1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/d2eae8d526c73319b8451bc06d7a48db3fa98ba1/ui/file_manager/integration_tests/file_manager/gear_menu.js [modify] https://crrev.com/d2eae8d526c73319b8451bc06d7a48db3fa98ba1/ui/webui/resources/js/cr/ui/menu.js [delete] https://crrev.com/1727205925af4334a69ed14c8b5c8474267716c0/ui/webui/resources/js/cr/ui/menu_test.html
,
Nov 20
,
Nov 20
What change broke this, btw?
,
Nov 20
I don't know. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mcirimele@chromium.org
, Aug 17