GS Cache Error spamming autoserv logs |
|||
Issue description
Observed in staging test (test_push):
Error:
08/17 09:10:47.680 WARNI| gs_cache_client:0203| GS Cache Error: File 'autotest/test_suites/suite_to_control_file_map' isn't in response: {u'chameleon_hdmi_perbuild': [u'server/site_tests/display_SwitchMode/control', u'server/site_tests/display_LidCloseOpen/control.extended', u'server/site_tests/display_LidCloseOpen/control.mirrored', u'server/site_tests/display_HotPlugAtBoot/control.extended.port_typec', u'server/site_tests/display_Resolution/control.extended',
... followed by lots of lines listing the files found ...
[1] This is spammy. Instead, print the exact call made (along with the GSCache server used) so that it is trivial to reproduce the call.
[2] Is this expected?
,
Aug 17
,
Aug 17
This is definitely unexpected. According to design, the output format of `extract` is {'filename': "file content", ...}. But for this one, the output is just the file content.
Because the response is cached by nginx, so it always return the wrong thing.
However, after I clear the cache and re-request, it return the right thing.
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/94d7b877c2ebb8c277fedcdbfb8836f2771bca05 commit 94d7b877c2ebb8c277fedcdbfb8836f2771bca05 Author: Congbin Guo <guocb@chromium.org> Date: Wed Aug 29 18:15:26 2018 autotest: gs cache: truncate too long exception message The response of some gs cache may includes long list of file names. This is not readable when format it to an exception message. This change truncate the long message to reasonab length. Minor change: logging the call url/cmd to gs cache server. BUG= chromium:875349 TEST=Ran unit tests. Change-Id: Id212ae1b47172cd4a9f5ca206af05945380fbb86 Reviewed-on: https://chromium-review.googlesource.com/1194438 Commit-Ready: Congbin Guo <guocb@chromium.org> Tested-by: Congbin Guo <guocb@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/94d7b877c2ebb8c277fedcdbfb8836f2771bca05/client/common_lib/cros/gs_cache_client_unittest.py [modify] https://crrev.com/94d7b877c2ebb8c277fedcdbfb8836f2771bca05/client/common_lib/cros/gs_cache_client.py
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/62413d74b72599bab4f7e9026cd999a03a8163b5 commit 62413d74b72599bab4f7e9026cd999a03a8163b5 Author: Congbin Guo <guocb@chromium.org> Date: Tue Sep 11 07:41:00 2018 autotest: gs cache: fix of list_suite_control metrics This CL changes two things: 1: Distinguish the exceptions raised to help us to tell if the gs cache server is really in trouble. 2: Set scale to 0.001 to the timers of calls to both gs_cache server and devserver, so that we can have more precise results. BUG= chromium:875349 TEST=Ran unit tests. Change-Id: I7a6e7869bdb736fdd9fb806105d814db56ac11a6 Reviewed-on: https://chromium-review.googlesource.com/1214291 Commit-Ready: Congbin Guo <guocb@chromium.org> Tested-by: Congbin Guo <guocb@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/62413d74b72599bab4f7e9026cd999a03a8163b5/client/common_lib/cros/gs_cache_client.py
,
Sep 12
According to https://pcon.corp.google.com/p#chrome-infra/queryplayground?yAxisMin=0&yAxisMin2=0&oldHeatmap=false&query=CAEY9QOKAYABCm4ID3pqCmgyZgoZbW9uYXJjaC5hY3F1aXNpdGlvbnMuVGFzaxJJCkcvY2hyb21lL2luZnJhL2Nocm9tZW9zL2F1dG90ZXN0L2dzX2NhY2hlX2NsaWVudC9mYWxsYmFja190b19kZXZzZXJ2ZXJfMiCAmJq8BCoCIAEwgIyNngKSAR8KBggBGKCNBhIAGhFtZXRyaWM6ZXJyb3JfdHlwZWAA&names=Query%201&endtime=1536775811&legendtable=true&timePinTimeMillis=1536748492000 All error type is 'other' (which means the error is due to gs cache server not enabled), so this bug should be fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pprabhu@chromium.org
, Aug 17