New issue
Advanced search Search tips

Issue 875343 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Tab with invalid HTTPS gets entire URL struck through

Reported by andresan...@gmail.com, Aug 17

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3521.2 Safari/537.36

Steps to reproduce the problem:
1. Visit https://ssl-cert.org/
2. When the 'privacy error' page shows, minimise the window
3. Maximise the window

What is the expected behavior?
Only for 'https' to be struck through.

What went wrong?
'https' and the rest of the text in the omnibox is struck through (the whole URL).

Did this work before? N/A 

Chrome version: 70.0.3521.2  Channel: dev
OS Version: 10.0
Flash Version: 

 Issue #751801  shows that a similar issue was previously discovered on a build for the iOS platform last year. Although a different method was used to trigger it.
Hovering over the omnibox or changing tabs would correct it.
 
struckthruomniboxtxt.mkv
7.2 MB Download
Components: -UI UI>Browser>Omnibox>SecurityIndicators
Owner: carlosil@chromium.org
Status: Assigned (was: Unconfirmed)
Was able to reproduce in Windows for both Stable (68) and Canary (70), but not in Linux, will take this bug while I dig into it more.
Cc: carlosil@chromium.org
Components: Internals>Views
Owner: msw@chromium.org
This looks like a Views issue, since OmniboxView only sets the strikethrough in OmniboxViewViews::UpdateSchemeStyle (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?rcl=913f1641f753a2a10c0dfc3bbfc0ae345474ef3a&l=772), and that function doesn't seem to be called when the bug appears. Also the function doesn't seem to be called with the wrong range, as in that case the color would also propagate to the whole URL.

msw: Can you take a look? Feel free to reassign if this turns out not to be a views issue.


Cc: msw@chromium.org
Owner: pkasting@chromium.org
I'm not actively working on the omnibox. Peter, can you find an owner?
Owner: jdonnelly@chromium.org
->omnibox TL

Sign in to add a comment