New issue
Advanced search Search tips

Issue 875336 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 875278
Owner:
Closed: Aug 17
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RTCVideoDecoderAdapterTest.Decode crashing

Project Member Reported by apaci...@chromium.org, Aug 17

Issue description

Similar to https://bugs.chromium.org/p/chromium/issues/detail?id=875278

Test Crashed:
    RTCVideoDecoderAdapterTest.Decode (../../content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc:217)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe6c559df3b29872a364abc7935fcd06f183f41

commit dbe6c559df3b29872a364abc7935fcd06f183f41
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Aug 17 17:32:22 2018

Disable RTCVideoDecoderAdapterTest.Decode

It is flakily crashing.

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug:  875336 
Change-Id: Ia134612a0fc11edcdcac8a3c5420e7bd40dc39f3
Reviewed-on: https://chromium-review.googlesource.com/1180074
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584112}
[modify] https://crrev.com/dbe6c559df3b29872a364abc7935fcd06f183f41/content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc

Mergedinto: 875278
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e

commit 9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e
Author: Wez <wez@chromium.org>
Date: Sat Aug 18 03:29:18 2018

Replace MessageLoop with ScopedTaskEnvironment in RTCRtpSenderTest.

This test base instantiates a content::ChildProcess to provide the
expected environment for the code-under-test. ChildProcess expects to
either run in the context of ScopedTaskEnvironment, in tests, or to
need to initialize the TaskScheduler itself.

Add a ScopedTaskEnvironment to the test base, otherwise the ChildProcess
TaskScheduler will "leak" and break later tests.

Re-enables the RTCVideoDecoderAdapterTest tests, that had been
broken by this issue.

TBR=hbos

Bug:  875278 ,  875301 ,  875336 
Change-Id: I8a7ee1f42e62241d48720c41897bdcadbcd26bdf
Reviewed-on: https://chromium-review.googlesource.com/1180408
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584298}
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_rtp_receiver_unittest.cc
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc

Sign in to add a comment