New issue
Advanced search Search tips

Issue 875321 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.7% regression in blink_perf.layout at 583733:583798

Project Member Reported by tdres...@chromium.org, Aug 17

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=875321

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a10e52c4c12f5597eb218b29704ee88920b654d68dcc4b061a12fca94b7781ba


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf
Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17ac5eea640000

[CI] Cleanup paint invalidation flags by wangxianzhu@chromium.org
https://chromium.googlesource.com/chromium/src/+/8a53cc3a814bd1a1027118909458d4bf3936137c
254.9 → 285.4 (+30.52)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
 Issue 875325  has been merged into this issue.
Issue 875427 has been merged into this issue.
 Issue 875368  has been merged into this issue.
 Issue 875369  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db

commit dbd5663d08aa2881c3e3c2c76c83f7b3966d31db
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Aug 18 00:06:01 2018

Revert "[CI] Cleanup paint invalidation flags"

This reverts commit 8a53cc3a814bd1a1027118909458d4bf3936137c.

Reason for revert: Performance regressions  crbug.com/875321 .

BUG= 875321 

Original change's description:
> [CI] Cleanup paint invalidation flags
> 
> - Use separate flags HasDelayedFullPaintInvalidation and
>   SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using
>   paint invalidation reasons kSubtree and kDelayedFull to simplify logic
>   handling them.
> 
> - Other cleanup and simplications
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d
> Reviewed-on: https://chromium-review.googlesource.com/1123018
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583772}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6f12dd7fe621f88e5a0fe1b96637b2ecc813e78e
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1180305
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584248}
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/containing-block-position-change-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-pattern-update-2-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-pattern-update-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/animated-row-background-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-2-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background-expected.txt
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/editing/caret_display_item_client.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/html/forms/range_input_type.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_block.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_box.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_box_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_embedded_object.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_html_canvas.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_html_canvas.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_object_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_table.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_table_cell.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_table_cell.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/ng/ng_block_node.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/svg/layout_svg_resource_container.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/svg/layout_svg_resource_marker.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/layout/svg/layout_svg_viewport_container.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/page/validation_message_overlay_delegate.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/BUILD.gn
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/block_paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/block_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/box_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/box_paint_invalidator_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/box_painter.cc
[add] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/embedded_object_paint_invalidator.cc
[add] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/embedded_object_paint_invalidator.h
[add] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/html_canvas_paint_invalidator.cc
[add] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/html_canvas_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/object_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/table_cell_paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/table_cell_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/table_paint_invalidator.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/paint/table_paint_invalidator.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/platform/graphics/paint_invalidation_reason.cc
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/platform/graphics/paint_invalidation_reason.h
[modify] https://crrev.com/dbd5663d08aa2881c3e3c2c76c83f7b3966d31db/third_party/blink/renderer/platform/graphics/paint_invalidation_reason_test.cc

 Issue 875421  has been merged into this issue.
Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eddbaaba16eb49abf0d391495e9180819d54e11

commit 7eddbaaba16eb49abf0d391495e9180819d54e11
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Aug 20 22:03:34 2018

Reland "[CI] Cleanup paint invalidation flags"

This relands commit 8a53cc3a814bd1a1027118909458d4bf3936137c with
the following change compared to the original CL:

- SetShouldCheckForPaintInvalidationWithoutGeometryChange() no
  longer unconditionally calls GetFrameView()
  ->ScheduleVisualUpdateForPaintInvalidationIfNeeded()
  but SetShouldDoFullPaintInvalidationWithoutGeometryChange()
  does. This logic is the same as the current ToT before this CL,
  and the same as before the reverted CL. This fixes the
  performance issue that is caused by too frequent calls to
  ScheduleVisualUpdateForPaintInvalidationIfNeeded() from
  SetShouldCheckForPaintInvalidation().

Original change's description:
> Revert "[CI] Cleanup paint invalidation flags"
>
> This reverts commit 8a53cc3a814bd1a1027118909458d4bf3936137c.
>
> Reason for revert: Performance regressions  crbug.com/875321 .
>
> BUG= 875321 
>
> Original change's description:
> > [CI] Cleanup paint invalidation flags
> >
> > - Use separate flags HasDelayedFullPaintInvalidation and
> >   SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using
> >   paint invalidation reasons kSubtree and kDelayedFull to simplify logic
> >   handling them.
> >
> > - Other cleanup and simplications
> >
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d
> > Reviewed-on: https://chromium-review.googlesource.com/1123018
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583772}
>
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I6f12dd7fe621f88e5a0fe1b96637b2ecc813e78e
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1180305
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584248}

Change-Id: I22ff44656c7994e7814565330042e08832f30f91
Bug:  875321 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1180309
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584573}
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/containing-block-position-change-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-pattern-update-2-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/text-pattern-update-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/animated-row-background-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-2-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/paint/invalidation/svg/text-pattern-update-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/paint/invalidation/svg/tspan-pattern-update-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background-expected.txt
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/editing/caret_display_item_client.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/html/forms/range_input_type.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_block.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_box.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_box_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_embedded_content.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_embedded_object.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_html_canvas.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_html_canvas.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_object_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_table.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_table_cell.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_table_cell.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/ng/ng_block_node.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/svg/layout_svg_resource_container.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/svg/layout_svg_resource_marker.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/svg/layout_svg_transformable_container.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/layout/svg/layout_svg_viewport_container.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/page/validation_message_overlay_delegate.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/BUILD.gn
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/block_paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/block_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/box_paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/box_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/box_paint_invalidator_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/box_painter.cc
[delete] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/third_party/blink/renderer/core/paint/embedded_object_paint_invalidator.cc
[delete] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/third_party/blink/renderer/core/paint/embedded_object_paint_invalidator.h
[delete] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/third_party/blink/renderer/core/paint/html_canvas_paint_invalidator.cc
[delete] https://crrev.com/3fa3df5cdc0cfa96f7c46a1d837e3e1e8e16b2da/third_party/blink/renderer/core/paint/html_canvas_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/object_paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/object_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/table_cell_paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/table_cell_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/table_paint_invalidator.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/paint/table_paint_invalidator.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/platform/graphics/paint_invalidation_reason.cc
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/platform/graphics/paint_invalidation_reason.h
[modify] https://crrev.com/7eddbaaba16eb49abf0d391495e9180819d54e11/third_party/blink/renderer/platform/graphics/paint_invalidation_reason_test.cc

Sign in to add a comment