New issue
Advanced search Search tips

Issue 875301 link

Starred by 1 user
Status: Duplicate
Merged: issue 875278
Owner:
sande...@chromium.org
Closed: Aug 17
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RTCVideoDecoderAdapterTest.InitializationFailure being flaky

Project Member Reported by rayankans@chromium.org, Aug 17 
Similar to https://bugs.chromium.org/p/chromium/issues/detail?id=875278

This is caused by a TaskScheduler instance:

I  170.750s run_tests_on_device(03ad521ed008c551)  [ RUN      ] RTCVideoDecoderAdapterTest.InitializationFailure
I  170.750s run_tests_on_device(03ad521ed008c551)  [FATAL:scoped_task_environment.cc(122)] Check failed: !TaskScheduler::GetInstance(). 

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=RTCVideoDecoderAdapterTest.InitializationFailure
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5099431af93ebd511ae34b01ad5b3e9bb94f7a76

commit 5099431af93ebd511ae34b01ad5b3e9bb94f7a76
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Aug 17 16:38:54 2018

Disable RTCVideoDecoderAdapterTest.InitializationFailure

It's flaky and blocking try-bots on unrelated CLs.

TBR=sandersd@chromium.org
NOTRY=true (disabling a test)

Bug:  875301 
Change-Id: I8e09e1bf5d8a8f64457d49d7c5e8274719da2b32
Reviewed-on: https://chromium-review.googlesource.com/1179896
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584098}
[modify] https://crrev.com/5099431af93ebd511ae34b01ad5b3e9bb94f7a76/content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc

Comment 2 by apaci...@chromium.org, Aug 17

Mergedinto: 875278
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e

commit 9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e
Author: Wez <wez@chromium.org>
Date: Sat Aug 18 03:29:18 2018

Replace MessageLoop with ScopedTaskEnvironment in RTCRtpSenderTest.

This test base instantiates a content::ChildProcess to provide the
expected environment for the code-under-test. ChildProcess expects to
either run in the context of ScopedTaskEnvironment, in tests, or to
need to initialize the TaskScheduler itself.

Add a ScopedTaskEnvironment to the test base, otherwise the ChildProcess
TaskScheduler will "leak" and break later tests.

Re-enables the RTCVideoDecoderAdapterTest tests, that had been
broken by this issue.

TBR=hbos

Bug:  875278 ,  875301 ,  875336 
Change-Id: I8a7ee1f42e62241d48720c41897bdcadbcd26bdf
Reviewed-on: https://chromium-review.googlesource.com/1180408
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584298}
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_rtp_receiver_unittest.cc
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc
[modify] https://crrev.com/9eb10b3c39d3309dfe72a7c6439d5f7d20013a1e/content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc
►

Sign in to add a comment