New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875295 link

Starred by 1 user
Status: Assigned
Owner:
█ pgeorgi@chromium.org
Last visit 25 days ago
Cc:
dzigterman@chromium.org
drinkcat@chromium.org
█ pgeorgi@chromium.org
█ cheyuw@google.com
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

stackanalyzer EC build target broken

Project Member Reported by jettrink@chromium.org, Aug 17 
The subprocess.check_output call in stack_analyzer.py is return an OS error [0] that the file or directory isn't found, but when you run the command manually in the chroot, there isn't a problem.

Example command 
/opt/coreboot-sdk/bin/arm-eabi-objdump -t build/yorp/RW/ec.RW.elf


[0]: [Errno 2] No such file or directory

Comment 1 by jettrink@chromium.org, Aug 17

Cc: cheyuw@google.com drinkcat@chromium.org

Comment 2 by drinkcat@google.com, Aug 20

Cc: pgeorgi@chromium.org
What command _exactly_ is failing?

Maybe something do with with b/65441143? Does the revert in https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1177221 help?

Comment 3 by jettrink@chromium.org, Aug 22

Status: Closed (was: Untriaged)
Yes, it looks like the revert in Comment 2 did fix this.

Comment 4 by pgeorgi@chromium.org, Aug 22

Owner: pgeorgi@chromium.org
Status: Assigned (was: Closed)
That revert is temporary (and was unrelated to the stackanalyzer), so I'd still like to know what happened here or how to reproduce the issue, to prepare for the return of coreboot-sdk.

Comment 5 by jettrink@chromium.org, Aug 22 

You can replicate the issue by:
git checkout 36ca5f4f3
make BOARD=yorp
make BOARD=yorp analyzestack

And you will get:
Please specify SECTION=RO or RW. The default is RW.
Warning: Annotation file ./board/yorp/analyzestack.yaml does not exist.
Error: Failed to run objdump.


I added some debugging prints in stack_analyzer.py to determine what the failing command and OS error code were.

Comment 6 by jettrink@chromium.org, Aug 22 

Sorry the correct platform/ec commit hash is 7f3f8308a

Comment 7 by pgeorgi@chromium.org, Aug 22 

so, found the issue in 7f3f8308a:
extra/stack_analyzer/stack_analyzer.py --objdump " /opt/coreboot-sdk/bin/..."

Notice the extra space before /opt - Putting the set-option calls in core/*/build.mk into single lines fixes it. Will keep that in mind when reintroducing coreboot-sdk for all ECs.
►

Sign in to add a comment