The delegates are to be owned by platform-agnostic RenderLoop
The delegates are to be owned by platform-agnostic RenderLoop. The design can be found here go/chromevr-renderloop
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a6986f275c84748a05b0151d21e4afc7de5f8e9 commit 4a6986f275c84748a05b0151d21e4afc7de5f8e9 Author: Aldo Culquicondor <acondor@chromium.org> Date: Mon Aug 20 17:27:08 2018 VR: Simplify viewport setup for WebXR overlay UI Bug: 875291 Change-Id: Ib09533c0d81d6646084d8d4fc52978c7f5ae946a Reviewed-on: https://chromium-review.googlesource.com/1181170 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584481} [modify] https://crrev.com/4a6986f275c84748a05b0151d21e4afc7de5f8e9/chrome/browser/android/vr/vr_shell_gl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42 commit 5dc384bf80ec36d3ef5809ef60b44e3b5d744a42 Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Aug 22 23:42:36 2018 VR: Draw logic in RenderLoop The compositor updates the viewports and buffers accordingly per RenderLoop request. VrShellGl still inherits from RenderLoop, but it no longer accesses the Ui, but through a new interface suited for it. VrShellGl also implements the new SchedulerDelegate interface, which is in charge of making draw calls to the RenderLoop from different signals. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I68c724145cdf8c4d63e90856f59bd07994cd9f1b Reviewed-on: https://chromium-review.googlesource.com/1181949 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#585307} [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/android/vr/render_loop_factory.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/compositor_delegate.h [add] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/compositor_ui_interface.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/render_loop.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/render_loop.h [add] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/scheduler_delegate.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/test/gl_test_environment.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/test/gl_test_environment.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/testapp/gl_renderer.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/testapp/gl_renderer.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/ui.cc [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/ui.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/ui_interface.h [modify] https://crrev.com/5dc384bf80ec36d3ef5809ef60b44e3b5d744a42/chrome/browser/vr/ui_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c commit 764626c3e8e21e6e2cfe600ffe45cb355dc4c84c Author: Aldo Culquicondor <acondor@chromium.org> Date: Thu Aug 23 20:14:47 2018 VR: Make RenderLoop own the delegates VrShellGl no longer inherits from RenderLoop, instead it's owned by it. VrShellGl implements both SchedulerDelegate and CompositorDelegate. All communication to the delegates from VrShell go through the RenderLoop. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifb9def1ea748648e3eea2dac1c80b48d7da07e5c Reviewed-on: https://chromium-review.googlesource.com/1185380 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#585599} [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/gl_browser_interface.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/gvr_controller_delegate.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/gvr_controller_delegate.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/render_loop_factory.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/render_loop_factory.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/compositor_delegate.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/controller_delegate.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/controller_delegate_for_testing.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/controller_delegate_for_testing.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/render_loop.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/render_loop.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/scheduler_delegate.h [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/testapp/gl_renderer.cc [modify] https://crrev.com/764626c3e8e21e6e2cfe600ffe45cb355dc4c84c/chrome/browser/vr/testapp/gl_renderer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8985eb363ec13e3e846e45e7a6d3e83830b9521 commit b8985eb363ec13e3e846e45e7a6d3e83830b9521 Author: Aldo Culquicondor <acondor@chromium.org> Date: Thu Sep 06 22:27:44 2018 Split VrShellGl into a compositor and scheduler delegates The delegates communicate through 2 channels in the android implementation: 1. WebXrPresentationState, owned by the scheduler. 2. The public interface of VrShellGl. Ideally, this interface should remain very small to ensure the task separation. VrShellGl now only implements the CompositorDelegate, and it's soon to be renamed. RenderLoop now owns the delegates. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia30e62ed249b5fc0682b8f2b943eef615408daa3 Reviewed-on: https://chromium-review.googlesource.com/1191864 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#589342} [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/android_vsync_helper.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/android_vsync_helper.h [add] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/gvr_scheduler_delegate.cc [add] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/gvr_scheduler_delegate.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/render_loop_factory.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/render_loop_factory.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/web_xr_presentation_state.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/android/vr/web_xr_presentation_state.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/compositor_delegate.h [delete] https://crrev.com/8977b622447814880a74eea67e977b5436c3544c/chrome/browser/vr/compositor_ui_interface.h [add] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/fov_rectangle.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/render_loop.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/render_loop.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/scheduler_delegate.h [add] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/scheduler_render_loop_interface.h [add] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/scheduler_ui_interface.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/testapp/gl_renderer.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/testapp/gl_renderer.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/ui.cc [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/ui.h [modify] https://crrev.com/b8985eb363ec13e3e846e45e7a6d3e83830b9521/chrome/browser/vr/ui_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34610c1dc8f4716d2d088a766f4eaad54c7a8b02 commit 34610c1dc8f4716d2d088a766f4eaad54c7a8b02 Author: Aldo Culquicondor <acondor@chromium.org> Date: Fri Sep 07 21:03:13 2018 Rename RenderLoop to BrowserRenderer Rename CompositorDelegate to GraphicsDelegate and VrShellGl to GvrGraphicsDelegate. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iecb896daaa47fc3681ca642e4dac4a654536d1c5 Reviewed-on: https://chromium-review.googlesource.com/1208675 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#589633} [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/OWNERS [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/arcore_device/ar_image_transport.cc [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/browser_renderer_factory.cc [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/browser_renderer_factory.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/gl_browser_interface.h [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/gvr_graphics_delegate.cc [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/gvr_graphics_delegate.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/gvr_scheduler_delegate.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/gvr_scheduler_delegate.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/BUILD.gn [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/base_graphics_delegate.cc [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/base_graphics_delegate.h [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/browser_renderer.cc [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/browser_renderer.h [add] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/browser_renderer_browser_interface.h [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/graphics_delegate.h [delete] https://crrev.com/38715a153906cdfcf5b6c09765374c92cc821f9d/chrome/browser/vr/render_loop_browser_interface.h [rename] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/scheduler_browser_renderer_interface.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/scheduler_delegate.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/testapp/gl_renderer.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/testapp/gl_renderer.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/chrome/browser/vr/testapp/vr_testapp.cc [modify] https://crrev.com/34610c1dc8f4716d2d088a766f4eaad54c7a8b02/device/vr/android/gvr/gvr_gamepad_data_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a188d8cbe691379b4529fdf9e81be4b1dd847876 commit a188d8cbe691379b4529fdf9e81be4b1dd847876 Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Sep 11 20:46:16 2018 VR: Add a BaseSchedulerDelegate Extract platform independent code from the GvrSchedulerDelegate for reusability and testing. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iaa90b42ea7e81995c32344c9da083c96bdc55a71 Reviewed-on: https://chromium-review.googlesource.com/1195711 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#590454} [modify] https://crrev.com/a188d8cbe691379b4529fdf9e81be4b1dd847876/chrome/browser/android/vr/gvr_scheduler_delegate.cc [modify] https://crrev.com/a188d8cbe691379b4529fdf9e81be4b1dd847876/chrome/browser/android/vr/gvr_scheduler_delegate.h [modify] https://crrev.com/a188d8cbe691379b4529fdf9e81be4b1dd847876/chrome/browser/vr/BUILD.gn [add] https://crrev.com/a188d8cbe691379b4529fdf9e81be4b1dd847876/chrome/browser/vr/base_scheduler_delegate.cc [add] https://crrev.com/a188d8cbe691379b4529fdf9e81be4b1dd847876/chrome/browser/vr/base_scheduler_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b915d1ef42aaef71b372710559bbb4be504ea22b commit b915d1ef42aaef71b372710559bbb4be504ea22b Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Sep 11 23:10:35 2018 Move head pose acquisition to InputDelegate The ControllerDelegate was renamed to InputDelegate to reflect that it handles more than just the controller raw input. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7415806cf7ba52a7e49899843dcf93079333c8d3 Reviewed-on: https://chromium-review.googlesource.com/1213874 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#590522} [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/browser_renderer_factory.cc [rename] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/gvr_input_delegate.cc [rename] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/gvr_input_delegate.h [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/gvr_scheduler_delegate.cc [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/android/vr/gvr_scheduler_delegate.h [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/browser_renderer.cc [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/browser_renderer.h [add] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/frame_type.h [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/graphics_delegate.h [rename] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/input_delegate.h [rename] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/input_delegate_for_testing.cc [rename] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/input_delegate_for_testing.h [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/scheduler_browser_renderer_interface.h [modify] https://crrev.com/b915d1ef42aaef71b372710559bbb4be504ea22b/chrome/browser/vr/scheduler_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bede7f328e3ceac77315e0f6d3a2eb1b81bfd29f commit bede7f328e3ceac77315e0f6d3a2eb1b81bfd29f Author: Aldo Culquicondor <acondor@chromium.org> Date: Wed Sep 12 21:21:06 2018 VR: Restore metrics after refactoring The recent refactorings have changed the name of several traces. We reenable them now. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib4149c95c2b06d9613d4bfe65cd89e74772b76ab Reviewed-on: https://chromium-review.googlesource.com/1222267 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#590824} [modify] https://crrev.com/bede7f328e3ceac77315e0f6d3a2eb1b81bfd29f/chrome/browser/android/vr/gvr_graphics_delegate.cc [modify] https://crrev.com/bede7f328e3ceac77315e0f6d3a2eb1b81bfd29f/chrome/browser/android/vr/gvr_scheduler_delegate.cc [modify] https://crrev.com/bede7f328e3ceac77315e0f6d3a2eb1b81bfd29f/chrome/browser/vr/browser_renderer.cc
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/945f73d771b6efd8c638ded611d272c784492ef5 commit 945f73d771b6efd8c638ded611d272c784492ef5 Author: Aldo Culquicondor <acondor@google.com> Date: Mon Sep 17 19:56:58 2018 VR: Restore metrics after refactoring This needs to be submitted altogether with https://crrev.com/c/1222267 BUG= chromium:875291 Change-Id: Ie7830ab8a6f6f53bd69d74b8e7612f74d265ff13 Reviewed-on: https://chromium-review.googlesource.com/1222367 Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> [modify] https://crrev.com/945f73d771b6efd8c638ded611d272c784492ef5/tracing/tracing/metrics/vr/frame_cycle_duration_metric.html [modify] https://crrev.com/945f73d771b6efd8c638ded611d272c784492ef5/tracing/tracing/metrics/vr/frame_cycle_duration_metric_test.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbaf314ee867000d892a4a8787fabfdac1922e08 commit dbaf314ee867000d892a4a8787fabfdac1922e08 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Sep 17 21:35:11 2018 Roll src/third_party/catapult 7a20b16aead5..945f73d771b6 (2 commits) https://chromium.googlesource.com/catapult.git/+log/7a20b16aead5..945f73d771b6 git log 7a20b16aead5..945f73d771b6 --date=short --no-merges --format='%ad %ae %s' 2018-09-17 acondor@google.com VR: Restore metrics after refactoring 2018-09-17 wangge@google.com Add function to trigger the swarming job. Created with: gclient setdep -r src/third_party/catapult@945f73d771b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:875291 , chromium:863390 TBR=sullivan@chromium.org Change-Id: I259e89873e954f71bfedbf33ab734688e4182487 Reviewed-on: https://chromium-review.googlesource.com/1228820 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591828} [modify] https://crrev.com/dbaf314ee867000d892a4a8787fabfdac1922e08/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e commit 2df78d1c4d2a65f8b8f4b215c81e43686ba7135e Author: Aldo Culquicondor <acondor@chromium.org> Date: Tue Sep 18 19:50:47 2018 VR: Add CardboardControllerDelegate This moves the logic of handling the Cardboard trigger out of the scheduler. It also avoids unnecessary operations in Cardboard. Additionally, we submit vsync to the WebXR session after an input state has been obtained. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia8723a2fa50dac7ddcca4f6468dadd9c1836f6db Reviewed-on: https://chromium-review.googlesource.com/1216942 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#592157} [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/BUILD.gn [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/browser_renderer_factory.cc [add] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/cardboard_input_delegate.cc [add] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/cardboard_input_delegate.h [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/gvr_input_delegate.cc [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/gvr_input_delegate.h [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/gvr_scheduler_delegate.cc [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/android/vr/gvr_scheduler_delegate.h [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/browser_renderer.cc [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/browser_renderer_unittest.cc [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/input_delegate.h [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/input_delegate_for_testing.cc [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/input_delegate_for_testing.h [modify] https://crrev.com/2df78d1c4d2a65f8b8f4b215c81e43686ba7135e/chrome/browser/vr/scheduler_delegate.h
Comment 1 by acondor@chromium.org
, Aug 17