New issue
Advanced search Search tips

Issue 875289 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Make timed-out suite show correctly on buildbot

Project Member Reported by xixuan@chromium.org, Aug 17

Issue description

https://uberchromegw.corp.google.com/i/chromeos/builders/reef-paladin/builds/6565

We retry suite wait command to avoid buildbot silence check. However, it's retried with a new timeout everytime, which makes the total time cost much longer than what it needs, and aborted by buildbot finally.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c7dce5efbe5ff95222474c749dbe02df323abaf9

commit c7dce5efbe5ff95222474c749dbe02df323abaf9
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 20 04:11:04 2018

autotest: Fix passed_mins feature bug.

BUG= chromium:875289 
TEST=None

Change-Id: I8d163a1767c7a1adc170afca4fa161e707d95f27
Reviewed-on: https://chromium-review.googlesource.com/1180735
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/c7dce5efbe5ff95222474c749dbe02df323abaf9/venv/skylab_suite/cros_suite.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ded74c1409ac0c8ed9b856884f239b59f9e7382e

commit ded74c1409ac0c8ed9b856884f239b59f9e7382e
Author: Xixuan Wu <xixuan@chromium.org>
Date: Wed Aug 22 16:43:59 2018

cbuildbot: Add passed_mins for skylab suites.

Previously, re-running swarming skylab suite wait command didn't reset
the timeout_mins for the suite. So one wait command will wait for the
suite to run for 90 mins, and after that, another wait command is kicked
off to continue to wait for the same suite, until hitting the buildbot
deadline.

BUG= chromium:875289 
TEST=Ran tryjob.

Change-Id: Ic6585d166c95a16b606eaabb40639c567c948c9e
Reviewed-on: https://chromium-review.googlesource.com/1180733
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>

[modify] https://crrev.com/ded74c1409ac0c8ed9b856884f239b59f9e7382e/cbuildbot/swarming_lib.py
[modify] https://crrev.com/ded74c1409ac0c8ed9b856884f239b59f9e7382e/cbuildbot/commands.py
[modify] https://crrev.com/ded74c1409ac0c8ed9b856884f239b59f9e7382e/cbuildbot/commands_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment