Remove TCPC reset check from alert handler |
||||
Issue descriptionAfter https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1143710 was submitted, we should no longer need the register_mask_reset(port) check in the tcpci_tcpc_alert method. Confirm this and remove it (or conditional compile it out). This will make the TCPC service operation time much shorter as this is 2 16-bit register read operations.
,
Dec 19
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/5e776459e2d94bcf3ae64a31bef17bb4f9195b3c commit 5e776459e2d94bcf3ae64a31bef17bb4f9195b3c Author: Jett Rink <jettrink@chromium.org> Date: Wed Jan 02 21:09:36 2019 tcpc: remove reset check in alert handler If the image supports TCPC low power mode, then we already initialized the devices after exiting low power mode. No need to check again. BRANCH=none BUG= chromium:875274 TEST=On an octopus board, PS8751 and ANX3447 work with TCPC smoke test of plugging/unplugging Change-Id: I54e9038db87f9cf998431263df0cf8fa254bde83 Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1379705 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1392419 [modify] https://crrev.com/5e776459e2d94bcf3ae64a31bef17bb4f9195b3c/driver/tcpm/tcpci.c
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/11db391ca382797a11308f683056d6a068a2f5ba commit 11db391ca382797a11308f683056d6a068a2f5ba Author: Jett Rink <jettrink@chromium.org> Date: Fri Jan 11 23:14:36 2019 tcpc: remove reset check in alert handler If the image supports TCPC low power mode, then we already initialized the devices after exiting low power mode. No need to check again. BRANCH=none BUG= chromium:875274 TEST=On an octopus board, PS8751 and ANX3447 work with TCPC smoke test of plugging/unplugging Change-Id: I54e9038db87f9cf998431263df0cf8fa254bde83 Signed-off-by: Jett Rink <jettrink@chromium.org> Previous-Reviewed-on: https://chromium-review.googlesource.com/1379705 (cherry picked from commit 3bff5c44538221d5ae482e04f0cbb0f175a87ff7) Reviewed-on: https://chromium-review.googlesource.com/c/1405401 Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Edward Hill <ecgh@chromium.org> Tested-by: Edward Hill <ecgh@chromium.org> [modify] https://crrev.com/11db391ca382797a11308f683056d6a068a2f5ba/driver/tcpm/tcpci.c |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 19