New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875251 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 878994



Sign in to add a comment

Implement command line interface for flakiness dashboard

Project Member Reported by perezju@chromium.org, Aug 17

Issue description

We found this useful to quickly have a look at which stories are flaking on a particular builder.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4210b3d40b33bd15ae284dfd28c9b59bbbe34548

commit 4210b3d40b33bd15ae284dfd28c9b59bbbe34548
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Aug 21 16:43:35 2018

[tools/perf] Start creating flakiness_cli

This first version just adds an entry point for the script, and simple
api calls to test-results server to retrieve the json data.

Bug:  875251 
Change-Id: I14de8275e1e9ffe28935d5e172add60011ec5b62
Reviewed-on: https://chromium-review.googlesource.com/1179837
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584784}
[add] https://crrev.com/4210b3d40b33bd15ae284dfd28c9b59bbbe34548/tools/perf/flakiness_cli
[add] https://crrev.com/4210b3d40b33bd15ae284dfd28c9b59bbbe34548/tools/perf/test_results/__init__.py
[add] https://crrev.com/4210b3d40b33bd15ae284dfd28c9b59bbbe34548/tools/perf/test_results/api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2048d8697cc8b829e5f2038d2355673cbd7d11a6

commit 2048d8697cc8b829e5f2038d2355673cbd7d11a6
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Aug 22 14:05:10 2018

[flakiness_cli] Convert builders data to pandas.DataFrame

Add a function to conver the data returned by test-results server about
known masters, builders, and test_types into a DataFrame for more
convenient querying of the data on it.

Also add a corresponding unit test.

NOTRY=true

Bug:  875251 
Change-Id: Ifa03250669fe3b661f093ff0e1ca172db85fade6
Reviewed-on: https://chromium-review.googlesource.com/1179888
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585004}
[modify] https://crrev.com/2048d8697cc8b829e5f2038d2355673cbd7d11a6/tools/perf/flakiness_cli
[add] https://crrev.com/2048d8697cc8b829e5f2038d2355673cbd7d11a6/tools/perf/test_results/frames.py
[add] https://crrev.com/2048d8697cc8b829e5f2038d2355673cbd7d11a6/tools/perf/test_results/frames_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/936745d2d93502209027d9909734aae6353e8e21

commit 936745d2d93502209027d9909734aae6353e8e21
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Aug 23 17:04:21 2018

[flakiness_cli] Convert test results response into data frame.

Add a function to convert the response from a test results request
into a data frame for convenient access of the data.

Also add corresponding unit tests.

Bug:  875251 
Change-Id: I396a5c209e37a470ab305edbee82ccc407472766
Reviewed-on: https://chromium-review.googlesource.com/1185184
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585525}
[modify] https://crrev.com/936745d2d93502209027d9909734aae6353e8e21/tools/perf/flakiness_cli
[modify] https://crrev.com/936745d2d93502209027d9909734aae6353e8e21/tools/perf/test_results/frames.py
[modify] https://crrev.com/936745d2d93502209027d9909734aae6353e8e21/tools/perf/test_results/frames_unittest.py

Reminder to self, feature request: Add --clean-cache option.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0dd58a9102dd0a0896086ce577e37349d05dde

commit eb0dd58a9102dd0a0896086ce577e37349d05dde
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Aug 28 09:25:50 2018

[flakiness_cli] Keep cached copies from test result server responses

Prevent us from making too many calls to test results server by keeping
cached copies of the responses we get.

For this we implement a frames.GetWithCache which will store the
dataframes created from test result reponses, and reuse them for
a set amount of time.

Bug:  875251 
Change-Id: Ieb87ef4c0a52635287b634e2bd233d248fb878e2
Reviewed-on: https://chromium-review.googlesource.com/1188578
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586629}
[modify] https://crrev.com/eb0dd58a9102dd0a0896086ce577e37349d05dde/tools/perf/flakiness_cli
[add] https://crrev.com/eb0dd58a9102dd0a0896086ce577e37349d05dde/tools/perf/test_results/core.py
[modify] https://crrev.com/eb0dd58a9102dd0a0896086ce577e37349d05dde/tools/perf/test_results/frames.py
[modify] https://crrev.com/eb0dd58a9102dd0a0896086ce577e37349d05dde/tools/perf/test_results/frames_unittest.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/284fa18c918e10952e7f0edc9a6ab1b3ed2b6abc

commit 284fa18c918e10952e7f0edc9a6ab1b3ed2b6abc
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Aug 29 15:09:56 2018

[flakiness_cli] Add analysis function to filter out builders

Add a function that helps to easily filter out and pick a selection of
builders and test types from shell-style wildcard patterns in the
command line.

Bug:  875251 
Change-Id: I5cdae91f02cd2a69980972cc09dfbe319b31432d
Reviewed-on: https://chromium-review.googlesource.com/1188675
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587121}
[modify] https://crrev.com/284fa18c918e10952e7f0edc9a6ab1b3ed2b6abc/tools/perf/flakiness_cli
[add] https://crrev.com/284fa18c918e10952e7f0edc9a6ab1b3ed2b6abc/tools/perf/test_results/analysis.py
[add] https://crrev.com/284fa18c918e10952e7f0edc9a6ab1b3ed2b6abc/tools/perf/test_results/analysis_unittest.py

Blockedon: 878994
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f7d6a6f1c3c4833608d5820084c2d1486c7f6b

commit 48f7d6a6f1c3c4833608d5820084c2d1486c7f6b
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Sat Sep 15 01:40:28 2018

[flakiness_cli] Add function to aggregate over builds

This makes the tool pretty useful already to quickly find test sutes
and test cases failing over a set of bots.

The formula to compute flakiness may still need more tweaking.

Bug:  875251 
Change-Id: I8c86baf608b1dc6a6dbadfa690e76f369da03ecc
Reviewed-on: https://chromium-review.googlesource.com/1199482
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#591553}
[modify] https://crrev.com/48f7d6a6f1c3c4833608d5820084c2d1486c7f6b/tools/perf/flakiness_cli
[modify] https://crrev.com/48f7d6a6f1c3c4833608d5820084c2d1486c7f6b/tools/perf/test_results/analysis.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb751bfb2d47a722252459258e76ebeabfca3b7

commit 8bb751bfb2d47a722252459258e76ebeabfca3b7
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Oct 25 14:19:42 2018

[flakiness_cli] Fix bug reporting most recent build

The largest build number (max) is not necessarily the most recent (e.g.
the number might reset due to changes on the builder config), instead
report the most recent one as reported by the test_results api.

TBR=nednguyen@google.com

Bug:  875251 
Change-Id: I5792dd00130dca79528152d052f298f9764dc21d
Reviewed-on: https://chromium-review.googlesource.com/c/1299157
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602695}
[modify] https://crrev.com/8bb751bfb2d47a722252459258e76ebeabfca3b7/tools/perf/test_results/analysis.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 2

Status: Fixed (was: Started)
This is done.

Sign in to add a comment