wpt/infrastructure/testdriver/bless.html fails on site-per-process |
|||
Issue descriptionImporter is blocked because the new infrastructure/testdriver/bless.html consistently times out in site-per-process layout tests on Linux, but not in non-site-isolated layout tests on Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/166823 We currently don't support automatically creating baselines specifically for site-per-process, so if a test behaves differently on Linux between with and without site-per-process, the importer is blocked, which is not unusual. However, I'm filing this as P1 because I worry there might be some more fundamental issues here: our implementation of test_driver.click() might be broken or not play well with bless() somehow. bless.html also times out on Mac and Windows. Code: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testdriver-vendor.js?l=7&rcl=5d30f82392d19d6cae02ff2e2b944e3858dc468e The investigation work is high-priority as bless() is a useful test_driver API.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5b6d3294f77b41e2015fa5683c6588386adee1e commit d5b6d3294f77b41e2015fa5683c6588386adee1e Author: Robert Ma <robertma@chromium.org> Date: Fri Aug 17 19:11:31 2018 Adjust the expectation for bless.html Looks like the test is in fact flaky-timeout on all platforms. TBR=foolip No-Try: True Bug: 875249 Change-Id: I9e6a3c96afbf539c8c685ef079993c138826ea18 Reviewed-on: https://chromium-review.googlesource.com/1180248 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#584143} [modify] https://crrev.com/d5b6d3294f77b41e2015fa5683c6588386adee1e/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/d5b6d3294f77b41e2015fa5683c6588386adee1e/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 24
Found this P1 in triage. Tentatively assigning kyleju@ to investigate, as this is adjacent to testdriver/webdriver work. I don't believe this is super serious right now, but it's only a matter of time before there are tests affected by this.
,
Nov 6
Ping kyleju@chromium.org, from your friendly neighbourhood ecosystem infra rotation :-)
,
Nov 26
Unable to reproduce this bug on my linux machine. Ran this test target with 500 iterations and all test runs passed Test Command: python third_party/blink/tools/run_web_tests.py --verbose -t Default --iterations=500 external/wpt/infrastructure/testdriver/bless.html
,
Nov 26
Probably the test has begun to pass since this issue was filed and all that needs to be done is to remove the line from TestExpectations? (This is assuming you tested with site-per-process.)
,
Nov 26
yea I sent out a CL but realized I probably need to test on other platform (because I only tested on linux). Will follow up on this bug shortly
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6321c04bbc643063e9a0fdc2d3b0ce9b2966737d commit 6321c04bbc643063e9a0fdc2d3b0ce9b2966737d Author: kyle Ju <kyleju@chromium.org> Date: Tue Nov 27 21:04:44 2018 Adjust the expectation for bless.html Test bless.html on a local linux machine and all test runs passed. Thus remove bless.html from the TestExpectation file. Bug: 875249 Change-Id: Ic5de42921e496e199b3be79e9920e5366205e9ee Reviewed-on: https://chromium-review.googlesource.com/c/1351599 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#611315} [modify] https://crrev.com/6321c04bbc643063e9a0fdc2d3b0ce9b2966737d/third_party/blink/web_tests/TestExpectations
,
Nov 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 17