New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 768586
issue 876371
issue 877502
issue 878710
issue 878745



Sign in to add a comment

Add a CQ for Dawn

Project Member Reported by cwallez@chromium.org, Aug 17

Issue description

We don't want to lose test coverage when migrating Dawn from Github to Gerrit-On-Borg. Set up a CQ for it that builds it and runs unittests at first.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/1ed7242b50cd4c12f5943d5e8d6f621682616223

commit 1ed7242b50cd4c12f5943d5e8d6f621682616223
Author: Corentin Wallez <cwallez@google.com>
Date: Tue Aug 21 16:30:10 2018

Blockedon: 876371
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb636fd06e94d420212ad4379e8779eccae6d5e

commit 9fb636fd06e94d420212ad4379e8779eccae6d5e
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 22 16:24:51 2018

Roll src/third_party/depot_tools 85f5e7ccd1af..29361ca11fa3 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85f5e7ccd1af..29361ca11fa3


git log 85f5e7ccd1af..29361ca11fa3 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 cwallez@chromium.org Add standalone dawn gclient config
2018-08-21 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@29361ca11fa3

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:875245 
TBR=agable@chromium.org

Change-Id: I03a614427f950472893d317d70dd2c59944750e4
Reviewed-on: https://chromium-review.googlesource.com/1184763
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585041}
[modify] https://crrev.com/9fb636fd06e94d420212ad4379e8779eccae6d5e/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/20294d0ec9f33c119a279431b6a8c589cd20d50e

commit 20294d0ec9f33c119a279431b6a8c589cd20d50e
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Aug 23 12:30:57 2018

Add initial recipe for Dawn

It is heavily based on the ANGLE recipe.

Test expectations were generated using
  ./scripts/slave/recipes.py -O depot_tools=$HOME/dev/depot_tools test train

The local depot_tools modification had this CL applied:
  https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1183432

BUG= chromium:875245 

Change-Id: I77e51b0e48138894fb88af37c300106ae5a43491
Reviewed-on: https://chromium-review.googlesource.com/1183500
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.expected/linux.json
[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.expected/linux_gcc.json
[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.expected/win_rel_msvc_x86.json
[modify] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/README.recipes.md
[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.expected/win_clang.json
[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.py
[add] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/dawn.expected/win.json

Blockedon: 877502
Blockedon: 878710
Blockedon: 878745
Blockedon: 768586
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/1e591dca21c6bddc02b7576bf7a834d98c451d75

commit 1e591dca21c6bddc02b7576bf7a834d98c451d75
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Sep 06 15:48:03 2018

Add Dawn got_revision_mapping to glient config

BUG= 875245 

Change-Id: I50425aef624d00c1aa6fd7c18244fea128c15842
Reviewed-on: https://chromium-review.googlesource.com/1209643
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/1e591dca21c6bddc02b7576bf7a834d98c451d75/recipes/recipe_modules/gclient/config.py

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72bfab862a30c6ee32d0cad4e08f4bee90a170d

commit c72bfab862a30c6ee32d0cad4e08f4bee90a170d
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Sep 06 20:58:45 2018

Roll src/third_party/depot_tools 0f5a0b440989..b56a43a9064c (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0f5a0b440989..b56a43a9064c


git log 0f5a0b440989..b56a43a9064c --date=short --no-merges --format='%ad %ae %s'
2018-09-06 bratell@opera.com Read the git config only once when doing a git cl issue -r lookup
2018-09-06 cwallez@chromium.org Add Dawn got_revision_mapping to glient config


Created with:
  gclient setdep -r src/third_party/depot_tools@b56a43a9064c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:880734 , chromium:875245 
TBR=agable@chromium.org

Change-Id: I018ecfb1f6b0268afd18797281d67e5659877684
Reviewed-on: https://chromium-review.googlesource.com/1210446
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589294}
[modify] https://crrev.com/c72bfab862a30c6ee32d0cad4e08f4bee90a170d/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/a68660d0bb5de945345417078a4f9eb6d6678509

commit a68660d0bb5de945345417078a4f9eb6d6678509
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Sep 10 17:33:24 2018

gclient: add use_relative_hooks

When a recursive dependency has use_relative_paths it also makes sense
to have the hooks working directory by the dependency's directory.
Otherwise if a hook uses one of the relative dependencies it is impossible
to know which path prefix to use.

However we cannot change the behavior of hooks with use_relative_paths
because it would break existing projects that use_relative_paths but
hardcoded the prefix for hooks. Instead we add a second boolean,
use_relative_hooks that triggers the behavior.

Adds tests for the new behavior and a test for existing interactio
between hooks and recursedeps.

BUG= chromium:875245 

Change-Id: Ie4c526baa425ff887b3be54e0feca7c597ededec
Reviewed-on: https://chromium-review.googlesource.com/1213327
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/a68660d0bb5de945345417078a4f9eb6d6678509/testing_support/fake_repos.py
[modify] https://crrev.com/a68660d0bb5de945345417078a4f9eb6d6678509/gclient_eval.py
[modify] https://crrev.com/a68660d0bb5de945345417078a4f9eb6d6678509/gclient.py
[modify] https://crrev.com/a68660d0bb5de945345417078a4f9eb6d6678509/tests/gclient_test.py
[modify] https://crrev.com/a68660d0bb5de945345417078a4f9eb6d6678509/tests/gclient_smoketest.py

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a549c174ae565cc86e9e915183efb869882c31e2

commit a549c174ae565cc86e9e915183efb869882c31e2
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Sep 10 18:33:50 2018

Roll src/third_party/depot_tools 25c380cf9d2d..a68660d0bb5d (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25c380cf9d2d..a68660d0bb5d


git log 25c380cf9d2d..a68660d0bb5d --date=short --no-merges --format='%ad %ae %s'
2018-09-10 cwallez@chromium.org gclient: add use_relative_hooks


Created with:
  gclient setdep -r src/third_party/depot_tools@a68660d0bb5d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:875245 
TBR=agable@chromium.org

Change-Id: I25d022673caafa13a1f410b6c2a8ba5643d7766f
Reviewed-on: https://chromium-review.googlesource.com/1217144
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589992}
[modify] https://crrev.com/a549c174ae565cc86e9e915183efb869882c31e2/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment