sync_integration_tests USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex/1 failing on win/asan |
|||
Issue descriptione.g. here https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/1145 [ RUN ] USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex/1 [2348:7584:0817/025045.209:5954171:WARNING:loopback_server.cc(635)] Loopback sync persistent state file does not exist. [2348:8524:0817/025046.050:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [2348:7584:0817/025046.195:WARNING:chrome_browser_main_win.cc(641)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex/1 --no-sandbox --single_process --test-launcher-bot-mode --test-launcher-output="C:\b\s\w\itgokwf7\scoped_dir4320_3519\results4320_28340\test_results.xml" --test-launcher-summary-output="C:\b\s\w\iooqrxsh\output.json" --user-data-dir="C:\b\s\w\itgokwf7\scoped_dir4320_3519\d4320_10462" --disable-offline-auto-reload --disable-background-networking --sync-short-initial-retry-override --sync-short-nudge-delay-for-test --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=90 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=SyncUSSBookmarks,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release\gen" --restore-last-session about:blank [2348:8984:0817/025049.286:WARNING:sync_encryption_handler_impl.cc(968)] Nigori had empty encryption keybag. [2348:7584:0817/025049.291:ERROR:account_tracker.cc(266)] OnOAuthError [2348:7584:0817/025049.291:WARNING:account_tracker.cc(192)] Failed to get UserInfo for gaia_id_for_user@gmail.com [2348:8984:0817/025049.320:WARNING:sync_encryption_handler_impl.cc(968)] Nigori had empty encryption keybag. [2348:8984:0817/025049.393:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [2348:7584:0817/025049.597:ERROR:bookmark_model_type_processor.cc(358)] NOT IMPLEMENTED [2348:7584:0817/025049.671:ERROR:account_tracker.cc(266)] OnOAuthError [2348:7584:0817/025049.671:WARNING:account_tracker.cc(192)] Failed to get UserInfo for gaia_id_for_user@gmail.com [2348:10004:0817/025049.671:WARNING:sync_encryption_handler_impl.cc(968)] Nigori had empty encryption keybag. [2348:10004:0817/025049.671:WARNING:sync_encryption_handler_impl.cc(968)] Nigori had empty encryption keybag. [2348:10004:0817/025049.772:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [2348:7584:0817/025050.167:ERROR:bookmark_model_type_processor.cc(358)] NOT IMPLEMENTED ../../chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc(1432): error: Value of: ContainsDuplicateBookmarks(0) Actual: true Expected: false Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF6DD22F56A+214] testing::internal::AssertHelper::operator= [0x00007FF6DD22E4EB+265] testing::internal::CmpHelperOpFailure<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,char [10]> [0x00007FF6DD120317+320938] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF6E723BAA6+1650] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF6E745FA91+13101] ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF6E745C30B+555] content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF6DFB9CB55+385] content::StartupTaskRunner::RunAllTasksNow [0x00007FF6E0AD2042+284] content::BrowserMainLoop::CreateStartupTasks [0x00007FF6DFB978FD+1825] content::BrowserMainRunnerImpl::Initialize [0x00007FF6DFBA4D55+567] content::BrowserMain [0x00007FF6DFB90E2D+533] content::RunBrowserProcessMain [0x00007FF6E4461798+404] content::ContentMainRunnerImpl::Run [0x00007FF6E446358F+1827] service_manager::Main [0x00007FF6E5B21576+3878] content::ContentMain [0x00007FF6E44614E5+265] content::BrowserTestBase::SetUp [0x00007FF6E723AB97+4367] InProcessBrowserTest::SetUp [0x00007FF6E45270CA+1668] SyncTest::SetUp [0x00007FF6E4508AC2+1388] [2348:7584:0817/025053.499:ERROR:bookmark_model_type_processor.cc(315)] NOT IMPLEMENTED [2348:7584:0817/025053.499:ERROR:bookmark_model_type_processor.cc(315)] NOT IMPLEMENTED [2348:7584:0817/025054.519:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [2348:7584:0817/025054.519:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex/1, where GetParam() = true (9626 ms) cause: test newly-enabled in https://chromium.googlesource.com/chromium/src/+/f846b6512ae19dec1fd79a8e74029669507888df
,
Aug 18
Stack with line numbers, from https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/1150 : ../../chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc(1432): error: Value of: ContainsDuplicateBookmarks(0) Actual: true Expected: false Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF7BA1503DA+214] (C:\b\c\b\CrWinAsan\src\third_party\googletest\src\googletest\src\gtest.cc:825) testing::internal::AssertHelper::operator= [0x00007FF7BA14F35B+265] (C:\b\c\b\CrWinAsan\src\third_party\googletest\src\googletest\src\gtest.cc:401) `anonymous namespace'::TwoClientBookmarksSyncTestIncludingUssTests_MC_MergeDifferentBMModelsModeratelyComplex_Test::RunTestOnMainThread [0x00007FF7BA041103+10079] (C:\b\c\b\CrWinAsan\src\chrome\browser\sync\test\integration\two_client_bookmarks_sync_test.cc:1432) content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF7C419A2E6+1650] (C:\b\c\b\CrWinAsan\src\content\public\test\browser_test_base.cc:406) ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF7C43BEBB9+13101] (C:\b\c\b\CrWinAsan\src\chrome\browser\chrome_browser_main.cc:2000) ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF7C43BB433+555] (C:\b\c\b\CrWinAsan\src\chrome\browser\chrome_browser_main.cc:1384) content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF7BCAC2E5D+385] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_loop.cc:1024) content::StartupTaskRunner::RunAllTasksNow [0x00007FF7BD9FCEAE+284] (C:\b\c\b\CrWinAsan\src\content\browser\startup_task_runner.cc:43) content::BrowserMainLoop::CreateStartupTasks [0x00007FF7BCABDC05+1825] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_loop.cc:936) content::BrowserMainRunnerImpl::Initialize [0x00007FF7BCACB05D+567] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_runner_impl.cc:141) content::BrowserMain [0x00007FF7BCAB7135+533] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main.cc:43) content::RunBrowserProcessMain [0x00007FF7C13AC620+404] (C:\b\c\b\CrWinAsan\src\content\app\content_main_runner_impl.cc:536) content::ContentMainRunnerImpl::Run [0x00007FF7C13AE417+1827] (C:\b\c\b\CrWinAsan\src\content\app\content_main_runner_impl.cc:888) service_manager::Main [0x00007FF7C2A79B0A+3878] (C:\b\c\b\CrWinAsan\src\services\service_manager\embedder\main.cc:472) content::ContentMain [0x00007FF7C13AC36D+265] (C:\b\c\b\CrWinAsan\src\content\app\content_main.cc:19) content::BrowserTestBase::SetUp [0x00007FF7C41993D7+4367] (C:\b\c\b\CrWinAsan\src\content\public\test\browser_test_base.cc:322) InProcessBrowserTest::SetUp [0x00007FF7C1471F42+1668] (C:\b\c\b\CrWinAsan\src\chrome\test\base\in_process_browser_test.cc:251) SyncTest::SetUp [0x00007FF7C1453942+1388] (C:\b\c\b\CrWinAsan\src\chrome\browser\sync\test\integration\sync_test.cc:262) [5600:7888:0818/050509.386:ERROR:bookmark_model_type_processor.cc(315)] NOT IMPLEMENTED [5600:7888:0818/050509.527:ERROR:bookmark_model_type_processor.cc(315)] NOT IMPLEMENTED [5600:7888:0818/050510.834:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [5600:7888:0818/050510.834:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex/1, where GetParam() = true (16799 ms)
,
Aug 18
,
Aug 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eeee6d2fe0448b3683a623849052eb7e48769b0 commit 3eeee6d2fe0448b3683a623849052eb7e48769b0 Author: Nico Weber <thakis@chromium.org> Date: Sun Aug 19 17:55:40 2018 Run sync_integration_tests on win/asan bots. One recently re-enabled test fails, so to be able run the whole suite, also: Revert "Reland "[Sync:USS] Enable more two client bookmarks integration tests"" This reverts commit f846b6512ae19dec1fd79a8e74029669507888df. Reason for revert: One of the tests fails on win/asan, https://crbug.com/875239 Original change's description: > Reland "[Sync:USS] Enable more two client bookmarks integration tests" > > This is a reland of 94d8037bec11ca694d18d0dadc4ff7a5669f3274 > > Original change's description: > > [Sync:USS] Enable more two client bookmarks integration tests > > > > This CL enables more integration tests for bookmarks to run > > against USS archiecture. > > > > > > Bug: 516866 > > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f > > Reviewed-on: https://chromium-review.googlesource.com/1158691 > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580434} > > Bug: 516866 > Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316 > Reviewed-on: https://chromium-review.googlesource.com/1161882 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580499} TBR=mastiz@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 516866, 875239 Change-Id: I85e49dbfd4e6c2aba675854efb42c4a87d3243b8 Reviewed-on: https://chromium-review.googlesource.com/1180661 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584338} [modify] https://crrev.com/3eeee6d2fe0448b3683a623849052eb7e48769b0/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc [modify] https://crrev.com/3eeee6d2fe0448b3683a623849052eb7e48769b0/testing/buildbot/chromium.memory.json [modify] https://crrev.com/3eeee6d2fe0448b3683a623849052eb7e48769b0/testing/buildbot/test_suite_exceptions.pyl
,
Aug 19
mamir: The test is still flaky on win/asan, but the test also no longer runs. I can either mark this fixed, or you can use the bug for re-enabling the test and we can remove the blocking relationship to issue 869973 -- up to you.
,
Aug 23
mamir: ping?
,
Aug 27
I was on vacation and just arrived to work today. (sorry for not making that in my Chromium account) Keeping this issue should be fine. Could you just give me any hint what's special about the "win/asan" bot that could make that test fails only on it?
,
Aug 27
It runs tests under Address Sanitizer on Windows. My guess is that the test depends on some things happening in the right order without it having explicit waits and the timing happens to be different enough for things to fail only on win/asan.
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7e067b8ce3f4dce0d431ae8da19b4d4135e7ae8 commit e7e067b8ce3f4dce0d431ae8da19b4d4135e7ae8 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Sep 03 15:10:48 2018 [Sync::USS] Enable MC_MergeDifferentBMModelsModeratelyComplex test This CL enables MC_MergeDifferentBMModelsModeratelyComplex bookmarks integration test to run on USS architecture. Bug: 516866, 875239 Change-Id: Ia4c416adb118ce4ed751c4feebc70d9ae6b8b97d Reviewed-on: https://chromium-review.googlesource.com/1193943 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#588395} [modify] https://crrev.com/e7e067b8ce3f4dce0d431ae8da19b4d4135e7ae8/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc
,
Sep 17
sync-triage ping: mamir@, any updates?
,
Sep 17
Yes, I am giving it sometime to bake, so far it's silent and the test isn't flaky. If it stays silent for 2 more weeks, I would mark it as fixed.
,
Sep 26
Things look good so far, but I will wait for one more week before marking as fixed!
,
Oct 8
mamir@: triage ping. Can this be closed?
,
Oct 8
Yes, I think it's safe to mark it as fixed now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Aug 17