Full specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZRT3KyGvNYc6/files/MCEGxH4Xyp10GcTPe49gBVxzwMSJbxAVNpw

Deleted: Spacing.png 68.9 KB

	Spacing.png 68.9 KB View Download

LGTM, thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f513f6a8e6773cf2153b24338a0586ea47ab964a

commit f513f6a8e6773cf2153b24338a0586ea47ab964a
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Aug 21 14:22:48 2018

Introduce a spacing of 24px in the password generation drop-down.

Bug:  875237 
Change-Id: Id3ea73365dd50c9bc4d2d13659d37b03bc26c180
Reviewed-on: https://chromium-review.googlesource.com/1183430
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584732}
[modify] https://crrev.com/f513f6a8e6773cf2153b24338a0586ea47ab964a/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
[modify] https://crrev.com/f513f6a8e6773cf2153b24338a0586ea47ab964a/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc

I'd like to merge r584732 to M69. That fix is a pure UI change that fixes the password generation drop-down appearance for verbose languages. The risk is 0.

This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge for r584732 to M69 branch 3497 based on comment #5. Pls merge now so we can pick it up for tomorrow's beta release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e9b23959d6297ff9135c8a205a79b0bf1827ffb

commit 5e9b23959d6297ff9135c8a205a79b0bf1827ffb
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Aug 22 15:11:46 2018

Introduce a spacing of 24px in the password generation drop-down.

TBR=vasilii@chromium.org

(cherry picked from commit f513f6a8e6773cf2153b24338a0586ea47ab964a)

Bug:  875237 
Change-Id: Id3ea73365dd50c9bc4d2d13659d37b03bc26c180
Reviewed-on: https://chromium-review.googlesource.com/1183430
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584732}
Reviewed-on: https://chromium-review.googlesource.com/1185183
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#765}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5e9b23959d6297ff9135c8a205a79b0bf1827ffb/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
[modify] https://crrev.com/5e9b23959d6297ff9135c8a205a79b0bf1827ffb/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc

Tried testing the issue on build without fix chrome version #69.0.3497.42 using Windows 10 by following below steps.

Steps:
=====
1.Launched chrome.
2.Changed chrome language to German by navigating to chrome://settings.
3.Navigated to facebook.com and saved a username and password.
4.Logged out from the account.
5.Tried logging using another account when clicked on password textbox, unable to see "use suggested password and actual password string" in suggestions.

Attached screenshot for reference.
vasilii@ : Could you please review the attached screenshot and help us in verifying the fix .Requesting a sample file/URL which reproduces the issue, so that it would be really helpful in verifying the fix.

Thanks.!

Deleted: 875237.png 172 KB

	875237.png 172 KB View Download

You should test password generation. Focus the 'new password' field on facebook. You should not have other accounts saved. Otherwise, You'll need to click "Use suggested passwords".

Verified the fix on Chrome version 69.0.3497.57 and below are the steps followed :


Steps followed :
1. Launched chrome.
2. Changed chrome language to German by navigating to chrome://settings.
3. Sign-in to Chrome to get password generation enabled.
4. Visit https://account.ubisoft.com/en-GB/login
https://www.macmillanlearning.com/Catalog/Login and focus on password field.


Observed behavior:
Please refer image on right in attached screenshot.

Deleted: 875237.png 330 KB

	875237.png 330 KB View Download