New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875224 link

Starred by 6 users
Status: Assigned
Owner:
mgalonsky@chromium.org
Cc:
mgalonsky@chromium.org
█ mkwst@chromium.org
dominickn@chromium.org
maxwalker@chromium.org
emilyschechter@chromium.org
msramek@chromium.org
█ raymes@chromium.org
patricia...@chromium.org
█ sc00335...@techmahindra.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Visualize content settings that can't take effect

Project Member Reported by msramek@chromium.org, Aug 17 
Some content settings can't ever take effect, for example because they were set for an HTTP domain for a content type that only supports HTTPS (e.g. geolocation).

Others can't take effect temporarily, due to being overriden by a higher priority source. (e.g. user < extension < policy)

Visualize this in chrome://settings/content.

Comment 1 by msramek@chromium.org, Aug 17

Cc: emilyschechter@chromium.org sc00335...@techmahindra.com patricia...@chromium.org dominickn@chromium.org raymes@chromium.org
 Issue 798361  has been merged into this issue.

Comment 2 by raymes@chromium.org, Aug 20 

If the setting will never have any effect I guess we shouldn't let the user enter it at all?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2027f0a91ac0128f9a61c472ca7e518898a8729

commit f2027f0a91ac0128f9a61c472ca7e518898a8729
Author: Melissa Galonsky <mgalonsky@chromium.org>
Date: Fri Nov 16 02:48:44 2018

Prevent the user from creating content settings that can't take effect.

Fixes crbug/875224, by preventing users from creating content_settings
that can never take effect.

Bug: 875224
Change-Id: I1d7f0c7b504cd26ce929490de345e3591f0e2861
Reviewed-on: https://chromium-review.googlesource.com/c/1277925
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608640}
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/app/settings_strings.grdp
[add] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/app/settings_strings_grdp/IDS_SETTINGS_NOT_VALID_WEB_ADDRESS_FOR_CONTENT_TYPE.png.sha1
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/content_settings_info.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/content_settings_info.h
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/content_settings_registry.h
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/f2027f0a91ac0128f9a61c472ca7e518898a8729/components/content_settings/core/browser/host_content_settings_map.h
►

Sign in to add a comment