New issue
Advanced search Search tips

Issue 875223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 869973



Sign in to add a comment

cc_unittests LayerTreeHostBlendingPixelTest failing on win/asan after switching to swiftshader

Project Member Reported by thakis@chromium.org, Aug 17

Issue description

failures:
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersColorMatrixAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskAA_GL_TextureRect
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassColorMatrix_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrix_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMask_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMask_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMask_GL_TextureRect
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskColorMatrix_GL_TextureRect
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithBackgroundFilter
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShaders_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPass_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersWithMaskAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithRoot_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassColorMatrixAA_GL
LayerTreeHostBlendingPixelTest.BlendingWithRenderPassShadersColorMatrix_GL
LayerTreeHostBlendingPixelTest.BlendingWithTransparent_GL


Example stack:

[ RUN      ] LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrix_GL
../../cc/test/layer_tree_test.cc(1019): error: Failed
Test timed out
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF69225BB14+214]
	testing::internal::AssertHelper::operator= [0x00007FF69225AA95+265]
	cc::LayerTreeTest::RunTest [0x00007FF69274BCD0+5744]
	cc::LayerTreePixelTest::RunPixelTest [0x00007FF69273F422+306]
	cc::LayerTreeHostPixelResourceTest::RunPixelResourceTest [0x00007FF692738AA9+345]
	testing::PrintToString<viz::FrameSinkId> [0x00007FF691189747+300775]
[  FAILED  ] LayerTreeHostBlendingPixelTest.BlendingWithRenderPassWithMaskColorMatrix_GL (35845 ms)

Looks like this started here https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/1071 and is likely caused by https://chromium-review.googlesource.com/1127419
 
Blocking: 869973
Also happens with pinned clang, so not a clang/tot issue: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan/9
It should just be a matter of adjusting the ASAN timeout for now, like here:
https://chromium-review.googlesource.com/c/chromium/src/+/1127419/10/cc/test/layer_tree_test.cc#632

I'm on vacation until Sept. 27th, but anyone can increase that number to make the tests pass.
(Sorry, link in comment 1 should have been https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan/11)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e1f36cd64dbbcf8439308cba4563702364543b

commit 09e1f36cd64dbbcf8439308cba4563702364543b
Author: Nico Weber <thakis@chromium.org>
Date: Sat Aug 18 12:07:39 2018

Increase timeout for LayerTreeTests under asan and run cc_unittests on win/asan bot.

LayerTreeHostBlendingPixelTest.BlendingWith* still timeout on win/asan after
the switch to swiftshader, so bump up the timeout even more.

Bug:  875223 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I30eb5e3717ed7c5f55a478b8e2e1323c8e59d974
Reviewed-on: https://chromium-review.googlesource.com/1180282
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584313}
[modify] https://crrev.com/09e1f36cd64dbbcf8439308cba4563702364543b/cc/test/layer_tree_test.cc
[modify] https://crrev.com/09e1f36cd64dbbcf8439308cba4563702364543b/cc/test/layer_tree_test.h
[modify] https://crrev.com/09e1f36cd64dbbcf8439308cba4563702364543b/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/09e1f36cd64dbbcf8439308cba4563702364543b/testing/buildbot/test_suite_exceptions.pyl

Cc: sugoi@chromium.org enne@chromium.org
Owner: thakis@chromium.org
Status: Fixed (was: Assigned)
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1008

Bot is happy.

enne has https://chromium-review.googlesource.com/c/chromium/src/+/1180570 out for review to make these tests faster again.

Sign in to add a comment