New issue
Advanced search Search tips

Issue 875201 link

Starred by 1 user
Status: Started
Owner:
na...@chromium.org
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support access to active fetches

Project Member Reported by na...@chromium.org, Aug 17 
Currently, there is no access to data for background fetches that're active. Only once the fetch is complete does its request-response pairs start showing up in results from match() and matchAll().

This bug tracks the work to allow request-response pairs of fetches where at least one request has been processed, to also show up in these results. This will enable scenarios like playing a podcast or a video when 10 of 1000 files comprising the download have finished downloading.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964eeb18a31ef22897364f1f029782e595a8d9bd

commit 964eeb18a31ef22897364f1f029782e595a8d9bd
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Oct 18 15:12:41 2018

[BackgroundFetch] Remove BackgroundFetchSettledFetch idl.

BackgroundFetchSettledFetch isn't exposed to JavaScript so we can remove this.

Bug: 875201
Change-Id: Ic306b0f64897a7d7c1fbd61f64b6c635620d7bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1288357
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600763}
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/backgroundfetch-origin-trial-interfaces-serviceworker-disabled.js
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/backgroundfetch-origin-trial-interfaces-serviceworker-enabled.php
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/blink/renderer/modules/background_fetch/BUILD.gn
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[delete] https://crrev.com/aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.cc
[delete] https://crrev.com/aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.h
[delete] https://crrev.com/aa193def16e7e93cb6bcfee6a3adf0bf57a9ff08/third_party/blink/renderer/modules/background_fetch/background_fetch_settled_fetch.idl
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc
[modify] https://crrev.com/964eeb18a31ef22897364f1f029782e595a8d9bd/third_party/blink/renderer/modules/modules_idl_files.gni

Comment 2 by na...@chromium.org, Nov 12

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e

commit dc348bc897b0ccb123a4d63c7cdb6d0547a6729e
Author: Mugdha Lakhani <nator@chromium.org>
Date: Tue Nov 13 09:52:40 2018

[Background Fetch] Add feature flag for access to

active background fetches.
This allows iterative implementation of this feature.

Bug: 875201
Change-Id: Ia349eb55e682cf22825b53559c8e1f603d189501
Reviewed-on: https://chromium-review.googlesource.com/c/1331397
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607537}
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/content/child/runtime_features.cc
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/content/public/common/content_features.cc
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/content/public/common/content_features.h
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/dc348bc897b0ccb123a4d63c7cdb6d0547a6729e/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 4 by na...@chromium.org, Nov 14

Owner: na...@chromium.org
Status: Started (was: Available)

Comment 5 by na...@chromium.org, Nov 14

Summary: Support access to active fetches (was: Support match() and matchAll() for active fetches)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0ca639a1300af6815c1e66eaa30372ab99c3a47

commit a0ca639a1300af6815c1e66eaa30372ab99c3a47
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Nov 22 14:39:55 2018

Add a list of BackgroundFetchRecord objects to BackgroundFetchRegistration.

When we allow access to active background fetches, BackgroundFetchRecords for
the fetch can be accessed from multiple places. It simplifies matters if
we return the same record for a request whenever it's accessed.

This CL adds a (private) list of BackgroundFetchRecords to the
BackgroundFetchRegistration object, and updates it every time match and
matchAll() are called.

The second change introduced here is to not immediately resolve
responseReady() if the fetch is active and a response for the request
isn't yet available. Once the fetch has completed, or there's a response
available for the request, we resolve pending promises. We also make sure to
return the same promise (resolved or unresolved) for a given record,
every time responseReady is called.

For a more detailed discussion, see the following doc:
https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing

Bug: 875201

Change-Id: I8cb386efd19086c0993ad2be2fb2691ad90597ec
Reviewed-on: https://chromium-review.googlesource.com/c/1336151
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610410}
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/blink/renderer/modules/background_fetch/background_fetch_record.h
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/a0ca639a1300af6815c1e66eaa30372ab99c3a47/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7ec36200027fc04b357b82e91236997bd92a16

commit 3f7ec36200027fc04b357b82e91236997bd92a16
Author: Mugdha Lakhani <nator@chromium.org>
Date: Fri Nov 23 17:36:08 2018

[Background Fetch] Build ResponseReadyProperty in c'tor of BackgroundFetchRecord.

Move the creation of ResponseReadyProperty to the contructor of
BackgroundFetchRecord.
This helps us simplify responseReady(). We can simply return the promise of the
created ResponseReadyProperty every time it's called.

Bug: 875201
Change-Id: Idfb97864ebbe57b770cad76d215f08177eda8175
Reviewed-on: https://chromium-review.googlesource.com/c/1349712
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610642}
[modify] https://crrev.com/3f7ec36200027fc04b357b82e91236997bd92a16/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/288c97fe8cfcaf76261b5adaf6ca45b0adccab5b

commit 288c97fe8cfcaf76261b5adaf6ca45b0adccab5b
Author: Mugdha Lakhani <nator@chromium.org>
Date: Mon Nov 26 12:03:23 2018

[Background Fetch] Stop storing response as a class member.

BackgroundFetchRecord is currently storing a Response as a private class
member. This change makes it a local variable that can be passed in by
SetResponseAndUpdateState() to resolve the ResponseReadyProperty with it.

Keeping the response in a private member is unnecessary, since
ResponseReadyProperty stores it as a class member anyway.

Bug: 875201
Change-Id: I1d186ed26b2835df535b320c02cd73662daaa7cd
Reviewed-on: https://chromium-review.googlesource.com/c/1349651
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610821}
[modify] https://crrev.com/288c97fe8cfcaf76261b5adaf6ca45b0adccab5b/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc
[modify] https://crrev.com/288c97fe8cfcaf76261b5adaf6ca45b0adccab5b/third_party/blink/renderer/modules/background_fetch/background_fetch_record.h
[modify] https://crrev.com/288c97fe8cfcaf76261b5adaf6ca45b0adccab5b/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b1cca92cd20df271685faeef8400c4e848761d9

commit 8b1cca92cd20df271685faeef8400c4e848761d9
Author: Mugdha Lakhani <nator@chromium.org>
Date: Mon Dec 03 14:35:30 2018

[Background Fetch] Remove records_ from BackgroundFetchRegistration.

This had been introduced to simplify access to active fetches, but has
the following issues:
1. It makes match() and matchAll() inconsistent with Cache API's match()
and matchAll(), which return new independently-consumable response(s) every
time they're called.
2. It breaks retries for responses, when downloading from a server that
doesn't support resuming of downloads.

For details, see
https://docs.google.com/document/d/1CrbWrnnshhyp_SfiAeuODpnQX36GK3Bsi19rXQGez6Q/edit?usp=sharing

The CL also updates the WPT test accordingly.

Bug: 875201
Change-Id: I2c33717cbee36f0d707e814506c0bae9b5a4f31f
Reviewed-on: https://chromium-review.googlesource.com/c/1355121
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613079}
[modify] https://crrev.com/8b1cca92cd20df271685faeef8400c4e848761d9/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/8b1cca92cd20df271685faeef8400c4e848761d9/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
[modify] https://crrev.com/8b1cca92cd20df271685faeef8400c4e848761d9/third_party/blink/web_tests/external/wpt/background-fetch/fetch.https.window.js
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb565f42a20512a113bbc7ae6a613e82c566232

commit 9eb565f42a20512a113bbc7ae6a613e82c566232
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Dec 20 11:49:30 2018

[Background Fetch] Update record upon request completion.

This CL adds the logic to update all BackgroundFetchRecords
corresponding to a request, once it completes.

This is the next step towards supporting access to active fetches.

Bug: 875201
Change-Id: Iea15d495d2320285cb780fd5764a06f0b14e13f3
Reviewed-on: https://chromium-review.googlesource.com/c/1359029
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618173}
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_data_manager_observer.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_registration_notifier.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_registration_notifier.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_scheduler.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_scheduler.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/browser/background_fetch/storage/mark_request_complete_task.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/public/mojom/background_fetch/background_fetch.mojom
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/core/fetch/request.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/core/fetch/request.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/modules/background_fetch/background_fetch_record.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
[modify] https://crrev.com/9eb565f42a20512a113bbc7ae6a613e82c566232/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd756f96a8e696f64d9819014f3bb4dca541110

commit dbd756f96a8e696f64d9819014f3bb4dca541110
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Dec 20 12:02:39 2018

[Background Fetch] Optimize NotifyRequestCompleted.

BackgroundFetchRegistrationNotifier was notifying the
BackgroundFetchRegistration object in the renderer process of a request
being completed everytime any request for this registration would
complete.

Now, it only does so if the registration object is actually waiting for
updates on this request. This enables us to only send the data across
the mojo pipe when it's needed.

Bug: 875201
Change-Id: If1f4025af190ec79437a209dc4a79d91a480cb67
Reviewed-on: https://chromium-review.googlesource.com/c/1371895
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618179}
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_registration_notifier.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_registration_notifier.h
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/third_party/blink/renderer/modules/background_fetch/background_fetch_record.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/dbd756f96a8e696f64d9819014f3bb4dca541110/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39e8dbb932a7a337f59047aa48203cae80bad7b

commit c39e8dbb932a7a337f59047aa48203cae80bad7b
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Dec 20 15:37:16 2018

[Background Fetch] Support access to active fetches.

This bug removes the check from renderer that prevents
this access, and updates idl files accordingly.

It also adds a WPT test to check that incomplete fetches
provide access to downloaded content for requests that
have completed.

Bug: 875201
Change-Id: Iffb477496a7c593ba8a5f9de1dbb21c6ae90f6f6
Reviewed-on: https://chromium-review.googlesource.com/c/1367725
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618219}
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/renderer/modules/background_fetch/background_fetch_record.idl
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/external/wpt/background-fetch/fetch.https.window-expected.txt
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/external/wpt/background-fetch/fetch.https.window.js
[delete] https://crrev.com/7eae7e7cbdc73a802048566702531860feb60635/third_party/blink/web_tests/external/wpt/background-fetch/idlharness.https.any-expected.txt
[delete] https://crrev.com/7eae7e7cbdc73a802048566702531860feb60635/third_party/blink/web_tests/external/wpt/background-fetch/idlharness.https.any.sharedworker-expected.txt
[delete] https://crrev.com/7eae7e7cbdc73a802048566702531860feb60635/third_party/blink/web_tests/external/wpt/background-fetch/idlharness.https.any.worker-expected.txt
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/http/tests/origin_trials/webexposed/backgroundfetch-origin-trial-interfaces.html
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/http/tests/origin_trials/webexposed/resources/backgroundfetch-origin-trial-interfaces-serviceworker-enabled.php
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c39e8dbb932a7a337f59047aa48203cae80bad7b/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcdeff208a039d148ae12170a4acd37fb38e9498

commit fcdeff208a039d148ae12170a4acd37fb38e9498
Author: Mugdha Lakhani <nator@chromium.org>
Date: Fri Jan 04 12:54:10 2019

[BackgroundFetch] Remove flag for active fetches.

Access to active fetches is currently behind a feature flag.
This CL takes that out, along with all logic around it.

Bug: 875201
Change-Id: I0bf0ca8ec3eae7ddc5206b639e6a10897476838a
Reviewed-on: https://chromium-review.googlesource.com/c/1388647
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619927}
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/content/browser/background_fetch/background_fetch_registration_notifier.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/content/child/runtime_features.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/content/public/common/content_features.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/content/public/common/content_features.h
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/fcdeff208a039d148ae12170a4acd37fb38e9498/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c05f6193977e11ea67db092235510f5af2d79f2

commit 3c05f6193977e11ea67db092235510f5af2d79f2
Author: Mugdha Lakhani <nator@chromium.org>
Date: Mon Jan 07 12:55:39 2019

[Background Fetch] Add UMA for Active Fetches.

Bug: 875201
Change-Id: Ida344b7043139edc06484498ffb87f32121cb1fb
Reviewed-on: https://chromium-review.googlesource.com/c/1388162
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620301}
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/content/browser/background_fetch/background_fetch_registration_notifier.cc
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/content/browser/background_fetch/background_fetch_registration_notifier.h
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/content/browser/background_fetch/background_fetch_scheduler.cc
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3c05f6193977e11ea67db092235510f5af2d79f2/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment