Issue 875167 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	█ yysung@chromium.org Last visit > 30 days ago
Cc:	█ yhong@chromium.org chromeos-factory-eng@google.com
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Feature

factory: Verify component test improvement

Project Member Reported by yysung@chromium.org, Aug 17

Issue description

This bug aims to track the progress of the ApproxMatchFunction and the improvement of the verify component test.

The verify component can verify the number and the status of peripheral components now.
We should add a new feature that can find the closest hardware for the probe rules that don't match any hardware.

we can implement the work by the following steps.
1. Implement the ApproxMatchFunction
2. Improve the verify component test.

This bug aims to track the progress of the ApproxMatchFunction and the improvement of the verify component test.

The verify component can verify the number and the status of peripheral components now.
We should add a new feature to probe framework that can find the closest hardware that don't match any rule in the probe statement.

we can implement the work by the following steps.
1. Implement the ApproxMatchFunction in the probe framework.
2. Improve the verify component test.

This bug aims to track the progress of the ApproxMatchFunction and the improvement of the verify component test.

The verify component can verify the number and the status of peripheral components now.
We should add a new function to probe framework that can find the closest hardware that don't match any rule in the probe statement.

we can implement the work by the following steps.
1. Implement the ApproxMatchFunction in the probe framework.
2. Improve the verify component test by showing the results from the below function.

This bug aims to track the progress of the ApproxMatchFunction and the improvement of the verify component test.

The verify component can verify the number and the status of peripheral components now.
We should add a new function to probe framework that can find the closest hardware that don't match any rule in the probe statement.

we can implement the work by the following steps.
1. Implement the ApproxMatchFunction in the probe framework.
2. Improve the verify component test by showing the results from the ApproxMatchFunction.

Comment 1 Deleted

Comment 2 by yysung@chromium.org, Aug 22

Description: Show this description

Comment 3 by yysung@chromium.org, Aug 22

Description: Show this description

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7

commit 02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7
Author: Yuan-Yao Sung <yysung@google.com>
Date: Thu Aug 30 16:53:05 2018

probe: Add function ApproxMatchFunction

- Add options "--approx-match" and "--mismatch-num" to the command
  "probe probe" to find the closest hardware.
- Implement the function ApproxMatchFunction.
- Change the return of MatchFunction from [{},...] to [{'values':
  {}}...].

BUG=chromium:875167
TEST=make test

Change-Id: I266b320c0d8a5cf76d58961bf612d30c5aef4996
Reviewed-on: https://chromium-review.googlesource.com/1179517
Commit-Ready: Yuan-Yao Sung <yysung@google.com>
Tested-by: Yuan-Yao Sung <yysung@google.com>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/common_unittest.py
[add] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/functions/approx_match.py
[modify] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/probe_cmdline.py
[modify] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/common.py
[modify] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/functions/match.py
[add] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/functions/approx_match_unittest.py
[modify] https://crrev.com/02acc2ec7d6fd8c860c8a4556caa2899cb36f7f7/py/probe/probe_utils.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1deff1326587d7f9e810dd22867ba4c6909c8ae5

commit 1deff1326587d7f9e810dd22867ba4c6909c8ae5
Author: Yuan-Yao Sung <yysung@google.com>
Date: Mon Sep 03 09:20:52 2018

pytest: Add approx match to verify component test

- Show the closest hardwares when the number of components from probed
  results and from device data are mismatched.

BUG=chromium:875167
Test=manually run on device

Change-Id: I8239e0f37be2695ee5bb440a635d58c1ac66b9ed
Reviewed-on: https://chromium-review.googlesource.com/1183054
Commit-Ready: Yuan-Yao Sung <yysung@google.com>
Tested-by: Yuan-Yao Sung <yysung@google.com>
Reviewed-by: Cheng-Han Yang <chenghan@chromium.org>

[modify] https://crrev.com/1deff1326587d7f9e810dd22867ba4c6909c8ae5/py/test/pytests/verify_component_static/verify_component.js
[modify] https://crrev.com/1deff1326587d7f9e810dd22867ba4c6909c8ae5/py/test/pytests/verify_component.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a42412acb068e67867da8629e85f55ccf7cc647a

commit a42412acb068e67867da8629e85f55ccf7cc647a
Author: Yuan-Yao Sung <yysung@google.com>
Date: Mon Sep 03 12:53:27 2018

Rename probe option to --max-mismatch

- Rename `probe probe` option --mismatch-num to
  --max-mismatch

BUG=chromium:875167
Test=make test

Change-Id: I5e039404bf8d2cc8b77dc71b7c3e91d1072fb55b
Reviewed-on: https://chromium-review.googlesource.com/1201683
Commit-Ready: Yuan-Yao Sung <yysung@google.com>
Tested-by: Yuan-Yao Sung <yysung@google.com>
Reviewed-by: Cheng-Han Yang <chenghan@chromium.org>

[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/common_unittest.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/functions/approx_match.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/probe_cmdline.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/common.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/test/pytests/verify_component.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/functions/approx_match_unittest.py
[modify] https://crrev.com/a42412acb068e67867da8629e85f55ccf7cc647a/py/probe/probe_utils.py

Comment 7 by hungte@chromium.org, Sep 7

Status: Started (was: Untriaged)

►

Issue 875167 link

Issue metadata

factory: Verify component test improvement

Issue description

Comment 1 Deleted

Comment 2 by yysung@chromium.org, Aug 22

Comment 2 Deleted

Comment 3 by yysung@chromium.org, Aug 22

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Aug 30

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 3

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Sep 3

Comment 6 Deleted

Comment 7 by hungte@chromium.org, Sep 7

Comment 7 Deleted

Sign in to add a comment