Now we have response type attached to the response, we should use IsCORSSameOrigin / IsCORSCrossOrigin whenever possible, and remove ad-hoc origin checks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93c097996e3b1679a21742e73bcc95f6a4f49a63 commit 93c097996e3b1679a21742e73bcc95f6a4f49a63 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Mon Aug 20 05:50:41 2018 Do not create Script if an error occurred As a preparation for https://chromium-review.googlesource.com/1179488, this CL stops creating ClassicScript when ErrorOccurred() is true. Instead of setting |error_occurred| bool, this CL makes PendingScript::GetSource() return nullptr if an error occurred. This is consistent with the spec: - GetSource() corresponds to "the script's script". - GetSource() == nullptr (previously |error_occurred| == true) corresponds to "the script's script is null". Bug: 875153, 686281 Change-Id: I08d891ce2207894b4a8f8a2d1171f9912c79b8ce Reviewed-on: https://chromium-review.googlesource.com/1179557 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#584371} [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/classic_pending_script.cc [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/classic_pending_script.h [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/module_pending_script.cc [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/module_pending_script.h [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/pending_script.cc [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/pending_script.h [modify] https://crrev.com/93c097996e3b1679a21742e73bcc95f6a4f49a63/third_party/blink/renderer/core/script/script_runner_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d commit ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Aug 30 09:16:04 2018 Remove ad-hoc CORS logic from TextTrackLoader As specified in [1], it should use "same-origin" request mode rather than having ad-hoc CORS logic in TextTrackLoader. Now a response from service worker with type "cors" is rejected. The new behavior is actually more spec compliant (and matching with Firfox), so fix the corresponding web platform test. 1: https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model Bug: 875153 Change-Id: Ib39ed9684528d734c9ca3d40eb8f6890c77af986 Reviewed-on: https://chromium-review.googlesource.com/1195446 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#587492} [modify] https://crrev.com/ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/webvtt-cross-origin.https.html [modify] https://crrev.com/ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d/third_party/WebKit/LayoutTests/http/tests/security/text-track-crossorigin-expected.txt [modify] https://crrev.com/ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d/third_party/blink/renderer/core/loader/text_track_loader.cc [modify] https://crrev.com/ce27d86a29e98a2aaf25bcd41c6d98c11b82e84d/third_party/blink/renderer/core/loader/text_track_loader.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/137f0c56dd29331b4d7eca6d8cd34f700e9156f6 commit 137f0c56dd29331b4d7eca6d8cd34f700e9156f6 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Sep 04 02:10:51 2018 Inherit ScriptOriginOptions in eval() In general, whether an error thrown from a script will be muted is passed as (part of) ScriptOriginOptions when the script is compiled. Currently, when eval is called, that information is not given, and it uses the default options (IsSharedCrossOrigin = false, IsOpaque = false). Give it the options for the script in which eval is called. Bug: chromium:875153 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I4b5b872b4a8c2b8e503d457f199d85892a4c817c Reviewed-on: https://chromium-review.googlesource.com/1188052 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#55596} [modify] https://crrev.com/137f0c56dd29331b4d7eca6d8cd34f700e9156f6/src/compiler.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c4bffcd56d2fe3111c9937b359ce01e4e02c875e commit c4bffcd56d2fe3111c9937b359ce01e4e02c875e Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Sep 06 07:12:20 2018 Use ScriptOriginOptions with IsSharedCrossOrigin set for empty script Currently, neither IsSharedCrossOrigin nor IsOpaque is set for an empty script. Hence an exception thrown from it (e.g., an exception thrown from native promise implementation) is treated as an error with blink::kNotSharableCrossOrigin. On the other hand, as the script is empty, there is no meaningful URL attached, which means the ExecutionContext's URL is used as the script's name in blink::SourceLocation::FromMessage. In other words, it works virtually as same as blink::kSharableCrossOrigin corresponding to ScriptOriginOptions with IsSharedCrossOrigin set and IsOpaque unset. With this CL, a ScriptOriginOptions with IsSharedCrossOrigin is set and IsOpaque is not set is attached to the empty script, as a preliminary step to deprecate kNotSharableCrossOrigin. Bug: chromium:875153, chromium:876248 Change-Id: I39279a43994337329b8bd9d28b6ca29f0ac30d9c Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201689 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#55673} [modify] https://crrev.com/c4bffcd56d2fe3111c9937b359ce01e4e02c875e/src/heap/setup-heap-internal.cc [modify] https://crrev.com/c4bffcd56d2fe3111c9937b359ce01e4e02c875e/test/cctest/test-api.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81ea97ec7c453e734033d5bc52f305d978de7b32 commit 81ea97ec7c453e734033d5bc52f305d978de7b32 Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Sep 13 04:21:22 2018 Stop using kNotSharableCrossOrigin in CalculateAccessControlStatus As part of the effort to deprecate kNotSharableCrossOrigin, stop using it in ScriptResource::CalculateAccessControlStatus. Whether we should mute script errors is already calculated in the CORS module, so we don't need to recompute it in ExecutionContext::ShouldSanitizeScriptError. Bug: 875153 Change-Id: I23ed5dfb682463461777566f1a1edaa5a1b4cf94 Reviewed-on: https://chromium-review.googlesource.com/1179488 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#590922} [modify] https://crrev.com/81ea97ec7c453e734033d5bc52f305d978de7b32/third_party/blink/renderer/core/loader/resource/script_resource.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf6b914412eed0830c6c3e14e601565cdd471989 commit bf6b914412eed0830c6c3e14e601565cdd471989 Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Sep 13 10:07:16 2018 Remove AccessControlStatus default parameters This is a preliminary step to deprecate kNotSharableCrossOrigin. Bug: 875153 Change-Id: I23e0b41586634976de639080d5917b55225819fa Reviewed-on: https://chromium-review.googlesource.com/1179490 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#590964} [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/script_controller.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/script_controller.h [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/script_module_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/frame/dom_timer_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/frame/pausable_script_executor.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/resize_observer/resize_observer_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/script/classic_script.cc [modify] https://crrev.com/bf6b914412eed0830c6c3e14e601565cdd471989/third_party/blink/renderer/core/xml/document_xml_tree_viewer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e1adea27345a84adeea82cd31a3a6e04295761b commit 3e1adea27345a84adeea82cd31a3a6e04295761b Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Sep 14 01:41:51 2018 Pass AccessControlStatus to WorkerOrWorkletScriptController::Evaluate As part of the effort to deprecate kNotSharableCrossOrigin, stop using it in WorkerOrWorkletScriptController::Evaluate. There are three users: - worker toplevel scripts - importScripts - ScheduledAction Workers are origin-bound, so we can use kSharableCrossOrigin (the name is misleading, I will rename it, after all the refactoring is done). importScripts() always use "no-cors" mode, so we can calculate the AccessControlStatus by using SecurityOrigin::CanReadContent. I don't want to place the ad-hoc logic, but plumbing it to response type is hard because of LoadScriptFromInstalledScriptsManager. For ScheduledAction, I gave up removing kNotSharableCrossOrigin this time, as it seems consistent with Execute(LocalFrame*). I will remove the occurrence in a subsequent CL. Bug: 875153 Change-Id: I0d3c65e5fc152caed0265e7868e45ea9882ce487 Reviewed-on: https://chromium-review.googlesource.com/1180638 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#591255} [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.h [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/dedicated_worker_test.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/worker_thread.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/worker_thread.h [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/core/workers/worker_thread_test_helper.h [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/modules/csspaint/paint_worklet_test.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc [modify] https://crrev.com/3e1adea27345a84adeea82cd31a3a6e04295761b/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ac0e6963b0a8aad33e246ade2006017aefd8f2 commit 75ac0e6963b0a8aad33e246ade2006017aefd8f2 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Sep 28 05:04:17 2018 Remove kNotSharableCrossOrigin As we now have CORS-cross-origin, we don't need to rely on kNotSharableCrossOrigin for scripts coming from network. This CL completely removes kNotSharableCrossOrigin by migrating occurences to either kSharableCrossOrigin or kOpaqueResource. Bug: 875153 Change-Id: I12d12e9d67ca3329fe8b5e1dd7b74798f4817729 Reviewed-on: https://chromium-review.googlesource.com/1179509 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#594986} [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/WebKit/LayoutTests/http/tests/security/sandbox-iframe-blocks-top-navigation-to-javascript.html [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/script_controller.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/script_module_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/v8_lazy_event_listener.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/frame/dom_timer_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/frame/pausable_script_executor.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/inspector/inspector_page_agent.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/resize_observer/resize_observer_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/core/xml/document_xml_tree_viewer.cc [modify] https://crrev.com/75ac0e6963b0a8aad33e246ade2006017aefd8f2/third_party/blink/renderer/platform/loader/fetch/access_control_status.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9cbaa7a40e2b2723cfc2f266c42f4980038a949 commit a9cbaa7a40e2b2723cfc2f266c42f4980038a949 Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Oct 10 08:35:22 2018 Simplify "WouldTaintOrigin" concept in media/blink Currently WebMediaPlayer has three predicates: - DidGetOpaqueResponseFromServiceWorker - HasSingleSecurityOrigin - DidPassCORSAccessCheck . These are used to determine whether the response body is available for scripts. They are known to be confusing, and actually MediaElementAudioSourceHandler::WouldTaintOrigin misuses them. This CL merges the three predicates to one, WouldTaintOrigin, to remove the confusion. Now the "response type" concept is available and we don't need a custom CORS check, so this CL removes BaseAudioContext::WouldTaintOrigin. This CL also renames URLData::has_opaque_data_ and its (direct and indirect) data accessors to match the spec. Bug: 849942 , 875153 Change-Id: I6acf50169d7445c4ff614e80ac606f79ee577d2a Reviewed-on: https://chromium-review.googlesource.com/c/1238098 Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#598258} [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/content/renderer/media/stream/webmediaplayer_ms.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/content/renderer/media/stream/webmediaplayer_ms.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/multibuffer_data_source.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/multibuffer_data_source.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/url_index.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/url_index.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/media/blink/webmediaplayer_impl.h [add] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-audio-tainting.https.html [delete] https://crrev.com/50436d878b2e92de4231fda47328a8a4e884ecc3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https-expected.txt [delete] https://crrev.com/50436d878b2e92de4231fda47328a8a4e884ecc3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https-expected.txt [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/public/platform/web_media_player.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/core/html/media/html_media_element.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/core/html/media/html_media_element.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/modules/webaudio/base_audio_context.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/modules/webaudio/base_audio_context.h [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc [modify] https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949/third_party/blink/renderer/platform/testing/empty_web_media_player.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de22dbaeaf10c1a6dad0eac474c4aa779193c96a commit de22dbaeaf10c1a6dad0eac474c4aa779193c96a Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Oct 15 08:44:33 2018 Remove SecurityOrigin param from HTMLMediaElement::IsMediaCORSSameOrigin It's now not used. Bug: 875153 Change-Id: Ia7d42f503617563c1d4e82c9eaa0c67aae36baa1 Reviewed-on: https://chromium-review.googlesource.com/c/1275487 Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#599590} [modify] https://crrev.com/de22dbaeaf10c1a6dad0eac474c4aa779193c96a/third_party/blink/renderer/core/html/media/html_media_element.cc [modify] https://crrev.com/de22dbaeaf10c1a6dad0eac474c4aa779193c96a/third_party/blink/renderer/core/html/media/html_media_element.h [modify] https://crrev.com/de22dbaeaf10c1a6dad0eac474c4aa779193c96a/third_party/blink/renderer/core/html/media/html_video_element.cc [modify] https://crrev.com/de22dbaeaf10c1a6dad0eac474c4aa779193c96a/third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.cc [modify] https://crrev.com/de22dbaeaf10c1a6dad0eac474c4aa779193c96a/third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4166fbc689f76789b4eaf4ada8e45936eb69177 commit a4166fbc689f76789b4eaf4ada8e45936eb69177 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Nov 02 08:36:21 2018 Remove AccessControlStatus from module script path As CORS is enforced, there is no need to use AccessControlStatus. Bug: 875153 Change-Id: I2fb14abf9bd23e3b6d4743c6e1fef4c4d30a34b1 Reviewed-on: https://chromium-review.googlesource.com/c/1304278 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <domfarolino@gmail.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604867} [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/bindings/core/v8/script_module.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/bindings/core/v8/script_module.h [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/bindings/core/v8/script_module_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/bindings/core/v8/v8_script_runner.h [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/layout/custom/layout_worklet_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/installed_service_worker_module_script_fetcher.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/module_script_creation_params.h [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/module_map_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/module_script.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/module_script.h [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/script_loader.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/core/script/script_module_resolver_impl_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc [modify] https://crrev.com/a4166fbc689f76789b4eaf4ada8e45936eb69177/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a51ada56d9a8599d4dd1a097110456e4b375fdd2 commit a51ada56d9a8599d4dd1a097110456e4b375fdd2 Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Nov 12 03:28:18 2018 Rename blink::AccessControlStatus AccessControlStatus is a concept introduced at https://html.spec.whatwg.org/#muted-errors. The concept is for scripting, not for loading. This CL renames AccessControlStatus to SanitizeScriptErrors, and moves the file to bindings/core/v8. Bug: 875153 Change-Id: Icc917ef8fc101ec80f7a71941655ce78c64b3016 Reviewed-on: https://chromium-review.googlesource.com/c/1304283 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#607135} [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/bindings.gni [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/rejected_promises.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/rejected_promises.h [add] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/sanitize_script_errors.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/script_controller.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/script_controller.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/script_module_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/v8_script_runner.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/execution_context/execution_context.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/execution_context/execution_context.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/frame/dom_timer_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/frame/pausable_script_executor.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/frame/web_local_frame_impl.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/inspector/inspector_page_agent.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/loader/resource/script_resource.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/loader/resource/script_resource.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/resize_observer/resize_observer_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/script/classic_pending_script.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/script/classic_script.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/script/classic_script.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/script/modulator.h [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/script/script_loader.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/workers/dedicated_worker_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/core/xml/document_xml_tree_viewer.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/modules/csspaint/paint_worklet_test.cc [modify] https://crrev.com/a51ada56d9a8599d4dd1a097110456e4b375fdd2/third_party/blink/renderer/platform/loader/BUILD.gn [delete] https://crrev.com/94eba324eda18982e67915d39b37aa87f29e025a/third_party/blink/renderer/platform/loader/fetch/access_control_status.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc4749afd4081e0e8251dfa00f5109e61204646a commit dc4749afd4081e0e8251dfa00f5109e61204646a Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Nov 12 03:49:12 2018 Remove ExecutionContext::ShouldSanitizeError Now it is a simple flag check and we can inline it. Bug: 875153 Change-Id: I775e6388b27d3931b09b4984da0de0f741e63edb Reviewed-on: https://chromium-review.googlesource.com/c/1309374 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#607139} [modify] https://crrev.com/dc4749afd4081e0e8251dfa00f5109e61204646a/third_party/blink/renderer/bindings/core/v8/rejected_promises.cc [modify] https://crrev.com/dc4749afd4081e0e8251dfa00f5109e61204646a/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc [modify] https://crrev.com/dc4749afd4081e0e8251dfa00f5109e61204646a/third_party/blink/renderer/core/execution_context/execution_context.cc [modify] https://crrev.com/dc4749afd4081e0e8251dfa00f5109e61204646a/third_party/blink/renderer/core/execution_context/execution_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04dc53eaaac123d2dff125aba572d4195d095725 commit 04dc53eaaac123d2dff125aba572d4195d095725 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Nov 27 14:03:57 2018 Remove the "origin" parameter from ImageResource::IsAccessAllowed The parameter is no longer needed, so this CL removes it. Bug: 875153 Change-Id: I985eb2a90c25652d2daf6bbef1aa3e2e7cdd549f Reviewed-on: https://chromium-review.googlesource.com/c/1275469 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#611093} [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/css/cssom/css_style_image_value.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/canvas_image_source.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/html_canvas_element.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/image_element_base.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/canvas/image_element_base.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/media/html_video_element.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/html/media/html_video_element.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/imagebitmap/image_bitmap.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/loader/resource/image_resource.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/loader/resource/image_resource.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/loader/resource/image_resource_content.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/loader/resource/image_resource_content.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/loader/resource/image_resource_info.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/core/svg/svg_fe_image_element.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/csspaint/paint_rendering_context_2d.h [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/shapedetection/shape_detector.cc [modify] https://crrev.com/04dc53eaaac123d2dff125aba572d4195d095725/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
Comment 1 by bugdroid1@chromium.org
, Aug 20