New issue
Advanced search Search tips

Issue 875142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Clicking on team drive root forces full refresh of all team drives

Project Member Reported by slangley@chromium.org, Aug 17

Issue description

If you click on the team drive root on the left hand nav for some reason we then go and call ReadDirectory() on every team drive which causes a full refresh.
 
Description: Show this description
Owner: lucmult@chromium.org
Hum... I couldn't find this in the UI code, I'll sync with slangley@ to try to trace the source of this.
Repro steps:

1. Put a LOG(ERROR) << directory_path.value() here https://cs.chromium.org/chromium/src/components/drive/chromeos/file_system.cc?rcl=bd8b7ee107d6a77d6a56380e2ab8e475d625d221&l=668
2. Startup desktop chromeos
3. Open files app, wait for everything to stabilize.
4. Click on "Team Drives" root, see log output where ReadDirectory() has been called for every team drive.
Status: Started (was: Available)
The code pointed by slangley@ was reading the team drive root when the UI requested some metadata information.

I'm working on the backend to avoid calling the Drive service when reading the metadata, instead just read from the local cache if available.

crrev.com/c/1189763

Update: After some testing lucmult@ uncovered that calls to the backend may be avoided using a cached start page token, but we still see performance issues due to reading resource_metadata_storage for 1000 entries for each team drive. I assume we would see something similar if a drive folder had 1000 entries in it.


Status: Fixed (was: Started)
crrev.com/c/1203596 Has addressed the metadata over-use when using directory tree.

However, it still reads all entries, which we expect to be cached by our C++ backend, based on the start page token.

Sign in to add a comment