Implement direct transition between OOBE and view-based login |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Go through OOBE and enterprise enroll the device (or set up the device to demo mode). (2) If the policy does not have "auto launch public session", login screen is shown. (3) The screen is entirely white. Note that after a browser restart, the login screen becomes normal. (The name is still displayed but is masked by the white background.) It's confirmed that the public session pod seen is rendered by web-ui (even though views-login is default), and the white background is due to the full-screen-dialog property. This has several implications: 1) Browser is not restarted after enterprise enrollment. This may be a bug (filed crbug.com/875117 to track). 2) In case 1) is Won't fix, the views-login screen should implement the code path to transition from web-ui OOBE to views login directly. 3) Demo mode is affected, because it's implemented as a public session and the policy does not have "auto launch". 4) This bug also exists in M69.
,
Aug 17
OK. This problem in at the intersection of OOBE and views-login. I have the following thoughts, but I do hope to listen to both jdufault@ and alemate@'s opinions on this. What I would do is: 1) Make sure the full-screen-dialog property is removed before web-ui login is shown (it's a hacky, one-line change). I'm hesitant to merge to M69, but this screen looks really bad. 2) Rethink about "full-screen-dialog" property. Although there may be other polish issues if we remove it, at least we will not have something like this one. 3) This issue is a blocker for removing the web-ui resources. I'm happy to implement the views-login code path to transition from OOBE, but we are not likely to merge it back to M69. (Both in terms of code complexity and the timing) Again, please chime in as OOBE and views-login owners. I think we have lots of polish issues recently.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df84778a76efc5d8824143bdbb34fbdccd960f39 commit df84778a76efc5d8824143bdbb34fbdccd960f39 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Aug 17 23:40:01 2018 cros: Remove white background before showing web-ui login 1) Verified with --show-webui-login on multiple cases to make sure M69 is working. 2) Implementation of transitioning between OOBE and views login is WIP. It is a must-have before deprecating web-ui login code. Bug: 875128 Change-Id: I1e5cf08d9c978834830ca0d952f61b26b558a7b7 Reviewed-on: https://chromium-review.googlesource.com/1180475 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584240} [modify] https://crrev.com/df84778a76efc5d8824143bdbb34fbdccd960f39/ui/login/account_picker/md_user_pod_row.js
,
Aug 20
,
Aug 20
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 21
Merge approved, M69.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35405c711435dedbeff38085fb41f1c53ae2ade7 commit 35405c711435dedbeff38085fb41f1c53ae2ade7 Author: Wenzhao Zang <wzang@chromium.org> Date: Wed Aug 22 05:41:39 2018 [Merge to M69]cros: Remove white background before showing web-ui login 1) Verified with --show-webui-login on multiple cases to make sure M69 is working. 2) Implementation of transitioning between OOBE and views login is WIP. It is a must-have before deprecating web-ui login code. TBR=wzang@chromium.org (cherry picked from commit df84778a76efc5d8824143bdbb34fbdccd960f39) Bug: 875128 Change-Id: I1e5cf08d9c978834830ca0d952f61b26b558a7b7 Reviewed-on: https://chromium-review.googlesource.com/1180475 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#584240} Reviewed-on: https://chromium-review.googlesource.com/1184396 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#762} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/35405c711435dedbeff38085fb41f1c53ae2ade7/ui/login/account_picker/md_user_pod_row.js
,
Nov 1
,
Nov 2
Is this bug now tracking that after OOBE is complete we shutdown LoginDisplayHostWebUI and startup LoginDisplayHostMojo? SG - might be a little tricky to avoid a couple bad frames during the transition (ie, maybe we will have to migrate the existing WebContents instance, or as a giant hack temporarily disabling framebuffer flipping).
,
Jan 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jdufault@chromium.org
, Aug 17Status: Assigned (was: Untriaged)