New issue
Advanced search Search tips

Issue 875122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Target ChromeOS Touchable UI to Tablet Devices Only

Project Member Reported by robliao@chromium.org, Aug 17

Issue description

For M69, touchable UI will target tablets only.

 
Cc: afakhry@chromium.org tapted@chromium.org
Related http://crbug.com/842291
The Chromium change in http://crrev.com/76c3965de85bcd28a57293cef653a88cbb6061af committed directly to trunk and it appears the changes missed the M68 show.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd74b25b4a16a1dc60e71ad4232cd546e69c163

commit 7dd74b25b4a16a1dc60e71ad4232cd546e69c163
Author: Robert Liao <robliao@chromium.org>
Date: Fri Aug 17 03:19:06 2018

Forward Port M67 Disable Touchable UI by Default Except on Tablets

BUG=842291, 875122 
TBR=kylixrd@chromium.org,sky@chromium.org

Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1
Reviewed-on: https://chromium-review.googlesource.com/1066803
Cr-Original-Commit-Position: refs/branch-heads/3396@{#660}
Cr-Original-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af)
Reviewed-on: https://chromium-review.googlesource.com/1179341
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583952}
[modify] https://crrev.com/7dd74b25b4a16a1dc60e71ad4232cd546e69c163/ui/base/material_design/material_design_controller.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
Status: Started (was: Fixed)
Reopening for the merge. This is currently blocked on CrOS Canary validation, which hasn't made it as of this right.
Labels: OS-Chrome
Labels: -Merge-TBD Merge-Request-69
ChromeOS Canary is lagging behind, so this was tested with a custom build of Chrome from ToT deployed to a ChromeOS device.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 21

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aafbf0dd75c2b4d23095cec5ac2d58a14eed949d

commit aafbf0dd75c2b4d23095cec5ac2d58a14eed949d
Author: Robert Liao <robliao@chromium.org>
Date: Wed Aug 22 17:12:07 2018

Forward Port M67 Disable Touchable UI by Default Except on Tablets

BUG= 875122 
BUG=842291
TBR=kylixrd@chromium.org,sky@chromium.org

Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1
Reviewed-on: https://chromium-review.googlesource.com/1066803
Cr-Original-Original-Commit-Position: refs/branch-heads/3396@{#660}
Cr-Original-Original-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af)
Reviewed-on: https://chromium-review.googlesource.com/1179341
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583952}(cherry picked from commit 7dd74b25b4a16a1dc60e71ad4232cd546e69c163)
Reviewed-on: https://chromium-review.googlesource.com/1185341
Cr-Commit-Position: refs/branch-heads/3497@{#769}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/aafbf0dd75c2b4d23095cec5ac2d58a14eed949d/ui/base/material_design/material_design_controller.cc

Status: Fixed (was: Started)
Labels: Postmortem-Followup

Sign in to add a comment