Target ChromeOS Touchable UI to Tablet Devices Only |
|||||||||||
Issue descriptionFor M69, touchable UI will target tablets only.
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd74b25b4a16a1dc60e71ad4232cd546e69c163 commit 7dd74b25b4a16a1dc60e71ad4232cd546e69c163 Author: Robert Liao <robliao@chromium.org> Date: Fri Aug 17 03:19:06 2018 Forward Port M67 Disable Touchable UI by Default Except on Tablets BUG=842291, 875122 TBR=kylixrd@chromium.org,sky@chromium.org Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1 Reviewed-on: https://chromium-review.googlesource.com/1066803 Cr-Original-Commit-Position: refs/branch-heads/3396@{#660} Cr-Original-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af) Reviewed-on: https://chromium-review.googlesource.com/1179341 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#583952} [modify] https://crrev.com/7dd74b25b4a16a1dc60e71ad4232cd546e69c163/ui/base/material_design/material_design_controller.cc
,
Aug 17
,
Aug 17
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 21
Reopening for the merge. This is currently blocked on CrOS Canary validation, which hasn't made it as of this right.
,
Aug 21
,
Aug 21
ChromeOS Canary is lagging behind, so this was tested with a custom build of Chrome from ToT deployed to a ChromeOS device.
,
Aug 21
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22
Merge approved, M69.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aafbf0dd75c2b4d23095cec5ac2d58a14eed949d commit aafbf0dd75c2b4d23095cec5ac2d58a14eed949d Author: Robert Liao <robliao@chromium.org> Date: Wed Aug 22 17:12:07 2018 Forward Port M67 Disable Touchable UI by Default Except on Tablets BUG= 875122 BUG=842291 TBR=kylixrd@chromium.org,sky@chromium.org Change-Id: Ieef37d1c681f109c41ef2451ed68f341b59531b1 Reviewed-on: https://chromium-review.googlesource.com/1066803 Cr-Original-Original-Commit-Position: refs/branch-heads/3396@{#660} Cr-Original-Original-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}(cherry picked from commit 76c3965de85bcd28a57293cef653a88cbb6061af) Reviewed-on: https://chromium-review.googlesource.com/1179341 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583952}(cherry picked from commit 7dd74b25b4a16a1dc60e71ad4232cd546e69c163) Reviewed-on: https://chromium-review.googlesource.com/1185341 Cr-Commit-Position: refs/branch-heads/3497@{#769} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/aafbf0dd75c2b4d23095cec5ac2d58a14eed949d/ui/base/material_design/material_design_controller.cc
,
Aug 22
,
Nov 1
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by robliao@chromium.org
, Aug 17