Issue metadata
Sign in to add a comment
|
NetworkQualityEstimatorTest.TestTCPSocketRTT failures on chromeos-amd64-generic-rel-vm-tests |
||||||||||||||||||||||
Issue descriptionStack: [ RUN ] NetworkQualityEstimatorTest.TestTCPSocketRTT ../../net/nqe/network_quality_estimator_unittest.cc:1986: Failure Expected: (1U) <= (after_count_tcp_rtt_observations - before_count_tcp_rtt_observations), actual: 1 vs 0 1 Stack trace: #0 0x5990110f17bc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x5990110f1106 testing::internal::AssertHelper::operator=() #2 0x59900fe3b818 net::NetworkQualityEstimatorTest_TestTCPSocketRTT_Test::TestBody() [ FAILED ] NetworkQualityEstimatorTest.TestTCPSocketRTT (125 ms)
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9292aa8b6ea14ce3da0f8e1e9ecb193edc655cd5 commit 9292aa8b6ea14ce3da0f8e1e9ecb193edc655cd5 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Aug 17 07:54:43 2018 Disable TestTCPSocketRTT on chromeos. Disable NetworkQualityEstimatorTest.TestTCPSocketRTT Bug: 875104 Change-Id: Ia7b691d7dbc66621e0df94447ac7d21969eecce7 Reviewed-on: https://chromium-review.googlesource.com/1179227 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#583986} [modify] https://crrev.com/9292aa8b6ea14ce3da0f8e1e9ecb193edc655cd5/net/nqe/network_quality_estimator_unittest.cc
,
Aug 21
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb4bd6995d6c7996554861da9f4294cf29ff7178 commit cb4bd6995d6c7996554861da9f4294cf29ff7178 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Aug 27 18:55:34 2018 Disable TestTCPSocketRTT on chromeos (take 2). crrev.com/c/1179227 didn't actually disable it. Looks like we messed up the conditional a little. Bug: 875104 Change-Id: Ide2caab7969f2aa33f6c16e7b73e2f389273f9fe Reviewed-on: https://chromium-review.googlesource.com/1189033 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#586347} [modify] https://crrev.com/cb4bd6995d6c7996554861da9f4294cf29ff7178/net/nqe/network_quality_estimator_unittest.cc
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc commit 3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc Author: Asanka Herath <asanka@chromium.org> Date: Thu Oct 25 19:46:22 2018 [net] TCP_INFO.tcpi_rtt could legitimately be zero on some kernels. Previously the return value of GetTransportRtt() didn't make it possible to distinguish between an RTT of zero from the case where an RTT could not be determined. However it is possible for this field in tcp_info to be legitimately zero due to the value being rounded down. The Linux kernel attempts to account for that by setting a floor of 1 for the RTT estimation, but that adjustment itself can get rounded off when responding to a getsockopt(TCP_INFO) call. This patch attempts to correct for this by setting a floor of 1µs for a valid RTT value. R=mattm@chromium.org Bug: 874197 , 875104 Change-Id: I3673e13301b62347b5bc2935cda4a7313447ce9c Reviewed-on: https://chromium-review.googlesource.com/c/1273808 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602833} [modify] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/net/socket/tcp_socket_posix.cc [modify] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/net/socket/tcp_socket_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by achuith@chromium.org
, Aug 16